1 Grease test fails in Pharo 2.0

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

1 Grease test fails in Pharo 2.0

Damien Cassou
If you load Grease 1.1.1 in Pharo 2.0, you get 1 failing test:

GRUtf8CodecTest.testCodecUtf8ShortestForm

more details on:

https://ci.inria.fr/pharo-contribution/job/Grease/PHARO=20,VERSION=1.1.1,VM=vm/lastCompletedBuild/testReport/

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm."
Winston Churchill
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: 1 Grease test fails in Pharo 2.0

Philippe Marschall



On Mon, Aug 19, 2013 at 5:16 PM, Damien Cassou <[hidden email]> wrote:
If you load Grease 1.1.1 in Pharo 2.0, you get 1 failing test:

GRUtf8CodecTest.testCodecUtf8ShortestForm

more details on:

https://ci.inria.fr/pharo-contribution/job/Grease/PHARO=20,VERSION=1.1.1,VM=vm/lastCompletedBuild/testReport/


This is "expected" and I believe even marked as an expected failure. This is a test whether [1] is implemented. As long as you don't validate input on the byte level it's not too bad if you don't implement this (famous last words).

 [1] http://www.unicode.org/versions/corrigendum1.html

Cheers
Philippe

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: 1 Grease test fails in Pharo 2.0

Damien Cassou
so there is probably something wrong in the expected failure marking
somewhere, right?

On Tue, Aug 20, 2013 at 3:44 PM, Philippe Marschall
<[hidden email]> wrote:

>
>
>
> On Mon, Aug 19, 2013 at 5:16 PM, Damien Cassou <[hidden email]>
> wrote:
>>
>> If you load Grease 1.1.1 in Pharo 2.0, you get 1 failing test:
>>
>> GRUtf8CodecTest.testCodecUtf8ShortestForm
>>
>> more details on:
>>
>>
>> https://ci.inria.fr/pharo-contribution/job/Grease/PHARO=20,VERSION=1.1.1,VM=vm/lastCompletedBuild/testReport/
>>
>
> This is "expected" and I believe even marked as an expected failure. This is
> a test whether [1] is implemented. As long as you don't validate input on
> the byte level it's not too bad if you don't implement this (famous last
> words).
>
>  [1] http://www.unicode.org/versions/corrigendum1.html
>
> Cheers
> Philippe
>
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>



--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm."
Winston Churchill
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: 1 Grease test fails in Pharo 2.0

Johan Brichau-2
The #expectedFailures method is included in the Grease-Tests-Pharo-Core package but not the Grease-Tests-Pharo20-Core package.

I corrected and published it.

-> Grease 1.1.2

On 20 Aug 2013, at 16:03, Damien Cassou <[hidden email]> wrote:

> so there is probably something wrong in the expected failure marking
> somewhere, right?
>
> On Tue, Aug 20, 2013 at 3:44 PM, Philippe Marschall
> <[hidden email]> wrote:
>>
>>
>>
>> On Mon, Aug 19, 2013 at 5:16 PM, Damien Cassou <[hidden email]>
>> wrote:
>>>
>>> If you load Grease 1.1.1 in Pharo 2.0, you get 1 failing test:
>>>
>>> GRUtf8CodecTest.testCodecUtf8ShortestForm
>>>
>>> more details on:
>>>
>>>
>>> https://ci.inria.fr/pharo-contribution/job/Grease/PHARO=20,VERSION=1.1.1,VM=vm/lastCompletedBuild/testReport/
>>>
>>
>> This is "expected" and I believe even marked as an expected failure. This is
>> a test whether [1] is implemented. As long as you don't validate input on
>> the byte level it's not too bad if you don't implement this (famous last
>> words).
>>
>> [1] http://www.unicode.org/versions/corrigendum1.html
>>
>> Cheers
>> Philippe
>>
>> _______________________________________________
>> seaside-dev mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>
>
>
> --
> Damien Cassou
> http://damiencassou.seasidehosting.st
>
> "Success is the ability to go from one failure to another without
> losing enthusiasm."
> Winston Churchill
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: 1 Grease test fails in Pharo 2.0

Damien Cassou

On Thu, Aug 22, 2013 at 8:05 PM, Johan Brichau <[hidden email]> wrote:
I corrected and published it.

-> Grease 1.1.2

thank you Johan. It fixes my problem.


--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without losing enthusiasm."
Winston Churchill

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev