Smalltalk › Pharo › Pharo Smalltalk Developers

16rff is looking for a fix :)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Stéphane Ducasse

16rff is looking for a fix :)

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Eliot Miranda-2

Re: 16rff is looking for a fix :)

this in the thread spawned by Torsen's posting of Kent's most excellent rant:

ttp://www.threeriversinstitute.org/blog/?p=466

OK, fix is to two implementations of digitValue:. BTW, I haven't fixed Character class>>digitValue: which at least in my Teleplace image looks horribly broken, answering characters not integers. Check your distro, it may also be broken

These fixes attached:

'From Croquet1.0beta of 11 April 2006 [latest update: #1] on 11 February 2010 at 1:17:50 pm'!

!EncodedCharSet class methodsFor: 'class methods' stamp: 'eem 2/11/2010 13:13'!

digitValue: char

"Answer 0-9 if the receiver is $0-$9, 10-35 if it is $A-$Z, and < 0

otherwise. This is used to parse literal numbers of radix 2-36."

| value |

value := char charCode.

value <= $9 asciiValue ifTrue:

[^value - $0 asciiValue].

value >= $A asciiValue ifTrue:

[value <= $Z asciiValue ifTrue: [^value - $A asciiValue + 10].

(value >= $a asciiValue and: [value <= $z asciiValue]) ifTrue:

[^value - $a asciiValue + 10]].

^ -1

! !

!Unicode class methodsFor: 'class methods' stamp: 'eem 2/11/2010 13:17'!

digitValue: char

| value |

value := char charCode.

value <= $9 asciiValue ifTrue:

[^value - $0 asciiValue].

value >= $A asciiValue ifTrue:

[value <= $Z asciiValue ifTrue: [^value - $A asciiValue + 10].

(value >= $a asciiValue and: [value <= $z asciiValue]) ifTrue:

[^value - $a asciiValue + 10]].

value > (DecimalProperty size - 1) ifTrue: [^ -1].

^ (DecimalProperty at: value+1)

! !

2010/2/11 Stéphane Ducasse <[hidden email]>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

digitValue.st (1K) Download Attachment

Stéphane Ducasse

Re: 16rff is looking for a fix :)

Thanks

Stef

On Feb 11, 2010, at 10:21 PM, Eliot Miranda wrote:

> this in the thread spawned by Torsen's posting of Kent's most excellent rant:
> ttp://www.threeriversinstitute.org/blog/?p=466
>
> OK, fix is to two implementations of digitValue:. BTW, I haven't fixed Character class>>digitValue: which at least in my Teleplace image looks horribly broken, answering characters not integers. Check your distro, it may also be broken
>
> These fixes attached:
>
> 'From Croquet1.0beta of 11 April 2006 [latest update: #1] on 11 February 2010 at 1:17:50 pm'!
> !EncodedCharSet class methodsFor: 'class methods' stamp: 'eem 2/11/2010 13:13'!
> digitValue: char
> "Answer 0-9 if the receiver is $0-$9, 10-35 if it is $A-$Z, and < 0
> otherwise. This is used to parse literal numbers of radix 2-36."
>
> | value |
> value := char charCode.
> value <= $9 asciiValue ifTrue:
> [^value - $0 asciiValue].
> value >= $A asciiValue ifTrue:
> [value <= $Z asciiValue ifTrue: [^value - $A asciiValue + 10].
> (value >= $a asciiValue and: [value <= $z asciiValue]) ifTrue:
> [^value - $a asciiValue + 10]].
> ^ -1
> ! !
> !Unicode class methodsFor: 'class methods' stamp: 'eem 2/11/2010 13:17'!
> digitValue: char
>
> | value |
> value := char charCode.
> value <= $9 asciiValue ifTrue:
> [^value - $0 asciiValue].
> value >= $A asciiValue ifTrue:
> [value <= $Z asciiValue ifTrue: [^value - $A asciiValue + 10].
> (value >= $a asciiValue and: [value <= $z asciiValue]) ifTrue:
> [^value - $a asciiValue + 10]].
>
> value > (DecimalProperty size - 1) ifTrue: [^ -1].
> ^ (DecimalProperty at: value+1)
> ! !
>
> 2010/2/11 Stéphane Ducasse <[hidden email]>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> <digitValue.st>_______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Eliot Miranda-2

Re: [squeak-dev] Re: 16rff is looking for a fix :)

In reply to this post by Eliot Miranda-2

On Thu, Feb 11, 2010 at 2:59 PM, Andreas Raab <[hidden email]> wrote:

Eliot Miranda wrote:

this in the thread spawned by Torsen's posting of Kent's most excellent rant:
ttp://www.threeriversinstitute.org/blog/?p=466 <http://www.threeriversinstitute.org/blog/?p=466>

<http://www.threeriversinstitute.org/blog/?p=466>OK, fix is to two implementations of digitValue:. BTW, I haven't fixed Character class>>digitValue: which at least in my Teleplace image looks horribly broken, answering characters not integers. Check your distro, it may also be broken

It's not. It works precisely as advertised (rtfc). What's confusing is that EncodedCharset and Unicode use the selector #digitValue: when the selector should be called #digitValueOf: (i.e., returning the digit value OF a character not creating a new character with a given digit value in this character set).

Doh!

Besides, I very much doubt that the change in hex literals (which I'm very much in favor of btw!) will address Kent's issue.

I agree. But every little bit helps :)

The reality is that there's no way to address his issues because there's no single owner of the brand. Balkanization (which is precisely the right term) happens when you don't have a strong central power which can keep everyone at bay (such as Yugoslavia did before it fell apart). Java for example is owned by Sun and Sun went to court with Microsoft to ensure brand integrity. Unless you have an owner of "Smalltalk" (whatever that is) there isn't going to be a consistent set of libraries because everyone can and will push into different directions.

I disagree. I think the community has managed to agree on the utility of several things. Many of the Squeak collection extensions have found their way into VisualWorks for example because they're clearly useful and convenient. I think the problem with the standard is architectural, and that that architectural limitation was built-in from the get-go It was intended to be something the vendors could agree upon, not a useful standard. The issue for the vendors was in having a check-box for Smalltalk compared to other languages; C had a standard, C++ had a standard, so Smalltalk needed one. ut the standard wasn't useful for the community, and I think as a result hasn't been that useful for the vendors. Being x3j20-compatible didn't mean enough.

But at the time things were very different. Test suites were not in widespread use and no one had developed one yet. A good thing to come out of x3j20 and the first CampSmalltalk was a test suite. The web was in its infancy; there was no javadoc or www.python.org/doc/. Squeak was very young. So it's not surprising that the standard failed to be that useful. The world changed very quickly soon there-after.

A differently-architected standard could be useful and a gently unifying force. But it needs to address the challenges of standardising Smalltalk as it exists in its current context, not as it was in the early 90's.

Cheers,
- Andreas

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project