60445, empty version info stamps

On Fri, Mar 17, 2017 at 5:30 PM, Ben Coman <[hidden email]> wrote:

On Fri, Mar 17, 2017 at 5:22 PM, Ben Coman <[hidden email]> wrote:

In 60445, browse the implementors of #cacheAt:for:ifAbsentPut:
and the view the Versions of each. 

Curiously some of them have a blank user/date.

There are others...
    errors := OrderedCollection new.

    versions := (CompiledMethod allInstances) flatCollect: [:cm| 

[VersionBrowser new setRGMethodFrom: cm asRingDefinition; buildChangeList] 

on: Error do:[:ex| errors add: (cm -> ex). #()] ].

    versions size. 

"112131"

    emptyStamps := versions select: [:rgm| rgm stamp = ''].

    emptyStamps size. 

"9264"

or 8%

Maybe some are historic, but I'd guess this one at least is not so old... 

GLMFastListDataSource>>cacheAt:for:ifAbsentPut:

What reasonable action do we need to take?

cheers -ben

P.S. 

the errors were all "UTF8InvalidText: Invalid utf8 input detected" for these methods...

  QuotedPrintableMimeConverter >> #decode:

  StringTest >> #UTF8InvalidText:

  EpEnabledIntegrationTest >> #setUp

  SingleCodeCriticResultList >> #diffTextForChange:

Further analysis...

60000    versions=93482                   emptyStamps=8964

60050    versions=95654   (+2172)    emptyStamps=9214  (+250)

60100    versions=96112   (+458)      emptyStamps=9212  (-2)

60150    versions=97335   (+1223)    emptyStamps=9211  (-1)

60200    versions=98030   (+695)      emptyStamps=9169  (-42)

60250    versions=99779   (+1749)    emptyStamps=9282  (113)

60300    versions=109440 (+9661)    emptyStamps=9153  (-129)

60350    versions=109586 (+146)      emptyStamps=9173  (+20)

60400    versions=110278 (+692)      emptyStamps=9185  (+12)

60455    versions=112131 (+1853)    emptyStamps=9264  (+79)

cheers -ben

btw, will same user/date for multiple revisions remain available in a Versions window?

cheers -ben

On Fri, Mar 17, 2017 at 7:02 PM, Pavel Krivanek <[hidden email]> wrote:

Pharo 7 will be bootstrapped from the metadata-less filetree where timestamps are ignored completely. So the question is if we should put energy into this...

-- Pavel

2017-03-17 11:57 GMT+01:00 Ben Coman <[hidden email]>:

On Fri, Mar 17, 2017 at 5:30 PM, Ben Coman <[hidden email]> wrote:

On Fri, Mar 17, 2017 at 5:22 PM, Ben Coman <[hidden email]> wrote:

In 60445, browse the implementors of #cacheAt:for:ifAbsentPut:
and the view the Versions of each. 

Curiously some of them have a blank user/date.

There are others...
    errors := OrderedCollection new.

    versions := (CompiledMethod allInstances) flatCollect: [:cm| 

[VersionBrowser new setRGMethodFrom: cm asRingDefinition; buildChangeList] 

on: Error do:[:ex| errors add: (cm -> ex). #()] ].

    versions size. 

"112131"

    emptyStamps := versions select: [:rgm| rgm stamp = ''].

    emptyStamps size. 

"9264"

or 8%

Maybe some are historic, but I'd guess this one at least is not so old... 

GLMFastListDataSource>>cacheAt:for:ifAbsentPut:

What reasonable action do we need to take?

cheers -ben

P.S. 

the errors were all "UTF8InvalidText: Invalid utf8 input detected" for these methods...

  QuotedPrintableMimeConverter >> #decode:

  StringTest >> #UTF8InvalidText:

  EpEnabledIntegrationTest >> #setUp

  SingleCodeCriticResultList >> #diffTextForChange:

Further analysis...

60000    versions=93482                   emptyStamps=8964

60050    versions=95654   (+2172)    emptyStamps=9214  (+250)

60100    versions=96112   (+458)      emptyStamps=9212  (-2)

60150    versions=97335   (+1223)    emptyStamps=9211  (-1)

60200    versions=98030   (+695)      emptyStamps=9169  (-42)

60250    versions=99779   (+1749)    emptyStamps=9282  (113)

60300    versions=109440 (+9661)    emptyStamps=9153  (-129)

60350    versions=109586 (+146)      emptyStamps=9173  (+20)

60400    versions=110278 (+692)      emptyStamps=9185  (+12)

60455    versions=112131 (+1853)    emptyStamps=9264  (+79)

cheers -ben