7.7.1 compare tool: inconsistent Left-right-visualization

Hello,

the visualization of the "left" and "right" packages in the compare tool
is inconsistent. An example:

http://www.abload.de/img/compare-tool1yl2.png

here we see three changes:

1. a changed method (#construct:)
2. a new method (#newMethod)
3. a deleted method (#readStream)

I've highlighted my changes with a red border.

As you can see in the screenshot, the changes are sometimes displayed on
the right side (changed methods) and sometimes on the left side
(new/deleted methods).

This is highly confusing when reviewing larger change sets.
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Good picture! I take it you want the source in the right-hand package to
always be on the right? So in this case, newMethod's source should be
moved to the right column. I'd agree.

Steve

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Alternatively, if one wanted to maximize space for source of
adds/removes, you could flip the comparison to always show "current" on
the left...

-Boris

--
DeepCove Labs Ltd.
+1 (604) 689-0322
4th floor, 595 Howe Street
Vancouver, British Columbia
Canada V6C 2T5
http://tinyurl.com/r7uw4

PacNet Services (Europe) Ltd.
+353 (0)61 714-360
Shannon Airport House, SFZ
County Clare, Ireland
http://tinyurl.com/y952amr

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message header.
Unless otherwise indicated, it contains information that is private and
confidential. If you have received it in error, please notify the sender
and delete the entire message including any attachments.

Thank you.


-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On
Behalf Of Steven Kelly
Sent: 23 September 2010 11:24
To: [hidden email]
Subject: Re: [vwnc] 7.7.1 compare tool: inconsistent
Left-right-visualization

Good picture! I take it you want the source in the right-hand package to
always be on the right? So in this case, newMethod's source should be
moved to the right column. I'd agree.

Steve

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Am 23.09.2010 12:24, schrieb Steven Kelly:
> Good picture! I take it you want the source in the right-hand package to
> always be on the right? So in this case, newMethod's source should be
> moved to the right column. I'd agree.

I would prefer to have the image version on the left and the store
version on the right.

Usually I use "Store -> Compare with parent" in the RB to compare the
image version against the last published version. This will open a
compare tool with the layout shown in the screenshot.

Unfortunately, when the image version is on the "left" side, some menu
items like "Revert" are missing again, because the menu items expect the
store version on the left side. This also happens when flipping the
sides, like Boris suggested.
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Am 23.09.2010 12:27, schrieb Boris Popov, DeepCove Labs:
> Alternatively, if one wanted to maximize space for source of
> adds/removes, you could flip the comparison to always show "current" on
> the left...

flipping sides will not only affect the layout, but also flip the
comparison, so added methods in the image will be shown as remove
methods and vice versa.
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

> I would prefer to have the image version on the left and the store
> version on the right.

I don't really care which is left and which is right originally, they
can be switched. My point was that it's better to have a layout like
below, where source code that exists in version A is shown in one
column, and source in version B in another:

version A  |  version B
-----------+------------
changeInA  |  changeInB
onlyInA    |
           |  onlyInB


I think the tool should keep things separated into columns like this
regardless of whether it is comparing "old store version" vs. "new store
version", the reverse of that, or "Compare (image) with parent" (which
is what I do most).

Cheers,
Steve

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

On Sep 23, 2010, at 3:03 AM, Holger Kleinsorgen wrote:

61187: "Look at stronger columnated layout for comparison tool"

--
Travis Griggs
Objologist
"It had better be a pretty good meeting, to be better than no meeting
at all" - Boyd K Packer


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc