[7.7] Source format differs between 'manual' and 'on save'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[7.7] Source format differs between 'manual' and 'on save'

Boris Popov, DeepCove Labs (SNN)

It looks like performing manual format (Ctrl-O or via right-click menu) takes available browser width into account whereas performing format on method save does not,

 

Manual 1 (wide browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy] ifFalse: [ownershipPolicy].

 

Manual 2 (narrow browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil

                                ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy]

                                ifFalse: [ownershipPolicy].

 

On Save 1 (wide browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil

                                ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy]

                                ifFalse: [ownershipPolicy].

 

On Save 2 (narrow browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil

                                ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy]

                                ifFalse: [ownershipPolicy].

 

I would prefer if all 4 behaves consistent and it looks like removing available width from the equation would do the trick nicely?

 

Regards,

 

-Boris

 

--

DeepCove Labs Ltd.

+1 (604) 689-0322

4th floor, 595 Howe Street

Vancouver, British Columbia

Canada V6C 2T5

http://tinyurl.com/r7uw4

 

PacNet Services (Europe) Ltd.

+353 (0)61 714-360

Shannon Airport House, SFZ

County Clare, Ireland

http://tinyurl.com/y952amr

 

CONFIDENTIALITY NOTICE

 

This email is intended only for the persons named in the message header. Unless otherwise indicated, it contains information that is private and confidential. If you have received it in error, please notify the sender and delete the entire message including any attachments.

 

Thank you.

 


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [7.7] Source format differs between 'manual' and 'on save'

Boris Popov, DeepCove Labs (SNN)

formattedNode: anRBProgramNode

 

                | formatter |

                formatter := anRBProgramNode formatterClass new.

                (self textController notNil and: [formatter respondsTo: #lineLengthLimit:])

                                ifTrue: [formatter lineLengthLimit: self textController view bounds width

                                                                                                // (self textController view graphicsContext widthOfString: 'M')].

                ^formatter format: anRBProgramNode

 

-Boris

 

--

DeepCove Labs Ltd.

+1 (604) 689-0322

4th floor, 595 Howe Street

Vancouver, British Columbia

Canada V6C 2T5

http://tinyurl.com/r7uw4

 

PacNet Services (Europe) Ltd.

+353 (0)61 714-360

Shannon Airport House, SFZ

County Clare, Ireland

http://tinyurl.com/y952amr

 

CONFIDENTIALITY NOTICE

 

This email is intended only for the persons named in the message header. Unless otherwise indicated, it contains information that is private and confidential. If you have received it in error, please notify the sender and delete the entire message including any attachments.

 

Thank you.

 

From: [hidden email] [mailto:[hidden email]] On Behalf Of Boris Popov, DeepCove Labs (YVR)
Sent: 10 May 2010 11:36
To: [hidden email]
Subject: [vwnc] [7.7] Source format differs between 'manual' and 'on save'

 

It looks like performing manual format (Ctrl-O or via right-click menu) takes available browser width into account whereas performing format on method save does not,

 

Manual 1 (wide browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy] ifFalse: [ownershipPolicy].

 

Manual 2 (narrow browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil

                                ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy]

                                ifFalse: [ownershipPolicy].

 

On Save 1 (wide browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil

                                ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy]

                                ifFalse: [ownershipPolicy].

 

On Save 2 (narrow browser):

 

ownershipPolicy

 

                ^ownershipPolicy == nil

                                ifTrue: [ownershipPolicy := self class defaultOwnershipPolicy]

                                ifFalse: [ownershipPolicy].

 

I would prefer if all 4 behaves consistent and it looks like removing available width from the equation would do the trick nicely?

 

Regards,

 

-Boris

 

--

DeepCove Labs Ltd.

+1 (604) 689-0322

4th floor, 595 Howe Street

Vancouver, British Columbia

Canada V6C 2T5

http://tinyurl.com/r7uw4

 

PacNet Services (Europe) Ltd.

+353 (0)61 714-360

Shannon Airport House, SFZ

County Clare, Ireland

http://tinyurl.com/y952amr

 

CONFIDENTIALITY NOTICE

 

This email is intended only for the persons named in the message header. Unless otherwise indicated, it contains information that is private and confidential. If you have received it in error, please notify the sender and delete the entire message including any attachments.

 

Thank you.

 


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc