Smalltalk › Instantiations

[8.5.2] Changes browser defect (probably affects all versions)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

Richard Sargent

[8.5.2] Changes browser defect (probably affects all versions)

Administrator

If you add a comment to a method above the method declaration, the changes browser fails to show the difference.

For example, I changed Object>>#ifNil: as follows.

"Extraneous comment
added here."
ifNil: nilBlock
    "If the receiver is the nil object, then answer the result of evaluating @nilBlock,
    a <niladicValuable> or <monadicValuable> block; otherwise answer the receiver.

    If @nilBlock is a <monadicValuable> block, it is evaluated with the receiver as
    its argument."

When browsing changes, the difference is never highlighted.

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/va-smalltalk.
For more options, visit https://groups.google.com/groups/opt_out.

Seth Berman

Re: [8.5.2] Changes browser defect (probably affects all versions)

Hi Richard,

Thank you...I am able to reproduce in our current builds.

Opened case: 53482

The issue seems to be in EsStringComparer>>unEqualRuns.

Changing

run first > top

ifTrue: [unEqualRuns add: (Array with: top with: run first - 1)].

to:

(run first x > top x or: [run first y > top y])

ifTrue: [unEqualRuns add: (Array with: top with: run first - 1)].

*appears* to fix this issue, but I will need to test this more.

This will be fixed in 8.6.1

-- Seth Berman

On Monday, January 27, 2014 2:56:27 PM UTC-5, Richard Sargent wrote:

If you add a comment to a method above the method declaration, the changes browser fails to show the difference.

For example, I changed Object>>#ifNil: as follows.
"Extraneous comment
added here."
ifNil: nilBlock
    "If the receiver is the nil object, then answer the result of evaluating @nilBlock,
    a <niladicValuable> or <monadicValuable> block; otherwise answer the receiver.

    If @nilBlock is a <monadicValuable> block, it is evaluated with the receiver as
    its argument."

When browsing changes, the difference is never highlighted.