[8.5.2] Far too many explicit references to EsCompiler and EsParser

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[8.5.2] Far too many explicit references to EsCompiler and EsParser

Richard Sargent
Administrator
This complaint almost certainly applies to all versions of VA. Almost every reference to EsCompiler is incorrect. There should only be one or two such references.

While some of them are harmless, they represent a misuse of the intended Smalltalk compiler model, namely the global Compiler and the expression Compiler parserClass.
StsPowerTools class>>#parseTreeFor:forCompiledMethod:
StsPowerTools class>>#parseTreeNoCommentsFor:class:
EpPackager>>#isCompilerIncluded
EmMethodEdition>>#compile:in:
EpBaseImageComponentPackagingInstructions class>>#packagingRulesFor:
ClassDescription>>#copy:from:ifNewAddTo:
ClassDescription>>#regenerate:
EsCompiler class>>#initializeAfterLoad (one of the few valid references)
AbtFeatureCtl>>#analyzeFeatureExpression:
Behavior>>#compiler
EmFileOutInterface class>>#fileInSourceFrom:
AbtFeatureLoader class>>#checkIfValidFeature:
EtClassBrowser>>#bytecodesStringFor:
EsParser class>>#parse:class:scanComments:errorHandler:ifFail:
and
StsPowerTools class>>#parseTreeFor:
StsPowerTools class>>#parseTreeFor:forCompiledMethod:
StsPowerTools class>>#parseTreeNoCommentsFor:class:
EtWindow>>#stsInspectParseTree
EsParsing class>>#removing (one of the few valid references)
EsCompiler class>>#initializeAfterLoad (one of the few valid references)
EtAbstractMethodsBrowser>>#stsCopyMessagePattern
CompiledMethod>>#stsParseTree


Any chance of this being corrected for the 8.6.1 release?

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/va-smalltalk.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [8.5.2] Far too many explicit references to EsCompiler and EsParser

Seth Berman
Hi Richard,

Thank you...you are correct. Unfortunately it is too late to make it into 8.6.1.
I have created case 56159 to correct this issue for the following release.

-- Seth

On Monday, September 15, 2014 12:33:24 PM UTC-4, Richard Sargent wrote:
This complaint almost certainly applies to all versions of VA. Almost every reference to EsCompiler is incorrect. There should only be one or two such references.

While some of them are harmless, they represent a misuse of the intended Smalltalk compiler model, namely the global Compiler and the expression Compiler parserClass.
StsPowerTools class>>#parseTreeFor:forCompiledMethod:
StsPowerTools class>>#parseTreeNoCommentsFor:class:
EpPackager>>#isCompilerIncluded
EmMethodEdition>>#compile:in:
EpBaseImageComponentPackagingInstructions class>>#packagingRulesFor:
ClassDescription>>#copy:from:ifNewAddTo:
ClassDescription>>#regenerate:
EsCompiler class>>#initializeAfterLoad (one of the few valid references)
AbtFeatureCtl>>#analyzeFeatureExpression:
Behavior>>#compiler
EmFileOutInterface class>>#fileInSourceFrom:
AbtFeatureLoader class>>#checkIfValidFeature:
EtClassBrowser>>#bytecodesStringFor:
EsParser class>>#parse:class:scanComments:errorHandler:ifFail:
and
StsPowerTools class>>#parseTreeFor:
StsPowerTools class>>#parseTreeFor:forCompiledMethod:
StsPowerTools class>>#parseTreeNoCommentsFor:class:
EtWindow>>#stsInspectParseTree
EsParsing class>>#removing (one of the few valid references)
EsCompiler class>>#initializeAfterLoad (one of the few valid references)
EtAbstractMethodsBrowser>>#stsCopyMessagePattern
CompiledMethod>>#stsParseTree


Any chance of this being corrected for the 8.6.1 release?

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/va-smalltalk.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: [8.5.2] Far too many explicit references to EsCompiler and EsParser

Richard Sargent
Administrator
On Monday, September 15, 2014 1:18:55 PM UTC-7, Seth Berman wrote:
Thank you...you are correct. Unfortunately it is too late to make it into 8.6.1.
I have created case 56159 to correct this issue for the following release.

Thanks, Seth. I was hoping, but I appreciate the need to ship a product. :-)
 

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/va-smalltalk.
For more options, visit https://groups.google.com/d/optout.