8.6 EsLogManager error: and info:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

8.6 EsLogManager error: and info:

jtuchel
Hi,

the removal of error: and info: on EsLogManager was necessary, because both methods are overrides of important functions.

But the way it was done by simply removing them instead of deprecating them (like all the variants of these 2 methods with additional parameters) would've been better, because you get all kinds of strange problems due to the fact that now suddenly the logger throws errors instead of logging them. 
The removal of info: causes troubles in the debugger because it now accesses a String instead of a class info.

So maybe there was a good reason for not deprecating these two that I haven't thought of yet.

To make life easier, it would be good if INstantiations provided rewrite rules to replace all sends of #info: and #error: to EsLogManager with logError: and logInfo: and a short description how to apply it.
The stupid task of going through all senders of #error: in the image and doing this by hand takes an hour or two but could be done in a minute.

So even if it's too late for this release (I don't think it is), maybe you could consider things like these for the next ones.

Joachim

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/va-smalltalk.
For more options, visit https://groups.google.com/groups/opt_out.