A Good Refactoring

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

A Good Refactoring

MrGwen
Hi,

I've finished the state refactoring, there are maybe some regressions
feel free to report bugs !!! I've done another code clean up, I've
made an abstract class for the class browser widget, thus all the
browsers (the classical browser, inspector, SUnit) reuse it.

For the next refactoring I want to remove the onFocusPerform:, a brief
explanation for those who don't know in VisualGST when you press Ctrl+B
Visual checks what widget has the focus before performing the command,
but Gtk allows to put shortcut at the widget level, unfortunately for
each shortcut a new signal should be added; I plan to fix it soon
as possible. I've never liked it's time to kill it ;-)

I think after that they are no big changes in term of design (Paolo any
remarks?). Maybe polishing the tools: new icons, tooltip, ...

Another idea in mind, I want to extend the idea of hidden pane with such
tools:
   - collaborative working
   - package info
   - SUnit (display quickly all the tests of your package and the
regressions)
   - ...

Cheers,
Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: A Good Refactoring

Paolo Bonzini-2
On Wed, Apr 13, 2011 at 23:31, Gwenael Casaccio <[hidden email]> wrote:
> I think after that they are no big changes in term of design (Paolo any
> remarks?).

Well there would be the "multiple tools in tabs" part. :)  The Command
pattern has enabled making menus and toolbars that vary depend on the
active tool, but we're not using all the power yet!

It's probably easiest to just make N menubars and N toolbars, and
show/hide all but one.  With this approach it should be much simpler
than the state refactoring though!

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk