[ANN] 10234 SmallLint cleaning

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[ANN] 10234 SmallLint cleaning

Stéphane Ducasse
addressed or tagged as addressed

Issue 523: [SmallLint] Undeclared variables
This check is similar to the "References an undeclared variable"  
check, but it looks for variables that
are not defined in the class or in the undeclared dictionary. You  
probably had to work hard to get
your code in this state.

        PasteUpMorph>>#makeNewDrawing:at:
        Project>>#storeSegmentNoFile
        CollectionRootTest>>#nonEmpty
        ScriptLoader>>#update10196
        ScriptLoader>>#update10074

Issue 525: useless boolean checks on Morphic extras
        MorphicExtras Check for a =, ==, ~=, or ~~ message being sent to true/
false or with true/false as the argument.
        SqueakPage>>#write
        URLMorph>>#mouseUp:
        ClockMorph>>#addCustomMenuItems:hand:
        ClockMorph>>#step
        ClockMorph>>#toggleShowingSeconds
        ClockMorph>>#toggleShowing24hr
        MorphObjectOut>>#doesNotUnderstand:
        SketchEditorMorph>>#verifyState:
        SketchEditorMorph>>#deliverPainting:evt:
        FlapTab>>#inboard
        FlapTab>>#flapShowing
        FlapTab>>#tabSelected
        ReferenceMorph>>#isHighlighted
        SimpleSliderMorph>>#truncate

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] 10234 SmallLint cleaning

Igor Stasenko
2009/2/14 Stéphane Ducasse <[hidden email]>:

> addressed or tagged as addressed
>
> Issue 523:      [SmallLint] Undeclared variables
> This check is similar to the "References an undeclared variable"
> check, but it looks for variables that
> are not defined in the class or in the undeclared dictionary. You
> probably had to work hard to get
> your code in this state.
>
>        PasteUpMorph>>#makeNewDrawing:at:
>        Project>>#storeSegmentNoFile

not sure about the rest methods, but these two showing that people
worked hard to get code in this state.
or maybe its my brain is too small to fit such amount of code in
attempt to understand it.

>        CollectionRootTest>>#nonEmpty
>        ScriptLoader>>#update10196
>        ScriptLoader>>#update10074
>
> Issue 525:      useless boolean checks on Morphic extras
>        MorphicExtras Check for a =, ==, ~=, or ~~ message being sent to true/
> false or with   true/false as the argument.
>        SqueakPage>>#write
>        URLMorph>>#mouseUp:
>        ClockMorph>>#addCustomMenuItems:hand:
>        ClockMorph>>#step
>        ClockMorph>>#toggleShowingSeconds
>        ClockMorph>>#toggleShowing24hr
>        MorphObjectOut>>#doesNotUnderstand:
>        SketchEditorMorph>>#verifyState:
>        SketchEditorMorph>>#deliverPainting:evt:
>        FlapTab>>#inboard
>        FlapTab>>#flapShowing
>        FlapTab>>#tabSelected
>        ReferenceMorph>>#isHighlighted
>        SimpleSliderMorph>>#truncate
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Best regards,
Igor Stasenko AKA sig.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] 10234 SmallLint cleaning

Stéphane Ducasse

On Feb 14, 2009, at 6:59 PM, Igor Stasenko wrote:

> 2009/2/14 Stéphane Ducasse <[hidden email]>:
>> addressed or tagged as addressed
>>
>> Issue 523:      [SmallLint] Undeclared variables
>> This check is similar to the "References an undeclared variable"
>> check, but it looks for variables that
>> are not defined in the class or in the undeclared dictionary. You
>> probably had to work hard to get
>> your code in this state.
>>
>>       PasteUpMorph>>#makeNewDrawing:at:
>>       Project>>#storeSegmentNoFile
>
> not sure about the rest methods, but these two showing that people
> worked hard to get code in this state.
> or maybe its my brain is too small to fit such amount of code in
> attempt to understand it.

Indeed this is why I tagged the code as "let us let it like that "

>
>
>>       CollectionRootTest>>#nonEmpty
>>       ScriptLoader>>#update10196
>>       ScriptLoader>>#update10074
>>
>> Issue 525:      useless boolean checks on Morphic extras
>>       MorphicExtras Check for a =, ==, ~=, or ~~ message being sent  
>> to true/
>> false or with   true/false as the argument.
>>       SqueakPage>>#write
>>       URLMorph>>#mouseUp:
>>       ClockMorph>>#addCustomMenuItems:hand:
>>       ClockMorph>>#step
>>       ClockMorph>>#toggleShowingSeconds
>>       ClockMorph>>#toggleShowing24hr
>>       MorphObjectOut>>#doesNotUnderstand:
>>       SketchEditorMorph>>#verifyState:
>>       SketchEditorMorph>>#deliverPainting:evt:
>>       FlapTab>>#inboard
>>       FlapTab>>#flapShowing
>>       FlapTab>>#tabSelected
>>       ReferenceMorph>>#isHighlighted
>>       SimpleSliderMorph>>#truncate
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
>
>
> --
> Best regards,
> Igor Stasenko AKA sig.
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project