[ANN] Closures for beta testers

> Rob Rothwell writes:
>> Well, I don't have any "tough, real world examples," but the  
>> example Bert
>> gave me:
>>
>> multiply := Array new: 4.
>> 1 to: 4 do: [:i |
>>       multiply at: i put: [:x | x * i].
>> ].
>>
>> (multiply at: 3) value: 5.
>>
>> Resulted in the appropriate answer 15!!!
>
> I tried this on Linux, and it works.
>
> Poking around a bit more brought up the emergency evaluator because
> BlockClosure doesn't understand #isValid:.
>
> Bryce
>
> P.S I'm not going to have much time in April as we have
> family staying and our second son is due.
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

> On Sun, Mar 22, 2009 at 10:11 PM, Stéphane Ducasse
> <[hidden email]> wrote:
>> I can post the two images somewhere if this helps.
>
> Please provide a new image or update the stream.
>
> --
> Damien Cassou
> http://damiencassou.seasidehosting.st
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

> Stef,
>
> Adding #isValid got me a little further along.  I was able to select the new theme and can at least open a debugger, though _using_ it stirs up trouble over #asMinimalRepresentation (or similar method).  In trying to evaluate 'hello' at:200, I was faced with some message boxes claiming there was no such method; that seemed to happen w/ vistary and not watery2???  I too had problems closing windows.
>
> Bill
>
> ---
> Wilhelm K. Schwab, Ph.D.
> bschwab AT anest DOT ufl DOT edu
>
> -----Original Message-----
> From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse
> Sent: Sunday, March 22, 2009 1:35 PM
> To: [hidden email]
> Cc: Eliot Miranda
> Subject: Re: [Pharo-project] [ANN] Closures for beta testers
>
>  
>>   UIThemeVistary beCurrent.
>>    
>
> what is nice is that the VM does not crash.
> I cannot open any browser.
> So in another image I checked a bit.
>
> BlockContext defined isValid (a polymoprph-EventEnhancements)
>
> sent by
>
> BlockContext>>isValid
> "Answer true so we can be used in event dispatching."
>
> ^true
>
> WeakActionSequence>>asMinimalRepresentation
>
> | valid |
> valid := self select: [:e | e isValid ].
> valid size = 0
> ifTrue: [^nil].
> valid size = 1
> ifTrue: [^valid first].
> ^valid
>
> I do not really know the code of gary.
> As a pure hack I added isValid to blockClosure to return true and I did not get the problem
>
> of course this is a shitty way to answer the problem.
>
>
> Now when I close using the cross on the right (and not the button on the left) the vistaryStyle I get similar problems
>
> [closure] in UIThemeVistary>>createCloseBoxFor: DNU asMinimalRepresentation
>
>
> BlockContext>>asMinimalRepresentation
> "Answer the receiver."
>
> ^self
>
> I defined the same in BlockClosure and it worked but I would prefer to understand what I was doing.
>
>
>
>
> stef
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
>  

> http://code.google.com/p/pharo/issues/detail?id=337
>
> I believe the resolution then was Gary moving the two methods to
> Polymorph-Overrides.
> Probably some house-cleaning which caused them to be lost this time.
> I still stand by my OR: suggestion from back then, isValid is a terrible
> method name, imo ;)
>
> Cheers,
> Henry
>
> Schwab,Wilhelm K wrote:
>  
>> Stef,
>>
>> Adding #isValid got me a little further along.  I was able to select the new theme and can at least open a debugger, though _using_ it stirs up trouble over #asMinimalRepresentation (or similar method).  In trying to evaluate 'hello' at:200, I was faced with some message boxes claiming there was no such method; that seemed to happen w/ vistary and not watery2???  I too had problems closing windows.
>>
>> Bill
>>
>> ---
>> Wilhelm K. Schwab, Ph.D.
>> bschwab AT anest DOT ufl DOT edu
>>
>> -----Original Message-----
>> From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse
>> Sent: Sunday, March 22, 2009 1:35 PM
>> To: [hidden email]
>> Cc: Eliot Miranda
>> Subject: Re: [Pharo-project] [ANN] Closures for beta testers
>>
>>  
>>    
>>>   UIThemeVistary beCurrent.
>>>    
>>>      
>> what is nice is that the VM does not crash.
>> I cannot open any browser.
>> So in another image I checked a bit.
>>
>> BlockContext defined isValid (a polymoprph-EventEnhancements)
>>
>> sent by
>>
>> BlockContext>>isValid
>> "Answer true so we can be used in event dispatching."
>>
>> ^true
>>
>> WeakActionSequence>>asMinimalRepresentation
>>
>> | valid |
>> valid := self select: [:e | e isValid ].
>> valid size = 0
>> ifTrue: [^nil].
>> valid size = 1
>> ifTrue: [^valid first].
>> ^valid
>>
>> I do not really know the code of gary.
>> As a pure hack I added isValid to blockClosure to return true and I did not get the problem
>>
>> of course this is a shitty way to answer the problem.
>>
>>
>> Now when I close using the cross on the right (and not the button on the left) the vistaryStyle I get similar problems
>>
>> [closure] in UIThemeVistary>>createCloseBoxFor: DNU asMinimalRepresentation
>>
>>
>> BlockContext>>asMinimalRepresentation
>> "Answer the receiver."
>>
>> ^self
>>
>> I defined the same in BlockClosure and it worked but I would prefer to understand what I was doing.
>>
>>
>>
>>
>> stef
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>>  
>>    
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
>  

> My bad, meant Polymorph-EventEnhancements.
> Some more details for those interested (hope I remember correctly this
> time):
> The two methods are needed if one wants to be able to use something as
> argument for the evaluate part of Object when: #XYZ evaluate: myBlock,
> due to ActionSequence implementation details...
> For Polymorph, in the createXYZBoxFor: methods in the Vistary themes,
> addUpAction: does just that with blocks, thus the methods are needed  
> for it.
>
> Cheers,
> Henry
>
> Henrik Johansen wrote:
>> http://code.google.com/p/pharo/issues/detail?id=337
>>
>> I believe the resolution then was Gary moving the two methods to
>> Polymorph-Overrides.
>> Probably some house-cleaning which caused them to be lost this time.
>> I still stand by my OR: suggestion from back then, isValid is a  
>> terrible
>> method name, imo ;)
>>
>> Cheers,
>> Henry
>>
>> Schwab,Wilhelm K wrote:
>>
>>> Stef,
>>>
>>> Adding #isValid got me a little further along.  I was able to  
>>> select the new theme and can at least open a debugger, though  
>>> _using_ it stirs up trouble over #asMinimalRepresentation (or  
>>> similar method).  In trying to evaluate 'hello' at:200, I was  
>>> faced with some message boxes claiming there was no such method;  
>>> that seemed to happen w/ vistary and not watery2???  I too had  
>>> problems closing windows.
>>>
>>> Bill
>>>
>>> ---
>>> Wilhelm K. Schwab, Ph.D.
>>> bschwab AT anest DOT ufl DOT edu
>>>
>>> -----Original Message-----
>>> From: [hidden email] [mailto:[hidden email]
>>> ] On Behalf Of Stéphane Ducasse
>>> Sent: Sunday, March 22, 2009 1:35 PM
>>> To: [hidden email]
>>> Cc: Eliot Miranda
>>> Subject: Re: [Pharo-project] [ANN] Closures for beta testers
>>>
>>>
>>>
>>>>  UIThemeVistary beCurrent.
>>>>
>>>>
>>> what is nice is that the VM does not crash.
>>> I cannot open any browser.
>>> So in another image I checked a bit.
>>>
>>> BlockContext defined isValid (a polymoprph-EventEnhancements)
>>>
>>> sent by
>>>
>>> BlockContext>>isValid
>>> "Answer true so we can be used in event dispatching."
>>>
>>> ^true
>>>
>>> WeakActionSequence>>asMinimalRepresentation
>>>
>>> | valid |
>>> valid := self select: [:e | e isValid ].
>>> valid size = 0
>>> ifTrue: [^nil].
>>> valid size = 1
>>> ifTrue: [^valid first].
>>> ^valid
>>>
>>> I do not really know the code of gary.
>>> As a pure hack I added isValid to blockClosure to return true and  
>>> I did not get the problem
>>>
>>> of course this is a shitty way to answer the problem.
>>>
>>>
>>> Now when I close using the cross on the right (and not the button  
>>> on the left) the vistaryStyle I get similar problems
>>>
>>> [closure] in UIThemeVistary>>createCloseBoxFor: DNU  
>>> asMinimalRepresentation
>>>
>>>
>>> BlockContext>>asMinimalRepresentation
>>> "Answer the receiver."
>>>
>>> ^self
>>>
>>> I defined the same in BlockClosure and it worked but I would  
>>> prefer to understand what I was doing.
>>>
>>>
>>>
>>>
>>> stef
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>>
>>>
>>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

> I released an archive with two images
> 10259 with tests run
> 10259-withClosure + john + lukas + my fixes so far
>
> so that we can go faster to fix the problems
>
> https://gforge.inria.fr/frs/?group_id=1299 and files
>
> Stef
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

> I released an archive with two images
> 10259 with tests run
> 10259-withClosure + john + lukas + my fixes so far
>
> so that we can go faster to fix the problems
>
> https://gforge.inria.fr/frs/?group_id=1299 and files
>
> Stef
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
>  

> Here's a fix for the BlockContext test.
> Basically, the error message had changed format, so the test that the
> correct error message was reported failed.
> I changed the test to check for the (new) error format (which adds
> argument(s) at the end of the sentence), and changed the error message
> to not call printstring, since this resulted in the string containing
> '1' instead of 1.
> For some reason (which I'm not aware of) the printstring of numbers  
> seem
> to include quotes.
>
> On a totally unrelated note, (didn't include it in the cs since it's  
> not
> remotely related)
> Debugger contents:notifying contains a call to Smalltalk>> isMorphic
> which should probably be removed, comes up everytime you try to save a
> method edit in the debugger.
>
> Cheers,
> Henry
>
> Stéphane Ducasse wrote:
>> I released an archive with two images
>> 10259 with tests run
>> 10259-withClosure + john + lukas + my fixes so far
>>
>> so that we can go faster to fix the problems
>>
>> https://gforge.inria.fr/frs/?group_id=1299 and files
>>
>> Stef
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>>
> 'From Pharo0.1 of 16 May 2008 [Latest update: #10259] on 23 March  
> 2009 at 1:47:53 pm'!
>
> !BlockClosure methodsFor: 'error handing' stamp: 'Henrik Sperre  
> Johansen 3/23/2009 13:45'!
> numArgsError: numArgsForInvocation
>
> | printNArgs |
> printNArgs := [:n| n printString, ' argument', (n = 1 ifTrue: ['']  
> ifFalse:['s'])].
> self error:
> 'This block accepts ', (printNArgs value: numArgs),
> ', but was called with ', (printNArgs value:  
> numArgsForInvocation), '.'! !
>
>
> !BlockContextTest methodsFor: 'tests - evaluating' stamp: 'Henrik  
> Sperre Johansen 3/23/2009 13:45'!
> testValueWithArguments
> self
> should: [aBlockContext
> valueWithArguments: #(1 )]
> raise: Error.
> self
> shouldnt: [aBlockContext
> valueWithArguments: #()]
> raise: Error.
> [aBlockContext
> valueWithArguments: #(1 )]
> ifError: [:err :rcvr | self assert: err = 'Error: This block  
> accepts 0 arguments, but was called with 1 argument.'].
> [[:i | 3 + 4]
> valueWithArguments: #(1 2)]
> ifError: [:err :rcvr | self assert: err = 'Error: This block  
> accepts 1 argument, but was called with 2 arguments.']! !
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

> excellent!!!!
> can you post cs to the Bugtracker so that
> we can reload all the fixes in a couple of click?
>
> http://code.google.com/p/pharo/issues/detail?id=685
>
> I'm busy writing something else right now
>
> Stef
> On Mar 23, 2009, at 1:53 PM, Henrik Johansen wrote:
>
>  
>> Here's a fix for the BlockContext test.
>> Basically, the error message had changed format, so the test that the
>> correct error message was reported failed.
>> I changed the test to check for the (new) error format (which adds
>> argument(s) at the end of the sentence), and changed the error message
>> to not call printstring, since this resulted in the string containing
>> '1' instead of 1.
>> For some reason (which I'm not aware of) the printstring of numbers  
>> seem
>> to include quotes.
>>
>> On a totally unrelated note, (didn't include it in the cs since it's  
>> not
>> remotely related)
>> Debugger contents:notifying contains a call to Smalltalk>> isMorphic
>> which should probably be removed, comes up everytime you try to save a
>> method edit in the debugger.
>>
>> Cheers,
>> Henry
>>
>> Stéphane Ducasse wrote:
>>    
>>> I released an archive with two images
>>> 10259 with tests run
>>> 10259-withClosure + john + lukas + my fixes so far
>>>
>>> so that we can go faster to fix the problems
>>>
>>> https://gforge.inria.fr/frs/?group_id=1299 and files
>>>
>>> Stef
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>>
>>>
>>>      
>> 'From Pharo0.1 of 16 May 2008 [Latest update: #10259] on 23 March  
>> 2009 at 1:47:53 pm'!
>>
>> !BlockClosure methodsFor: 'error handing' stamp: 'Henrik Sperre  
>> Johansen 3/23/2009 13:45'!
>> numArgsError: numArgsForInvocation
>>
>> | printNArgs |
>> printNArgs := [:n| n printString, ' argument', (n = 1 ifTrue: ['']  
>> ifFalse:['s'])].
>> self error:
>> 'This block accepts ', (printNArgs value: numArgs),
>> ', but was called with ', (printNArgs value:  
>> numArgsForInvocation), '.'! !
>>
>>
>> !BlockContextTest methodsFor: 'tests - evaluating' stamp: 'Henrik  
>> Sperre Johansen 3/23/2009 13:45'!
>> testValueWithArguments
>> self
>> should: [aBlockContext
>> valueWithArguments: #(1 )]
>> raise: Error.
>> self
>> shouldnt: [aBlockContext
>> valueWithArguments: #()]
>> raise: Error.
>> [aBlockContext
>> valueWithArguments: #(1 )]
>> ifError: [:err :rcvr | self assert: err = 'Error: This block  
>> accepts 0 arguments, but was called with 1 argument.'].
>> [[:i | 3 + 4]
>> valueWithArguments: #(1 2)]
>> ifError: [:err :rcvr | self assert: err = 'Error: This block  
>> accepts 1 argument, but was called with 2 arguments.']! !
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>    
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
>  

> Done and done.
> I'd rather not make a .cs for the
> ClosureCompilerTest >>testInjectIntoDecompilations failure though,
> as I neither feel comfortable messing around with Scanner, nor
> particularily feel like it would be a good idea to change the test to
> assume _ instead of := ...
>
> Cheers,
> Henry
>
> Stéphane Ducasse wrote:
>> excellent!!!!
>> can you post cs to the Bugtracker so that
>> we can reload all the fixes in a couple of click?
>>
>> http://code.google.com/p/pharo/issues/detail?id=685
>>
>> I'm busy writing something else right now
>>
>> Stef
>> On Mar 23, 2009, at 1:53 PM, Henrik Johansen wrote:
>>
>>
>>> Here's a fix for the BlockContext test.
>>> Basically, the error message had changed format, so the test that  
>>> the
>>> correct error message was reported failed.
>>> I changed the test to check for the (new) error format (which adds
>>> argument(s) at the end of the sentence), and changed the error  
>>> message
>>> to not call printstring, since this resulted in the string  
>>> containing
>>> '1' instead of 1.
>>> For some reason (which I'm not aware of) the printstring of numbers
>>> seem
>>> to include quotes.
>>>
>>> On a totally unrelated note, (didn't include it in the cs since it's
>>> not
>>> remotely related)
>>> Debugger contents:notifying contains a call to Smalltalk>> isMorphic
>>> which should probably be removed, comes up everytime you try to  
>>> save a
>>> method edit in the debugger.
>>>
>>> Cheers,
>>> Henry
>>>
>>> Stéphane Ducasse wrote:
>>>
>>>> I released an archive with two images
>>>> 10259 with tests run
>>>> 10259-withClosure + john + lukas + my fixes so far
>>>>
>>>> so that we can go faster to fix the problems
>>>>
>>>> https://gforge.inria.fr/frs/?group_id=1299 and files
>>>>
>>>> Stef
>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [hidden email]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>>
>>>>
>>>>
>>>>
>>> 'From Pharo0.1 of 16 May 2008 [Latest update: #10259] on 23 March
>>> 2009 at 1:47:53 pm'!
>>>
>>> !BlockClosure methodsFor: 'error handing' stamp: 'Henrik Sperre
>>> Johansen 3/23/2009 13:45'!
>>> numArgsError: numArgsForInvocation
>>>
>>> | printNArgs |
>>> printNArgs := [:n| n printString, ' argument', (n = 1 ifTrue: ['']
>>> ifFalse:['s'])].
>>> self error:
>>> 'This block accepts ', (printNArgs value: numArgs),
>>> ', but was called with ', (printNArgs value:
>>> numArgsForInvocation), '.'! !
>>>
>>>
>>> !BlockContextTest methodsFor: 'tests - evaluating' stamp: 'Henrik
>>> Sperre Johansen 3/23/2009 13:45'!
>>> testValueWithArguments
>>> self
>>> should: [aBlockContext
>>> valueWithArguments: #(1 )]
>>> raise: Error.
>>> self
>>> shouldnt: [aBlockContext
>>> valueWithArguments: #()]
>>> raise: Error.
>>> [aBlockContext
>>> valueWithArguments: #(1 )]
>>> ifError: [:err :rcvr | self assert: err = 'Error: This block
>>> accepts 0 arguments, but was called with 1 argument.'].
>>> [[:i | 3 + 4]
>>> valueWithArguments: #(1 2)]
>>> ifError: [:err :rcvr | self assert: err = 'Error: This block
>>> accepts 1 argument, but was called with 2 arguments.']! !
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>