[ANN] MouseOverHandler refactoring
Locked
[ANN] MouseOverHandler refactoring
 
|
Hi,
I completely refactor the MouseOverHandler class. It also fixes the errors reported last week (I have it as http://code.google.com/p/pharo/issues/detail?id=86 but that is not the right error).
Hope you like it. Hernan.
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
2009/6/12 Hernan Wilkinson <[hidden email]>:
> Hope you like it. Where can we find it? How to test it? -- Damien Cassou http://damiencassou.seasidehosting.st "Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
I uploaded to the pharo inbox repository... is that right?
The only way to test it that I found of is just to install it and play with the mouse... if you do not have a debugger, it means it is working :-)
On Fri, Jun 12, 2009 at 2:47 PM, Damien Cassou <[hidden email]> wrote: 2009/6/12 Hernan Wilkinson <[hidden email]>: _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
Hi Hernan,
On Jun 12, 2009, at 21:55 , Hernan Wilkinson wrote: > I uploaded to the pharo inbox repository... is that right? Yes. But additionally it would be good to note which file(s) you uploaded in the issue tracker. Like this we can track changes. If no report exists yet, just create a new one. Thanks, Adrian > The only way to > test it that I found of is just to install it and play with the > mouse... if > you do not have a debugger, it means it is working :-) > > On Fri, Jun 12, 2009 at 2:47 PM, Damien Cassou <[hidden email] > >wrote: > >> 2009/6/12 Hernan Wilkinson <[hidden email]>: >>> Hope you like it. >> >> Where can we find it? >> How to test it? >> >> >> -- >> Damien Cassou >> http://damiencassou.seasidehosting.st >> >> "Lambdas are relegated to relative obscurity until Java makes them >> popular by not having them." James Iry >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
ups! you are write!! sorry about that, I realize I did not put the name of the file :-)
The file name is: Morphic-HernanWilkinson.327.mcz
About the issue tracker, the error that Stef point me to is http://code.google.com/p/pharo/issues/detail?id=86 in his mail http://lists.gforge.inria.fr/pipermail/pharo-project/2009-June/009517.html but the description does not macth with the error I also fix.
Do you think I should open a new defect? On Fri, Jun 12, 2009 at 5:37 PM, Adrian Lienhard <[hidden email]> wrote: Hi Hernan, _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
On Jun 13, 2009, at 01:59 , Hernan Wilkinson wrote: > ups! you are write!! sorry about that, I realize I did not put the > name of > the file :-)The file name is: Morphic-HernanWilkinson.327.mcz > > About the issue tracker, the error that Stef point me to is > http://code.google.com/p/pharo/issues/detail?id=86 in his mail > http://lists.gforge.inria.fr/pipermail/pharo-project/2009-June/009517.html > but > the description does not macth with the error I also fix. > Do you think I should open a new defect? Yes, I think that would be best. Cheers, Adrian > > On Fri, Jun 12, 2009 at 5:37 PM, Adrian Lienhard <[hidden email]> > wrote: > >> Hi Hernan, >> >> On Jun 12, 2009, at 21:55 , Hernan Wilkinson wrote: >> >>> I uploaded to the pharo inbox repository... is that right? >> >> Yes. But additionally it would be good to note which file(s) you >> uploaded in the issue tracker. Like this we can track changes. If no >> report exists yet, just create a new one. >> >> Thanks, >> Adrian >> >>> The only way to >>> test it that I found of is just to install it and play with the >>> mouse... if >>> you do not have a debugger, it means it is working :-) >>> >>> On Fri, Jun 12, 2009 at 2:47 PM, Damien Cassou <[hidden email] >>>> wrote: >>> >>>> 2009/6/12 Hernan Wilkinson <[hidden email]>: >>>>> Hope you like it. >>>> >>>> Where can we find it? >>>> How to test it? >>>> >>>> >>>> -- >>>> Damien Cassou >>>> http://damiencassou.seasidehosting.st >>>> >>>> "Lambdas are relegated to relative obscurity until Java makes them >>>> popular by not having them." James Iry >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
Done, issue 889
On Sat, Jun 13, 2009 at 5:48 AM, Adrian Lienhard <[hidden email]> wrote:
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
Which, of course, doesn't get to the bottom of the
original problem.
That being, why there would be multiple processes
(rather than just UI process) modifying any Morph state...
Regards, Gary
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
You are right, it is very difficult to get to the bottom of the original problem and a lot of morph experience is needed. As I suggested before, that error could happen because:
1) There are multiple processes modifying morph state 2) The same morph is visited more than once to handle the mouse over event (I don't know if this is possible). Hernan. 2009/6/15 Gary Chambers <[hidden email]>
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: [ANN] MouseOverHandler refactoring
|
|
In reply to this post by Gary Chambers-4
Got the problem yesterday, after some investigating:
- senders of Project >> spawnNewProcessIfThisIsUI: suspendedProcess usually do not suspend the suspendedProcess parameter until later in the methods. (most of these are Debugger opening methods) It seems to me that for a short time in these methods, 2 UI processes can actually be active (But telling the same world to update). Thus, if one exits MouseOverHandler >> processMouseOver: while the other is in it (which resets leftMorphs to nil), could cause the described case to happen. Would be nice if someone familiar with Squeak threading model could confirm/disprove my theory :) Cheers, Henry On Jun 15, 2009, at 8:08 58PM, Gary Chambers wrote:
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |