Smalltalk › Pharo › Pharo Smalltalk Users

[ANN] Quality Assistant: live code critics feedback

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

12 messages Options

Uko2

[ANN] Quality Assistant: live code critics feedback

Dear Pharo users,

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.

I want to present you a compact tool called Quality Assistant
https://github.com/Uko/QualityAssistant#quality-assistant-𝑏𝑒𝑡𝑎-

It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up

I plan to introduce more features in the future and your feedback is much appreciated.

Cheers!
Uko

Damien Cassou

Re: [ANN] Quality Assistant: live code critics feedback

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

> As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
> It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Uko2

Re: [ANN] Quality Assistant: live code critics feedback

Hi Damien,

yes, I will work on different ways to display critics. The main advantage that I have now is that critics are a property of a class or method, so in fact inspector or debugger can just ask an entity what are its critics :). I think I will add gt representation soon, so you will be able to see whether class or method has critics in the inspector.

Uko

> On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:
>
> Hi Yuriy,
>
> Yuriy Tymchuk <[hidden email]> writes:
>
>> As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
>> It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.
>
>
> that's great news and I'm looking forward to use it! Nevertheless, I
> tend to code more and more in the debugger and in the inspector. Maybe
> your tool could be shown in the bottom of the Pharo window instead?
>
> Best
>
> --
> Damien Cassou
> http://damiencassou.seasidehosting.st
>
> "Success is the ability to go from one failure to another without
> losing enthusiasm." --Winston Churchill
>

Uko2

Re: [ANN] Quality Assistant: live code critics feedback

In reply to this post by Damien Cassou

Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Tudor Girba-2

Re: [ANN] Quality Assistant: live code critics feedback

Nice, Uko.

We should definitely see next Tuesday how this can complement the future GT efforts :)

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Cheers,

Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:

Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

www.tudorgirba.com

"Every thing has its own flow"

Uko2

Re: [ANN] Quality Assistant: live code critics feedback

On 27 Mar 2015, at 14:40, Tudor Girba <[hidden email]> wrote:

Nice, Uko.

Thank you.

We should definitely see next Tuesday how this can complement the future GT efforts :)

Yes, I’m looking forward.

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Can you give me more information, because searching mail/image and goggling didn’t help :)

Cheers,

Uko

Cheers,
Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:
Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

<Screen Shot 2015-03-27 at 11.38.21.png>

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

--
www.tudorgirba.com

"Every thing has its own flow"

Andrei Chis

Re: [ANN] Quality Assistant: live code critics feedback

Hi Uko,

You found no mail, as there is no email about that. It's a recent addition.

Search for the class GTCritics in Spotter and then dive in the class.

There should be a category Critics that lets's you see and search through all the critics of that class.

Cheers,

Andrei

On Fri, Mar 27, 2015 at 2:53 PM, Yuriy Tymchuk <[hidden email]> wrote:

On 27 Mar 2015, at 14:40, Tudor Girba <[hidden email]> wrote:

Nice, Uko.

Thank you.

We should definitely see next Tuesday how this can complement the future GT efforts :)

Yes, I’m looking forward.

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Can you give me more information, because searching mail/image and goggling didn’t help :)

Cheers,
Uko

Cheers,
Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:
Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

<Screen Shot 2015-03-27 at 11.38.21.png>

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

--
www.tudorgirba.com

"Every thing has its own flow"

Uko2

Re: [ANN] Quality Assistant: live code critics feedback

Oh, I was checking in vanilla Pharo 4.

GTCritics gave me some ideas about IU, during the weekend I’ll release next minor version with critics objects, severity indicators and better GTInspector support.

We will criticize you! :)

Uko

On 27 Mar 2015, at 14:56, Andrei Chis <[hidden email]> wrote:

Hi Uko,

You found no mail, as there is no email about that. It's a recent addition.

Search for the class GTCritics in Spotter and then dive in the class.
There should be a category Critics that lets's you see and search through all the critics of that class.

Cheers,
Andrei

On Fri, Mar 27, 2015 at 2:53 PM, Yuriy Tymchuk <[hidden email]> wrote:

On 27 Mar 2015, at 14:40, Tudor Girba <[hidden email]> wrote:

Nice, Uko.

Thank you.

We should definitely see next Tuesday how this can complement the future GT efforts :)

Yes, I’m looking forward.

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Can you give me more information, because searching mail/image and goggling didn’t help :)

Cheers,
Uko

Cheers,
Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:
Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

<Screen Shot 2015-03-27 at 11.38.21.png>

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

--
www.tudorgirba.com

"Every thing has its own flow"

abergel

Re: [ANN] Quality Assistant: live code critics feedback

This is really cool.

You guys are changing the way we program.

Alexandre

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

On Mar 27, 2015, at 2:04 PM, Yuriy Tymchuk <[hidden email]> wrote:

Oh, I was checking in vanilla Pharo 4.

GTCritics gave me some ideas about IU, during the weekend I’ll release next minor version with critics objects, severity indicators and better GTInspector support.

<Screen Shot 2015-03-27 at 17.42.26.png>

<Screen Shot 2015-03-27 at 17.50.29.png>

We will criticize you! :)
Uko

On 27 Mar 2015, at 14:56, Andrei Chis <[hidden email]> wrote:

Hi Uko,

You found no mail, as there is no email about that. It's a recent addition.

Search for the class GTCritics in Spotter and then dive in the class.
There should be a category Critics that lets's you see and search through all the critics of that class.

Cheers,
Andrei

On Fri, Mar 27, 2015 at 2:53 PM, Yuriy Tymchuk <[hidden email]> wrote:

On 27 Mar 2015, at 14:40, Tudor Girba <[hidden email]> wrote:

Nice, Uko.

Thank you.

We should definitely see next Tuesday how this can complement the future GT efforts :)

Yes, I’m looking forward.

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Can you give me more information, because searching mail/image and goggling didn’t help :)

Cheers,
Uko

Cheers,
Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:
Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

<Screen Shot 2015-03-27 at 11.38.21.png>

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

--
www.tudorgirba.com

"Every thing has its own flow"

Tudor Girba-2

Re: [ANN] Quality Assistant: live code critics feedback

In reply to this post by Uko2

Great. There are some features we are thinking of for the Inspector that will likely fit your interest nicely. Let's look at them next week.

Cheers,

Doru

On Fri, Mar 27, 2015 at 6:04 PM, Yuriy Tymchuk <[hidden email]> wrote:

Oh, I was checking in vanilla Pharo 4.

GTCritics gave me some ideas about IU, during the weekend I’ll release next minor version with critics objects, severity indicators and better GTInspector support.

We will criticize you! :)
Uko

On 27 Mar 2015, at 14:56, Andrei Chis <[hidden email]> wrote:

Hi Uko,

You found no mail, as there is no email about that. It's a recent addition.

Search for the class GTCritics in Spotter and then dive in the class.
There should be a category Critics that lets's you see and search through all the critics of that class.

Cheers,
Andrei

On Fri, Mar 27, 2015 at 2:53 PM, Yuriy Tymchuk <[hidden email]> wrote:

On 27 Mar 2015, at 14:40, Tudor Girba <[hidden email]> wrote:

Nice, Uko.

Thank you.

We should definitely see next Tuesday how this can complement the future GT efforts :)

Yes, I’m looking forward.

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Can you give me more information, because searching mail/image and goggling didn’t help :)

Cheers,
Uko

Cheers,
Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:
Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

<Screen Shot 2015-03-27 at 11.38.21.png>

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

--
www.tudorgirba.com

"Every thing has its own flow"

www.tudorgirba.com

"Every thing has its own flow"

Ben Coman

Re: [ANN] Quality Assistant: live code critics feedback

So you could have a tab called "rewrite" or "rewritten" or "suggestion" that provides the a rewritten code that can be simply <Accepted> as the new version? Or equally, with a click add a manifest entry to ignore this.

Also maybe a tab that lists all the "ignore" manifest entries that apply to this code? To help with reviewing and deleting manifest entries. I am thinking that sometime I might manifest-ignore some critic, but someone else might disagree (if they ever knew).

cheers -ben

On Sat, Mar 28, 2015 at 3:47 AM, Tudor Girba <[hidden email]> wrote:

Great. There are some features we are thinking of for the Inspector that will likely fit your interest nicely. Let's look at them next week.

Cheers,
Doru

On Fri, Mar 27, 2015 at 6:04 PM, Yuriy Tymchuk <[hidden email]> wrote:
Oh, I was checking in vanilla Pharo 4.

GTCritics gave me some ideas about IU, during the weekend I’ll release next minor version with critics objects, severity indicators and better GTInspector support.

We will criticize you! :)
Uko

On 27 Mar 2015, at 14:56, Andrei Chis <[hidden email]> wrote:

Hi Uko,

You found no mail, as there is no email about that. It's a recent addition.

Search for the class GTCritics in Spotter and then dive in the class.
There should be a category Critics that lets's you see and search through all the critics of that class.

Cheers,
Andrei

On Fri, Mar 27, 2015 at 2:53 PM, Yuriy Tymchuk <[hidden email]> wrote:

On 27 Mar 2015, at 14:40, Tudor Girba <[hidden email]> wrote:

Nice, Uko.

Thank you.

We should definitely see next Tuesday how this can complement the future GT efforts :)

Yes, I’m looking forward.

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Can you give me more information, because searching mail/image and goggling didn’t help :)

Cheers,
Uko

Cheers,
Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:
Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

<Screen Shot 2015-03-27 at 11.38.21.png>

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

--
www.tudorgirba.com

"Every thing has its own flow"

--
www.tudorgirba.com

"Every thing has its own flow"

stepharo

Re: [ANN] Quality Assistant: live code critics feedback

Le 28/3/15 14:18, Ben Coman a écrit :

So you could have a tab called "rewrite" or "rewritten" or "suggestion" that provides the a rewritten code that can be simply <Accepted> as the new version?

ohhhhh YEEEEEEEEESSSSSSSSSS
I want more critics with one button: do you want to fix this critics automatically.

Or equally, with a click add a manifest entry to ignore this.

Also maybe a tab that lists all the "ignore" manifest entries that apply to this code? To help with reviewing and deleting manifest entries. I am thinking that sometime I might manifest-ignore some critic, but someone else might disagree (if they ever knew).

cheers -ben

On Sat, Mar 28, 2015 at 3:47 AM, Tudor Girba <[hidden email]> wrote:

Great. There are some features we are thinking of for the Inspector that will likely fit your interest nicely. Let's look at them next week.

Cheers,

Doru

On Fri, Mar 27, 2015 at 6:04 PM, Yuriy Tymchuk <[hidden email]> wrote:

Oh, I was checking in vanilla Pharo 4.

GTCritics gave me some ideas about IU, during the weekend I’ll release next minor version with critics objects, severity indicators and better GTInspector support.

We will criticize you! :)

Uko

On 27 Mar 2015, at 14:56, Andrei Chis <[hidden email]> wrote:

Hi Uko,

You found no mail, as there is no email about that. It's a recent addition.

Search for the class GTCritics in Spotter and then dive in the class.

There should be a category Critics that lets's you see and search through all the critics of that class.

Cheers,

Andrei

On Fri, Mar 27, 2015 at 2:53 PM, Yuriy Tymchuk <[hidden email]> wrote:

On 27 Mar 2015, at 14:40, Tudor Girba <[hidden email]> wrote:

Nice, Uko.

Thank you.

We should definitely see next Tuesday how this can complement the future GT efforts :)

Yes, I’m looking forward.

In the meantime, you could look at the code critics support from Spotter. It was recently introduced by Stefan Reichhart,

Can you give me more information, because searching mail/image and goggling didn’t help :)

Cheers,

Uko

Cheers,

Doru

On Fri, Mar 27, 2015 at 12:05 PM, Yuriy Tymchuk <[hidden email]> wrote:

Oh, actually it turns out that I didn’t remove my old experiments with GT, so you can see critics tab in inspector. Navigation in not useful yet though.

<Screen Shot 2015-03-27 at 11.38.21.png>

Uko

On 27 Mar 2015, at 09:47, Damien Cassou <[hidden email]> wrote:

Hi Yuriy,

Yuriy Tymchuk <[hidden email]> writes:

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

that's great news and I'm looking forward to use it! Nevertheless, I
tend to code more and more in the debugger and in the inspector. Maybe
your tool could be shown in the bottom of the Pharo window instead?

Best

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

--

www.tudorgirba.com

"Every thing has its own flow"

--

www.tudorgirba.com

"Every thing has its own flow"