[ANN] Quality Assistant: live code critics feedback

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[ANN] Quality Assistant: live code critics feedback

Uko2
Dear Moose developers,

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.

I want to present you a compact tool called Quality Assistant
https://github.com/Uko/QualityAssistant#quality-assistant-π‘π‘’π‘‘π‘Ž-

It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up

I plan to introduce more features in the future and your feedback is much appreciated.

Cheers!
Uko
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Quality Assistant: live code critics feedback

Stephan Eggermont-3
Hi Uko,

Looking nice! Why is the package names regex a global for all future
images?

Stephan

On 27-03-15 09:14, Yuriy Tymchuk wrote:

> Dear Moose developers,
>
> As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
>
> I want to present you a compact tool called Quality Assistant
> https://github.com/Uko/QualityAssistant#quality-assistant-π‘π‘’π‘‘π‘Ž-
>
> It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.
>
> Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up
>
> I plan to introduce more features in the future and your feedback is much appreciated.
>
> Cheers!
> Uko
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Quality Assistant: live code critics feedback

Uko2
Hi Stephan,

this is still work in progress solution, but the idea behind it is that you define the packages that you are developing, and they are checked in each image that you open.

Example use case: when I develop Quality Assistant and use a fresh image every day I don’t want to re-setup that I want to check it. If you have other workflows in mind please let me know.

Uko


> On 27 Mar 2015, at 09:47, stephan <[hidden email]> wrote:
>
> Hi Uko,
>
> Looking nice! Why is the package names regex a global for all future images?
>
> Stephan
>
> On 27-03-15 09:14, Yuriy Tymchuk wrote:
>> Dear Moose developers,
>>
>> As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.
>>
>> I want to present you a compact tool called Quality Assistant
>> https://github.com/Uko/QualityAssistant#quality-assistant-π‘π‘’π‘‘π‘Ž-
>>
>> It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.
>>
>> Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up
>>
>> I plan to introduce more features in the future and your feedback is much appreciated.
>>
>> Cheers!
>> Uko
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Quality Assistant: live code critics feedback

abergel
In reply to this post by Uko2
Hi Yuriy!

Thanks for your tool! I will try to use it.

Just wondering, does it send data to a server? No pb with that, but I am wondering. If it does, it would be great that I can access what I actually send. Because maybe I have critics that I recurrently break.

There is one I do not understand. Consider;

What can I do to eliminate the guarding clauses. Which clauses by the way? Pretty obscure to me.

Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Mar 27, 2015, at 5:14 AM, Yuriy Tymchuk <[hidden email]> wrote:

Dear Moose developers,

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.

I want to present you a compact tool called Quality Assistant
https://github.com/Uko/QualityAssistant#quality-assistant-π‘π‘’π‘‘π‘Ž-

It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up

I plan to introduce more features in the future and your feedback is much appreciated.

Cheers!
Uko
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Quality Assistant: live code critics feedback

Uko2

On 27 Mar 2015, at 14:37, Alexandre Bergel <[hidden email]> wrote:

Hi Yuriy!

Hi Alex!


Thanks for your tool! I will try to use it.

Thanks.


Just wondering, does it send data to a server? No pb with that, but I am wondering. If it does, it would be great that I can access what I actually send. Because maybe I have critics that I recurrently break.

Not at the moment. I will let everyone know if I’m collecting data and where it is available.


There is one I do not understand. Consider;
<Screen Shot 2015-03-27 at 10.37.10 AM.png>

What can I do to eliminate the guarding clauses. Which clauses by the way? Pretty obscure to me.

Ok, it looks that something is wrong with the rationale a bit. For this particular rule the point is that instead if having "ifTrue: [ … ]" at the end of a method, you can use "ifFalse: [ ^ self ]. …”.

Cheers!
Uko


Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Mar 27, 2015, at 5:14 AM, Yuriy Tymchuk <[hidden email]> wrote:

Dear Moose developers,

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.

I want to present you a compact tool called Quality Assistant
https://github.com/Uko/QualityAssistant#quality-assistant-π‘π‘’π‘‘π‘Ž-

It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up

I plan to introduce more features in the future and your feedback is much appreciated.

Cheers!
Uko
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Quality Assistant: live code critics feedback

abergel
Ah yes! 
Now I get it!

Thanks,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Mar 27, 2015, at 10:46 AM, Yuriy Tymchuk <[hidden email]> wrote:


On 27 Mar 2015, at 14:37, Alexandre Bergel <[hidden email]> wrote:

Hi Yuriy!

Hi Alex!


Thanks for your tool! I will try to use it.

Thanks.


Just wondering, does it send data to a server? No pb with that, but I am wondering. If it does, it would be great that I can access what I actually send. Because maybe I have critics that I recurrently break.

Not at the moment. I will let everyone know if I’m collecting data and where it is available.


There is one I do not understand. Consider;
<Screen Shot 2015-03-27 at 10.37.10 AM.png>

What can I do to eliminate the guarding clauses. Which clauses by the way? Pretty obscure to me.

Ok, it looks that something is wrong with the rationale a bit. For this particular rule the point is that instead if having "ifTrue: [ … ]" at the end of a method, you can use "ifFalse: [ ^ self ]. …”.

Cheers!
Uko


Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Mar 27, 2015, at 5:14 AM, Yuriy Tymchuk <[hidden email]> wrote:

Dear Moose developers,

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.

I want to present you a compact tool called Quality Assistant
https://github.com/Uko/QualityAssistant#quality-assistant-π‘π‘’π‘‘π‘Ž-

It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up

I plan to introduce more features in the future and your feedback is much appreciated.

Cheers!
Uko
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Quality Assistant: live code critics feedback

Uko2
Aha,

so the thing is that RBGuardingClauseRule has proper rationale, but your code is checked by RBGuardClauseRule which allows rewriting but has quite meaningless rationale…

Uko

On 27 Mar 2015, at 14:50, Alexandre Bergel <[hidden email]> wrote:

Ah yes! 
Now I get it!

Thanks,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Mar 27, 2015, at 10:46 AM, Yuriy Tymchuk <[hidden email]> wrote:


On 27 Mar 2015, at 14:37, Alexandre Bergel <[hidden email]> wrote:

Hi Yuriy!

Hi Alex!


Thanks for your tool! I will try to use it.

Thanks.


Just wondering, does it send data to a server? No pb with that, but I am wondering. If it does, it would be great that I can access what I actually send. Because maybe I have critics that I recurrently break.

Not at the moment. I will let everyone know if I’m collecting data and where it is available.


There is one I do not understand. Consider;
<Screen Shot 2015-03-27 at 10.37.10 AM.png>

What can I do to eliminate the guarding clauses. Which clauses by the way? Pretty obscure to me.

Ok, it looks that something is wrong with the rationale a bit. For this particular rule the point is that instead if having "ifTrue: [ … ]" at the end of a method, you can use "ifFalse: [ ^ self ]. …”.

Cheers!
Uko


Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Mar 27, 2015, at 5:14 AM, Yuriy Tymchuk <[hidden email]> wrote:

Dear Moose developers,

As you already know I am working on providing better code quality support in Pharo. You can use Code Critics in Pharo to detect bad practices and potential bugs. But launching the Critics Browser and running it on your code every now and then requires additional effort which demotivates many people in doing it.

I want to present you a compact tool called Quality Assistant
https://github.com/Uko/QualityAssistant#quality-assistant-π‘π‘’π‘‘π‘Ž-

It runs SmallLint rules on the code that you save and provides you with a critic feedback directly in the place where you code: the Nautilus Browser.

Quality Assistant is available for Pharo 4 from the Configuration browser. Please read about how to set it up here: https://github.com/Uko/QualityAssistant#set-up

I plan to introduce more features in the future and your feedback is much appreciated.

Cheers!
Uko
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev