About deprecated methods

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

About deprecated methods

Stéphane Ducasse
Hi guys

I wanted to remove the deprecated methods of 1.0 in 1.1
Here is a first cut of deprecated methods that are not called by other  
in the system.
May be we should not integrate it now but create a slice that people  
could load if they want.



Stef
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

RemovingDeprecatedMethods.2.cs (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: About deprecated methods

Adrian Lienhard
Nice!

> I wanted to remove the deprecated methods of 1.0 in 1.1
> Here is a first cut of deprecated methods that are not called by  
> other in the system.

This means that there are deprecated methods called by existing  
methods in the image? That should not be the case...

> May be we should not integrate it now but create a slice that people  
> could load if they want.
> <RemovingDeprecatedMethods.2.cs>

I think this could be integrated already now. What would also be good  
is a wiki page that documents in which version a method was  
deprecated, and when it was removed. This would help people migrate  
their code.

Adrian

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: About deprecated methods

Miguel Cobá
In reply to this post by Stéphane Ducasse
El lun, 09-11-2009 a las 21:54 +0100, Stéphane Ducasse escribió:
> Hi guys
>
> I wanted to remove the deprecated methods of 1.0 in 1.1
> Here is a first cut of deprecated methods that are not called by other  
> in the system.
> May be we should not integrate it now but create a slice that people  
> could load if they want.

If you integrate it now, the next time that a package is loaded in pharo
that uses some of the deprecated method will fix. And as this is alpha,
they have plenty of time to fix their packages.
This and the assignment operator should be integrated as soon as
possible in order to give the packager time to fix their code so that
when 1.1 gets out, nobody (or at least few) has ugly surprises.

So

+1 to integrate them.

--
Miguel Cobá
http://miguel.leugim.com.mx


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: About deprecated methods

Stéphane Ducasse
In reply to this post by Adrian Lienhard
here is a new version removing one test.





On Nov 9, 2009, at 10:01 PM, Adrian Lienhard wrote:

> Nice!
>
>> I wanted to remove the deprecated methods of 1.0 in 1.1
>> Here is a first cut of deprecated methods that are not called by
>> other in the system.
>
> This means that there are deprecated methods called by existing
> methods in the image? That should not be the case...

Yes I fixed HttpUrl (in another issue).
Now I'm confused by the two methods left:
        - format: textOrStream in: aClass notifying: aRequestor decorated:  
aBoolean
        - format: textOrStream in: aClass notifying: aRequestor  
contentsSymbol: aSymbol


>
>> May be we should not integrate it now but create a slice that people
>> could load if they want.
>> <RemovingDeprecatedMethods.2.cs>
>
> I think this could be integrated already now. What would also be good
> is a wiki page that documents in which version a method was
> deprecated, and when it was removed. This would help people migrate
> their code.

So keep the new cs.

Stef
>
> Adrian
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

RemovingDeprecatedMethods.3.cs (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: About deprecated methods

Stéphane Ducasse
In reply to this post by Miguel Cobá
> the assignment operator should be integrated as soon as
> possible in order to give the packager time to fix their code so that


        as soon as lukas pushes it into the inbox we integrate it.

Stef

On Nov 9, 2009, at 10:06 PM, Miguel Enrique Cobá Martinez wrote:

> El lun, 09-11-2009 a las 21:54 +0100, Stéphane Ducasse escribió:
>> Hi guys
>>
>> I wanted to remove the deprecated methods of 1.0 in 1.1
>> Here is a first cut of deprecated methods that are not called by  
>> other
>> in the system.
>> May be we should not integrate it now but create a slice that people
>> could load if they want.
>
> If you integrate it now, the next time that a package is loaded in  
> pharo
> that uses some of the deprecated method will fix. And as this is  
> alpha,
> they have plenty of time to fix their packages.
> This and the assignment operator should be integrated as soon as
> possible in order to give the packager time to fix their code so that
> when 1.1 gets out, nobody (or at least few) has ugly surprises.
>
> So
>
> +1 to integrate them.
>
> --
> Miguel Cobá
> http://miguel.leugim.com.mx
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: About deprecated methods

Lukas Renggli
>> the assignment operator should be integrated as soon as
>> possible in order to give the packager time to fix their code so that
>
>
>        as soon as lukas pushes it into the inbox we integrate it.

The thing is that there is a setting in the preferences that confused
me. It currently has no effect. We could fix the setting to let users
chose between underscore-assignment mode or not. This would allow
people to change the preference to load old code and to fix it using
the refactoring browser. However fixing the preference looks quite
complicated as there are several changes required in Parser, Scanner
and the character table.

The alternative is to remove the setting and to allow
underscore-assignments. When loading old code this will cause a syntax
error.

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: About deprecated methods

Alain Plantec-4
In reply to this post by Stéphane Ducasse
Stéphane Ducasse a écrit :
> Hi guys
>
> I wanted to remove the deprecated methods of 1.0 in 1.1
> Here is a first cut of deprecated methods that are not called by other
> in the system.
> May be we should not integrate it now but create a slice that people
> could load if they want.
I think that we should decide a rule for that
"Deprecated methods of version vn are removed from the image of vn + 1"
or vn + 2
and that this rule should be clearly stated somewhere in the pharo web page.

I would vote for vn + 1
and the SLICE with them should be stored in the wiki.

is it possible to know the version of the image in which a method has
been deprecated ?

Alain
>
>
> Stef
> ------------------------------------------------------------------------
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: About deprecated methods

Stéphane Ducasse
normally we write it now in the date

Stef
On Nov 10, 2009, at 7:07 AM, Alain Plantec wrote:

> Stéphane Ducasse a écrit :
>> Hi guys
>>
>> I wanted to remove the deprecated methods of 1.0 in 1.1
>> Here is a first cut of deprecated methods that are not called by  
>> other
>> in the system.
>> May be we should not integrate it now but create a slice that people
>> could load if they want.
> I think that we should decide a rule for that
> "Deprecated methods of version vn are removed from the image of vn +  
> 1"
> or vn + 2
> and that this rule should be clearly stated somewhere in the pharo  
> web page.
>
> I would vote for vn + 1
> and the SLICE with them should be stored in the wiki.
>
> is it possible to know the version of the image in which a method has
> been deprecated ?
>
> Alain
>>
>>
>> Stef
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project