About the changes files fixes

Hi hernan

I read your code and normally the notification alone should be enough.
The changelog should be listening to the notification and log what  
should be logged.


So in the following the first line should only be necessary
        self notifyOfChangedCategoryFrom: oldCat to: newCat.
       
        changeString := subject name, ' organization renameCategory: ''',  
oldCatString ,''' toBe: ''', newCatString ,''''.
        SmalltalkImage current logChange: changeString

I imagine that may be there is problem because the ChangeLog does not  
listen to the right event or
it is not listening well.
Because the systemNotification worked (may be the changes you want  
were not taken into account) from
when it was introduced. So could you check because I'm 100% sure that  
Changeset logger was treated by roel
code just a any other client and he payed attention that if there is  
an exception we do not lose the code.
Roel was picky on his code.

Stef


                 

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Hi Stef,
 I took a look an the notification/listener objects before making the changes. At that time I decided not to change the listener because I could not figure out the impact of the change... there are a lot of ifs depending of the event type and so on, and it is difficult so see where those events are generated. But not a problem, I'll take a deeper look and let you know.
 What about the class definition changes? do you want also to use the notification mechanism?




_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

On Jul 2, 2009, at 11:31 PM, Hernan Wilkinson wrote:

> Hi Stef,
>  I took a look an the notification/listener objects before making  
> the changes. At that time I decided not to change the listener  
> because I could not figure out the impact of the change... there are  
> a lot of ifs depending of the event type and so on, and it is  
> difficult so see where those events are generated. But not a  
> problem, I'll take a deeper look and let you know.
>  What about the class definition changes? do you want also to use  
> the notification mechanism?

yes because like that all the tools can rely on it. The change  
notification is really an important infrastructural backbone
for future tools. So we should improve it.
Thanks for your time in this harsh time for pharoers on squeak-dev :)

Normally there should be some tests for the notification mechanisms.

Stef


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project