Accept method changes in debugger

Hi,

Here is a patch that add #restart to the debugger
(restart the simulation of the method) and add
method changes in GtkDebugger

Cheers,
Gwen


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On Mon, Oct 21, 2013 at 11:29:06AM +0200, Gwenaël Casaccio wrote:
> Hi,
>
> Here is a patch that add #restart to the debugger
> (restart the simulation of the method) and add
> method changes in GtkDebugger

Hi,

I noticed that this has not been merged. I added it right now but
there are some issues in the VisualGST part:

First issue:

1.) Open a workspace and type "3 halt"
2.) Go to the first Object>>#halt frame
and type "3+3" (omit the ".")
3.) Save the frame.

Issues:
* Drop/Accept will appear in the GtkBrowser for an unrelated method
* After fixing the syntax issue the sourcecode in debugger is not
  updated
* The context widget does not update
* F7 steps out of Object>>#halt and does not respawn.

Features:
* There should be a button to re-start a given context frame.


Could you fixit this week?

        holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On Mon, Oct 21, 2013 at 11:29:06AM +0200, Gwenaël Casaccio wrote:

> +        method := context receiver class >> context method selector.

and I think "context receiver class >> context method selector" will
not work for receiver being "Integer" and method being halt. I think
you need to use >>#lookupSelector: here.

holger



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On Sun, Jan 26, 2014 at 09:15:14PM +0100, Holger Hans Peter Freyther wrote:
> On Mon, Oct 21, 2013 at 11:29:06AM +0200, Gwenaël Casaccio wrote:
>
> > +        method := context receiver class >> context method selector.
>
> and I think "context receiver class >> context method selector" will
> not work for receiver being "Integer" and method being halt. I think
> you need to use >>#lookupSelector: here.

appears to do the trick.

diff --git a/packages/debug/DebugTools.st b/packages/debug/DebugTools.st
index 2125cc6..4d06c69 100644
--- a/packages/debug/DebugTools.st
+++ b/packages/debug/DebugTools.st
@@ -150,7 +150,7 @@ pointer bytecodes to line numbers.'>
         context isBlock ifTrue: [ context outerContext isNil ifTrue: [ ^ self ].
                                   context := context outerContext ].
 
-        method := context receiver class >> context method selector.
+        method := context receiver class lookupSelector: context method selector.
 
         newContext := MethodContext new: method stackDepth.
 




_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk