Add my custom menu item to the Tools menu

Cool. So let me know if what I sent works as expected and if so, I can integrate it for next release.

BTW, I may prefer CTRL+SHIFT+F rather than "E" as we already have "CTRL+F" for "Find". 

Opinions?

On Thu, May 21, 2020 at 6:22 PM Simon Franz <[hidden email]> wrote:

+1 for a default implementation for this action with CTRL+Shift+E ;-)

Am Donnerstag, 21. Mai 2020 16:27:13 UTC+2 schrieb Mariano Martinez Peck:

Hernán, 

I think what you said makes sense and it's quite easy to implement. I just did a quick prototype which we could eventually include in the next release. Please, give it a try:

Add these 2 methods:

EmSystemConfiguration >> stsMethodsIncluding: aString

"Open a browser on all the methods including aString specified by the user."

(aString isNil or: [aString isEmpty])

ifTrue: [self stsMethodsIncludingString]

ifFalse: [

(System stsConfirm: 'This is a very lengthy operation. Continue?' title: 'Find String')

ifFalse: [^self].

self stsAllMethodsIncludingString: aString]

EtWindow >> stsMethodsIncludingString

"Open a browser on all the methods including aString specified by the user."

| text widget |

self convertSelectionText: (widget := self targetTextWidget).

text := widget getSelection.

System stsMethodsIncluding: text

And then change EtWindow >> stsEditMenu:   and add the following at the end of the method:

add: #stsMethodsIncludingString

label: 'Browse Methods Including String'

enable: [true]

for: nil

accelerator: (CwAccelerator mask: ControlMask | ShiftMask keysym: XKe)

acceleratorText: 'Ctrl+Shift+E';

The behavior should be: If you have text selected, then it will search on that. If you have nothing selected, then it will prompt. 

Let me know if it works. 

Cheers, 

On Wed, May 20, 2020 at 11:44 PM Hernán Morales Durand <[hidden email]> wrote:

Hi Richard,

Cool, I was just looking at the wrong place.

Thank you!

Hernán

El mié., 20 may. 2020 a las 20:37, Richard Sargent (<[hidden email]>) escribió:

On Wednesday, May 20, 2020 at 3:52:43 PM UTC-7, Mariano Martinez Peck wrote:

Richard, I don't see any attachment, 

Doh!

Added here.

On Wed, May 20, 2020 at 6:48 PM Richard Sargent <[hidden email]> wrote:

On Wednesday, May 20, 2020 at 1:34:56 PM UTC-7, Hernán Morales Durand wrote:

Hi everyone,

I'm using VA Smalltalk 9.1.

It is possible in this version to add my own menu item to the Tools menu in the System Transcript window?

Normally I would search the strings in the image to see how it's done but I didn't found any shortcut.

See the attached screen print. It is from the Transcript window, but I believe the same menu item is available on most development tools windows.

Likewise, the accelerator sequences are associated with the menus of each window. As far as I know, there is no global accelerator sequences.

e.g. Ctrl+S typically triggers the Save menu item from the File menu. Ctrl+C triggers the Copy menu item from the Edit menu. In the absence of these menus, the corresponding key sequence has no effect (unless some other menu on that window defines a binding).

Any example would be appreciated.

Cheers,

Hernán

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/e72eac78-5463-45dd-bddb-f20275ac4744%40googlegroups.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/01d48ae9-f27b-4729-8a6a-f493da31c8f1%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAKHmnHvDa8-xk_YBRfu5dfM_wfw385fszHS7Y99rLJWTBJwWGw%40mail.gmail.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/2ef482fa-38c4-43a2-9125-2d062d3c4ff7%40googlegroups.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to a topic in the Google Groups "VA Smalltalk" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/va-smalltalk/Q4gjsFTx1E4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAOUkibF6Pc0WJgi2WK3AgBavg-pCqyUTayGfJjnXXHgxNSERxw%40mail.gmail.com.

Hernán, 

I think what you said makes sense and it's quite easy to implement. I just did a quick prototype which we could eventually include in the next release. Please, give it a try:

Add these 2 methods:

EmSystemConfiguration >> stsMethodsIncluding: aString

"Open a browser on all the methods including aString specified by the user."

(aString isNil or: [aString isEmpty])

ifTrue: [self stsMethodsIncludingString]

ifFalse: [

(System stsConfirm: 'This is a very lengthy operation. Continue?' title: 'Find String')

ifFalse: [^self].

self stsAllMethodsIncludingString: aString]

EtWindow >> stsMethodsIncludingString

"Open a browser on all the methods including aString specified by the user."

| text widget |

self convertSelectionText: (widget := self targetTextWidget).

text := widget getSelection.

System stsMethodsIncluding: text

And then change EtWindow >> stsEditMenu:   and add the following at the end of the method:

add: #stsMethodsIncludingString

label: 'Browse Methods Including String'

enable: [true]

for: nil

accelerator: (CwAccelerator mask: ControlMask | ShiftMask keysym: XKe)

acceleratorText: 'Ctrl+Shift+E';

The behavior should be: If you have text selected, then it will search on that. If you have nothing selected, then it will prompt. 

Let me know if it works. 

Cheers, 

On Wed, May 20, 2020 at 11:44 PM Hernán Morales Durand <[hidden email]> wrote:

Hi Richard,

Cool, I was just looking at the wrong place.

Thank you!

Hernán

El mié., 20 may. 2020 a las 20:37, Richard Sargent (<[hidden email]>) escribió:

On Wednesday, May 20, 2020 at 3:52:43 PM UTC-7, Mariano Martinez Peck wrote:

Richard, I don't see any attachment, 

Doh!

Added here.

On Wed, May 20, 2020 at 6:48 PM Richard Sargent <[hidden email]> wrote:

On Wednesday, May 20, 2020 at 1:34:56 PM UTC-7, Hernán Morales Durand wrote:

Hi everyone,

I'm using VA Smalltalk 9.1.

It is possible in this version to add my own menu item to the Tools menu in the System Transcript window?

Normally I would search the strings in the image to see how it's done but I didn't found any shortcut.

See the attached screen print. It is from the Transcript window, but I believe the same menu item is available on most development tools windows.

Likewise, the accelerator sequences are associated with the menus of each window. As far as I know, there is no global accelerator sequences.

e.g. Ctrl+S typically triggers the Save menu item from the File menu. Ctrl+C triggers the Copy menu item from the Edit menu. In the absence of these menus, the corresponding key sequence has no effect (unless some other menu on that window defines a binding).

Any example would be appreciated.

Cheers,

Hernán

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/e72eac78-5463-45dd-bddb-f20275ac4744%40googlegroups.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/01d48ae9-f27b-4729-8a6a-f493da31c8f1%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAKHmnHvDa8-xk_YBRfu5dfM_wfw385fszHS7Y99rLJWTBJwWGw%40mail.gmail.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAOUkibEOwW0gbdnsz7noLVfW4%3DQiCu4P%3D9ewm4hNCyBAKxOppg%40mail.gmail.com.

Cool. So let me know if what I sent works as expected and if so, I can integrate it for next release.

BTW, I may prefer CTRL+SHIFT+F rather than "E" as we already have "CTRL+F" for "Find". 

Opinions?

On Thu, May 21, 2020 at 6:22 PM Simon Franz <[hidden email]> wrote:

+1 for a default implementation for this action with CTRL+Shift+E ;-)

Am Donnerstag, 21. Mai 2020 16:27:13 UTC+2 schrieb Mariano Martinez Peck:

Hernán, 

I think what you said makes sense and it's quite easy to implement. I just did a quick prototype which we could eventually include in the next release. Please, give it a try:

Add these 2 methods:

EmSystemConfiguration >> stsMethodsIncluding: aString

"Open a browser on all the methods including aString specified by the user."

(aString isNil or: [aString isEmpty])

ifTrue: [self stsMethodsIncludingString]

ifFalse: [

(System stsConfirm: 'This is a very lengthy operation. Continue?' title: 'Find String')

ifFalse: [^self].

self stsAllMethodsIncludingString: aString]

EtWindow >> stsMethodsIncludingString

"Open a browser on all the methods including aString specified by the user."

| text widget |

self convertSelectionText: (widget := self targetTextWidget).

text := widget getSelection.

System stsMethodsIncluding: text

And then change EtWindow >> stsEditMenu:   and add the following at the end of the method:

add: #stsMethodsIncludingString

label: 'Browse Methods Including String'

enable: [true]

for: nil

accelerator: (CwAccelerator mask: ControlMask | ShiftMask keysym: XKe)

acceleratorText: 'Ctrl+Shift+E';

The behavior should be: If you have text selected, then it will search on that. If you have nothing selected, then it will prompt. 

Let me know if it works. 

Cheers, 

On Wed, May 20, 2020 at 11:44 PM Hernán Morales Durand <[hidden email]> wrote:

Hi Richard,

Cool, I was just looking at the wrong place.

Thank you!

Hernán

El mié., 20 may. 2020 a las 20:37, Richard Sargent (<[hidden email]>) escribió:

On Wednesday, May 20, 2020 at 3:52:43 PM UTC-7, Mariano Martinez Peck wrote:

Richard, I don't see any attachment, 

Doh!

Added here.

On Wed, May 20, 2020 at 6:48 PM Richard Sargent <[hidden email]> wrote:

On Wednesday, May 20, 2020 at 1:34:56 PM UTC-7, Hernán Morales Durand wrote:

Hi everyone,

I'm using VA Smalltalk 9.1.

It is possible in this version to add my own menu item to the Tools menu in the System Transcript window?

Normally I would search the strings in the image to see how it's done but I didn't found any shortcut.

See the attached screen print. It is from the Transcript window, but I believe the same menu item is available on most development tools windows.

Likewise, the accelerator sequences are associated with the menus of each window. As far as I know, there is no global accelerator sequences.

e.g. Ctrl+S typically triggers the Save menu item from the File menu. Ctrl+C triggers the Copy menu item from the Edit menu. In the absence of these menus, the corresponding key sequence has no effect (unless some other menu on that window defines a binding).

Any example would be appreciated.

Cheers,

Hernán

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/e72eac78-5463-45dd-bddb-f20275ac4744%40googlegroups.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/01d48ae9-f27b-4729-8a6a-f493da31c8f1%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAKHmnHvDa8-xk_YBRfu5dfM_wfw385fszHS7Y99rLJWTBJwWGw%40mail.gmail.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/2ef482fa-38c4-43a2-9125-2d062d3c4ff7%40googlegroups.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAOUkibF6Pc0WJgi2WK3AgBavg-pCqyUTayGfJjnXXHgxNSERxw%40mail.gmail.com.

I'd like to suggest to distinguish between searching any kind of literals inside a method, and search only in the real Strings contained in a method, which is what I expected as default behavior. For example if you highlight Breakpoints in a Workspace and Ctrl+Shift+E, now it returns all the methods with the subword Breakpoint, even if it is part of a Symbol, i.e. in this method:

>>stsClearBreakpoints
   super stsClearBreakpoints.
   sourceCodeNotebook
   callCallbacks: XmNresizeCallback
   callData: nil.

the results includes literals containing "Breakpoints" as substrings: stsClear"Breakpoints", they don't make a distinction if it is a real String or a message send.

Anyway, I tested with a dummy method:

>>sampleMethod

^ 'myBreakpoint'

 

And it returns 1 result as expected, so ultimately it works :)

BTW, you may want to take a look at implementers of #addToSystemMenu.  

One simple example is the configuration map "Mastering ENVY/ Developer Script Manager". Once loaded, check the class side methods of MedScriptManagerApp.

Does it help?

Best, 

On Wed, May 20, 2020 at 5:54 PM Mariano Martinez Peck <[hidden email]> wrote:

Hernan, sorry for the question but by "shortcut" you mean a way to get quicking to the place in code that defines the menu entry, or to add keyboard shortcuts to that menu entry? I guess the former, but just in case....

On Wed, May 20, 2020 at 5:34 PM Hernán Morales Durand <[hidden email]> wrote:

Hi everyone,

I'm using VA Smalltalk 9.1.

It is possible in this version to add my own menu item to the Tools menu in the System Transcript window?

Normally I would search the strings in the image to see how it's done but I didn't found any shortcut.

Any example would be appreciated.

Cheers,

Hernán

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAKHmnHsYkQ2vo9tWhATEhNiUKFuXmh072ELbcyt33aboiFW6dw%40mail.gmail.com.

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--

Mariano Martinez Peck
Software Engineer, Instantiations Inc.

Email: [hidden email]

Twitter: https://twitter.com/MartinezPeck

LinkedIn: www.linkedin.com/in/mariano-martinez-peck

Blog: https://marianopeck.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/CAOUkibFBAMYAuTDWFPu1tFcpDNmzVPZHx%2B21zND63sUpMSc9QA%40mail.gmail.com.