After loading a package...all changes with "revision changed"
Locked
After loading a package...all changes with "revision changed"
 
|
Hi. I am having a probem with Glorp and I really have no idea what can be. The problem is that I load the package Glorp and just after loading, I do a "changes" in the MC Browser and I see a lot of classes with a lot of changes and all of them like "revison changed". This is annoying since it doesn't let me easily see what I have really changed.
To reproduce: - Load the package "Glorp" from http://www.squeaksource.com/SqueakDBX - Open a MC Browser, select Glorp package and press the "Changes" button agains the ss repo. And you will see :) Any help is really appreaciated. Thanks Mariano _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
On Sep 25, 2010, at 8:25 PM, Mariano Martinez Peck wrote: > Hi. I am having a probem with Glorp and I really have no idea what can be. The problem is that I load the package Glorp and just after loading, I do a "changes" in the MC Browser and I see a lot of classes with a lot of changes and all of them like "revison changed". This is annoying since it doesn't let me easily see what I have really changed. > > To reproduce: > > - Load the package "Glorp" from http://www.squeaksource.com/SqueakDBX > - Open a MC Browser, select Glorp package and press the "Changes" button agains the ss repo. And you will see :) May be the image used to save the package got a problem and changed the timestamp of the methods. So when you merge you get changed methods. > > Any help is really appreaciated. > > Thanks > > Mariano > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
On Sat, Sep 25, 2010 at 9:02 PM, Stéphane Ducasse <[hidden email]> wrote:
I've just tried commiting and load them in a clean image...same problem. And if it were what you say...is there a solution? thanks mariano
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
In reply to this post by Stéphane Ducasse
On Sep 25, 2010, at 9:13 PM, Mariano Martinez Peck wrote: > > > On Sat, Sep 25, 2010 at 9:02 PM, Stéphane Ducasse <[hidden email]> wrote: > > On Sep 25, 2010, at 8:25 PM, Mariano Martinez Peck wrote: > > > Hi. I am having a probem with Glorp and I really have no idea what can be. The problem is that I load the package Glorp and just after loading, I do a "changes" in the MC Browser and I see a lot of classes with a lot of changes and all of them like "revison changed". This is annoying since it doesn't let me easily see what I have really changed. > > > > To reproduce: > > > > - Load the package "Glorp" from http://www.squeaksource.com/SqueakDBX > > - Open a MC Browser, select Glorp package and press the "Changes" button agains the ss repo. And you will see :) > > May be the image used to save the package got a problem and changed the timestamp of the methods. > So when you merge you get changed methods. > > I've just tried commiting and load them in a clean image...same problem. > > And if it were what you say...is there a solution? I do not know. I would like to know whether the change propagates. can you do the following: - load the package - modify one method - save it - reload it in another image and you get them all dirty? In which image? do you see changes related to methodReference or timestamp? I know that the SUnit code niall sent us does not contain all the source code and that the binary is different from the source code. we should investigate that. Stef > > thanks > > mariano > > > > > > Any help is really appreaciated. > > > > Thanks > > > > Mariano > > _______________________________________________ > > Pharo-project mailing list > > [hidden email] > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
In reply to this post by Mariano Martinez Peck
FYI I encountered the same problem in gemstone. The only thing I know is that all loaded packages were created in pharo that showed this behaviour. It didn't show up in a reproducable manner and some packages were clean again after a few package updates. And for some month now I didn't see it. Norbert
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
We had a similar problem in squeaknos package, but just for some kind of classes. It was caused by having an initialize class method in classes derived from ExternalStructure, maybe it's because of the same reason? look there, you may get some answers.
regards, javier. 2010/9/26 Norbert Hartl <[hidden email]>
-- Javier Pimás Ciudad de Buenos Aires _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
In reply to this post by NorbertHartl
Thanks!!!
Because this bug is annoying. At one point we will have to dive into MC :). So many things to do. ;) Stef > We had a similar problem in squeaknos package, but just for some kind of classes. It was caused by having an initialize class method in classes derived from ExternalStructure, maybe it's because of the same reason? look there, you may get some answers. > > regards, > javier. > > 2010/9/26 Norbert Hartl <[hidden email]> > FYI I encountered the same problem in gemstone. The only thing I know is that all loaded packages were created in pharo that showed this behaviour. It didn't show up in a reproducable manner and some packages were clean again after a few package updates. And for some month now I didn't see it. > > Norbert > > > Am 25.09.2010 um 21:12 schrieb Mariano Martinez Peck <[hidden email]>: > >> >> >> On Sat, Sep 25, 2010 at 9:02 PM, Stéphane Ducasse <[hidden email]> wrote: >> >> On Sep 25, 2010, at 8:25 PM, Mariano Martinez Peck wrote: >> >> > Hi. I am having a probem with Glorp and I really have no idea what can be. The problem is that I load the package Glorp and just after loading, I do a "changes" in the MC Browser and I see a lot of classes with a lot of changes and all of them like "revison changed". This is annoying since it doesn't let me easily see what I have really changed. >> > >> > To reproduce: >> > >> > - Load the package "Glorp" from http://www.squeaksource.com/SqueakDBX >> > - Open a MC Browser, select Glorp package and press the "Changes" button agains the ss repo. And you will see :) >> >> May be the image used to save the package got a problem and changed the timestamp of the methods. >> So when you merge you get changed methods. >> >> I've just tried commiting and load them in a clean image...same problem. >> >> And if it were what you say...is there a solution? >> >> thanks >> >> mariano >> >> >> > >> > Any help is really appreaciated. >> > >> > Thanks >> > >> > Mariano >> > _______________________________________________ >> > Pharo-project mailing list >> > [hidden email] >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > -- > Javier Pimás > Ciudad de Buenos Aires > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
In reply to this post by melkyades
2010/9/26 Javier Pimás <[hidden email]> We had a similar problem in squeaknos package, but just for some kind of classes. It was caused by having an initialize class method in classes derived from ExternalStructure, maybe it's because of the same reason? look there, you may get some answers. Thanks. It is good to know I am not the only one. This bug is REAAAAALY annoying since you cannot see your changes. I've checked and I have no #initialize at class level :( The only thing I found is class side #new implementd something like: new ^super new initialize. can this be the problem? where could I put a halt to see the problem ? thanks in advance mariano regards, _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
Gary, BWT, it would be nice to have a way to filter (hde) all those methods as "revision changed" when seeing the changes.
After that, I am able to see only the really changed methods :)
On Mon, Sep 27, 2010 at 10:42 PM, Mariano Martinez Peck <[hidden email]> wrote:
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Mariano Martinez Peck
I reviewed the code we had. It wasn't a problem of initialize actually, it had to do with automatic code generation. Monticello calls initialize method for the classes it loads, which we didn't know, and we had made initialize to touch and recompile some methods. The thing is that maybe some code you have is subreptitiously recompiling the methods automatically once and again without your knowledge, and thus monticello takes note.
2010/9/27 Mariano Martinez Peck <[hidden email]>
-- Javier Pimás Ciudad de Buenos Aires _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
In reply to this post by melkyades
it would be nice to have a simple case that we can reproduce.
Stef On Sep 27, 2010, at 10:42 PM, Mariano Martinez Peck wrote: > > > 2010/9/26 Javier Pimás <[hidden email]> > We had a similar problem in squeaknos package, but just for some kind of classes. It was caused by having an initialize class method in classes derived from ExternalStructure, maybe it's because of the same reason? look there, you may get some answers. > > > Thanks. It is good to know I am not the only one. This bug is REAAAAALY annoying since you cannot see your changes. > > I've checked and I have no #initialize at class level :( > > The only thing I found is class side #new implementd something like: > > new > > ^super new initialize. > > can this be the problem? > > where could I put a halt to see the problem ? > > thanks in advance > > mariano > > > regards, > javier. > > 2010/9/26 Norbert Hartl <[hidden email]> > > FYI I encountered the same problem in gemstone. The only thing I know is that all loaded packages were created in pharo that showed this behaviour. It didn't show up in a reproducable manner and some packages were clean again after a few package updates. And for some month now I didn't see it. > > Norbert > > > Am 25.09.2010 um 21:12 schrieb Mariano Martinez Peck <[hidden email]>: > >> >> >> On Sat, Sep 25, 2010 at 9:02 PM, Stéphane Ducasse <[hidden email]> wrote: >> >> On Sep 25, 2010, at 8:25 PM, Mariano Martinez Peck wrote: >> >> > Hi. I am having a probem with Glorp and I really have no idea what can be. The problem is that I load the package Glorp and just after loading, I do a "changes" in the MC Browser and I see a lot of classes with a lot of changes and all of them like "revison changed". This is annoying since it doesn't let me easily see what I have really changed. >> > >> > To reproduce: >> > >> > - Load the package "Glorp" from http://www.squeaksource.com/SqueakDBX >> > - Open a MC Browser, select Glorp package and press the "Changes" button agains the ss repo. And you will see :) >> >> May be the image used to save the package got a problem and changed the timestamp of the methods. >> So when you merge you get changed methods. >> >> I've just tried commiting and load them in a clean image...same problem. >> >> And if it were what you say...is there a solution? >> >> thanks >> >> mariano >> >> >> > >> > Any help is really appreaciated. >> > >> > Thanks >> > >> > Mariano >> > _______________________________________________ >> > Pharo-project mailing list >> > [hidden email] >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > -- > Javier Pimás > Ciudad de Buenos Aires > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
If you get that case, an idea that should work is to modify
Behavior>>#compile:classified:notifying:trailer:ifFail: method (or someone like it) to insert a breakpoint that only halts when the new code is the same than the existing one. Then you could trace back who is recompiling existing code without your knowledge Regards, Javier. On Tue, Sep 28, 2010 at 4:11 AM, Stéphane Ducasse <[hidden email]> wrote: it would be nice to have a simple case that we can reproduce. -- Javier Pimás Ciudad de Buenos Aires _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: After loading a package...all changes with "revision changed"
|
|
In reply to this post by Mariano Martinez Peck
OK....found the problem. I think these are method recategorization. They say "revision changed" but since you don't see the category in the MC merge/changes browser, then you don't undrerstand why.
In my case, the category changes were due to overrides. There is a package GlorpPostLoad which seems to have several overrides in Glorp package.... cheers mariano On Mon, Oct 4, 2010 at 12:57 PM, Gary Chambers <[hidden email]> wrote:
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |