[Ann] Calypso update: method browser and better UI

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Odd (and wrong) implementation of Float>>sign

stepharong
**TX**

Without bug entry it will get lost in the noise and stress.

Stef


> At Stef's request, I've opened case 19629 on this issue.
>
> On 01/27/2017 11:14 PM, Andres Valloud wrote:
>>> The 2007 update of 10967 is somewhat more helpful. It replaces the
>>> "sign" operation with one called "signum" which returns 1, -1, or NaN.
>>> It returns 1 for positive zero and positive infinity, and -1 for
>>> negative zero and negative infinity. If given a qNaN, it returns a  
>>> qNaN.
>>> If given a signaling NaN, it returns a qNaN but notifies the  
>>> application
>>> of an "invalid" situation.
>>
>> That's ISO 10967.  However, IEEE-758-2008 specifies implementations
>> shall provide isSignMinus(x).  This operation is true if and only if x
>> has negative sign, and applies to zeros and NaNs.
>>
>> IMO, values that operate according to IEEE-758-2008 should behave as
>> specified by IEEE-758-2008 by default.  The ISO 10967 standard seems
>> more of a layer on top of things like IEEE-758-2008, because it's a
>> standard for language agnostic arithmetic.
>>
>> So, shouldn't #sign behave as in IEEE-758-2008?
>>
>>     ^self isSignMinus ifTrue: [-1] ifFalse: [1]
>
> I think that defining #sign this way would add to the confusion.
>
> IEEE-754 does not define a "sign" operation. ANSI Smalltalk and ISO/IEC
> 10967 do, so it makes sense to provide a #sign that conforms to those
> standards -- answering -1, 0, or 1.
>
> IEEE-754 does define an isSignMinus operation, answering true or false,
> so it makes sense to provide that operation in addition to the ones
> specified by the other standards.
>
>>
>> It looks like the real question is whether Float's methods are merely
>> renaming IEEE-758-2008 functionality (if yes, why rename at all and add
>> to the confusion?), ISO 10967 functionality, or are something else
>> entirely (e.g. Smalltalk provided behavior in the context of the
>> Smalltalk experience).
>
> First and foremost, Smalltalk. The ANSI Smalltalk numeric spec is based
> on 10967, but that standard lacks some operations found in IEEE-754. But
> those have different names anyway, so it's easy in this case to comply
> with *both* standards.
>
> Regards,
>
> -Martin
>


--
Using Opera's mail client: http://www.opera.com/mail/

Reply | Threaded
Open this post in threaded view
|

Re: [Ann] Calypso update: method browser and better UI

Denis Kudriashov
In reply to this post by Stephan Eggermont-3

2017-01-31 1:20 GMT+01:00 Stephan Eggermont <[hidden email]>:
Nice!

  * white toolbar (according to theme background color)

That doesn't work well. Don't mix styles like this, that is
confusing.

Why? It was by intention. Idea to make toolbar with same color as main table panels. And they have default background color
Reply | Threaded
Open this post in threaded view
|

Re: [Ann] Calypso update: method browser and better UI

Stephan Eggermont-3
On 31/01/17 14:45, Denis Kudriashov wrote:

>
> 2017-01-31 1:20 GMT+01:00 Stephan Eggermont
> <[hidden email]
> <mailto:[hidden email]>>:
>
>     Nice!
>
>           * white toolbar (according to theme background color)
>
>
>     That doesn't work well. Don't mix styles like this, that is
>     confusing.
>
>
> Why? It was by intention. Idea to make toolbar with same color as main
> table panels. And they have default background color

- The whole window uses visible separation, except for the toolbar.
- It is unclear where the toolbar applies to
- The color and style of the radio buttons differs from other UI elements
- The color of the tabs and tab panel are incorrect, the inactive tabs
take away attention.

Stephan


Reply | Threaded
Open this post in threaded view
|

Re: [Ann] Calypso update: method browser and better UI

Denis Kudriashov

2017-01-31 18:53 GMT+01:00 Stephan Eggermont <[hidden email]>:

          * white toolbar (according to theme background color)


    That doesn't work well. Don't mix styles like this, that is
    confusing.


Why? It was by intention. Idea to make toolbar with same color as main
table panels. And they have default background color

- The whole window uses visible separation, except for the toolbar.

Ok.

- It is unclear where the toolbar applies to
- The color and style of the radio buttons differs from other UI elements
- The color of the tabs and tab panel are incorrect, the inactive tabs take away attention.

I always said that UI needs much more work. But my question was to your "don't mix styles".
Do you think it looks worse than before?
I am not designer and would be very appreciate if somebody paint how it should be.
Reply | Threaded
Open this post in threaded view
|

Re: Odd (and wrong) implementation of Float>>sign

Andres Valloud-4
In reply to this post by Martin McClure-2
Martin,

On 1/30/17 16:41 , Martin McClure wrote:

> IEEE-754 does not define a "sign" operation. ANSI Smalltalk and ISO/IEC
> 10967 do, so it makes sense to provide a #sign that conforms to those
> standards -- answering -1, 0, or 1.
>
> IEEE-754 does define an isSignMinus operation, answering true or false,
> so it makes sense to provide that operation in addition to the ones
> specified by the other standards.

Yes on isSignMinus.  It may also be useful to define #signBit, and
implement #isSignMinus as ^self signBit = 1.

These types of messages are very useful for testing the implementation
is doing the right thing IEEE-wise (hence VM-primitive-wise), so that
it's possible to implement e.g. ISO 10967 with confidence.

Andres.

Reply | Threaded
Open this post in threaded view
|

Re: [Ann] Calypso update: method browser and better UI

Stephan Eggermont-3
In reply to this post by Denis Kudriashov
On 31/01/17 21:10, Denis Kudriashov wrote:
> I always said that UI needs much more work. But my question was to your
> "don't mix styles".
> Do you think it looks worse than before?

I like the toolbar in the middle, and the separators.

> I am not designer and would be very appreciate if somebody paint how it
> should be.

I'll take a look at it, but am a bit slow at the moment.
Attached is current painting state of a morph that might be useful.

Stephan

SegmentedControl.png (15K) Download Attachment
12