[BUG][FIX] CompiledMethodTrailer

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[BUG][FIX] CompiledMethodTrailer

Igor Stasenko
Okay, seems like i found the bug.


(CompiledMethodTrailer new sourcePointer: 0) testEncoding

fails.

And it happens only when you pass 0 as source pointer!!
Such an obscure case!

@squeakers, for the context, check the discussion "Problem with
CompiledMethodTrailer"
in pharo-dev list.

On 10 May 2011 12:47, Mariano Martinez Peck <[hidden email]> wrote:

>
>>
>> >
>> > I must be wrong, because the dev image when it is build, it calls all
>> > cleanUp methods for classes, so CompiledMethod class >> cleanUp shuld
>> > have
>> > been called, but if I take the Pharo1.3 result, I can see the source
>> > code
>> > (not decompiled)
>> >
>>
>> But you can't see the source of those methods in browser, because
>> browser works only with installed methods
>> while cleanup touching only non-installed ones.
>
>
> grrrr sorry, I forgot about the #isInstalled ... I went directly to see
> #destroySourcePointer
> heheheh
>
>>
>> >>
>> >> When i do this, my image hangs.
>> >
>> > I have just tried and it crash!!!  Actually, I evaluated CompiledMethod
>> > cleanUp. And just after cmd+b in CompiledMethod (to browse it) -> crash
>> > How it is possilbe it didn't crash while building the dev image?   or
>> > the
>> > first time I browse a class?
>> > maybe this incorrect CM are created by the build process just after the
>> > cleanUp ?
>> >
>> I don't know yet.
>> Maybe there is some test, which breaking them when it runs? Or tests
>> are not run on those images?
>
> I was thinking exactly the same. But no, this image has not run the tests.
> There are other images specially to download from hudson that are those
> after running tests :(
>
>
>
> --
> Mariano
> http://marianopeck.wordpress.com
>
>


--
Best regards,
Igor Stasenko AKA sig.



CompiledMethodTrailer-encodeVarLengthSourcePointer.st (852 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [BUG][FIX] CompiledMethodTrailer

Igor Stasenko
And here the test , which covering this issue.





--
Best regards,
Igor Stasenko AKA sig.



CompiledMethodTrailerTest-testEncodingZeroSourcePointer.st (476 bytes) Download Attachment