[BUG][FIX][FIX], was: (Re: [squeak-dev] Re: Flaw in SocketStream>>peek detected)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[BUG][FIX][FIX], was: (Re: [squeak-dev] Re: Flaw in SocketStream>>peek detected)

Igor Stasenko
My first attempt to fix it was also flawed. Thanks to Stephan for
pointing it out. (You can read our discussion here:
http://code.google.com/p/pharo/issues/detail?id=1813)


I hope this time its fixing it! :)


--
Best regards,
Igor Stasenko AKA sig.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

socketstream-fix2.1.cs (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [squeak-dev] Re: [BUG][FIX][FIX], was: (Re: Re: Flaw in SocketStream>>peek detected)

Igor Stasenko
I am completely & finally confused.
Anyways, a fix which i provided initially doesn't deals with timeouts,
just picks the right byte.
And it works for me. ;)

2010/1/15 Andreas Raab <[hidden email]>:

> Andreas Raab wrote:
>>
>> Andreas Raab wrote:
>>>
>>> Igor Stasenko wrote:
>>>>
>>>> " the above should endup with timeout exception ,
>>>> but following one should hang indefinitely"
>>>
>>> Absolutely not. Read the comment on shouldSignal:
>>>
>>>    "If shouldSignal is enabled the Socket Exceptions
>>>    ConnectionClosed and ConnectionTimedOut"
>>
>> And I guess I should read more carefully, too :-) In any case, timeouts
>> *are* handled via #timeout: and that makes good sense.
>
> (last response to my own post :-)
>
> And of course, the easy to do what you're trying to do is to change:
>
> shouldTimeout
>        ^timeout > 0 and:[shouldSignal]
>
> This would suppress all timeouts unless shouldSignal is true. BTW, I've
> never seen a case where I've been using a non-signaling socket stream. Does
> that case even exist?
>

I guess no.

> Cheers,
>  - Andreas
>
>



--
Best regards,
Igor Stasenko AKA sig.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project