Smalltalk › Cuis Smalltalk

[BUG][FIX] I can grab balloon text from the Taskbar

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Casey Ransberger-2

[BUG][FIX] I can grab balloon text from the Taskbar

The new Taskbar seems to expose a bug with tooltips. The tooltip doesn't behave like in other parts of the system: it appears under the hand (I think because the hand is near the bottom of the screen at the time and the help resists appearing below the screen,) and you can grab it and drag it. After that you have to destroy it with the halo, as it doesn't go away otherwise.

The expectation that seems most intuitive to me is this: the help morph should be "locked" so the user can't grab it. Problem solved.

I wasn't completely sure where to fix this. It looks like the Taskbar is just setting up balloon text normally, which suggested it's somewhere in Cuis itself. After a bit of browsing I made a guess that seems to fix the problem by sending #lockUnlockMorph inside of HoverHelpMorph>>popUpForHand:. There were numerous other things I tried elsewhere that sent the same message and fixed the problem, but this seemed the most sensible solution once I'd locked onto it (to lock the morph inside of its own initializer.)

It seems that the risk of regression elsewhere is low. Fix attached.

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org

1868-CuisCore-CaseyRansberger-2013Dec12-18h35m-cbr.1.cs.st (886 bytes) Download Attachment

KenDickey

Re: [BUG][FIX] I can grab balloon text from the Taskbar

On Thu, 12 Dec 2013 19:03:16 -0800
Casey Ransberger <[hidden email]> wrote:

> The new Taskbar seems to expose a bug with tooltips. The tooltip doesn't
> behave like in other parts of the system: it appears under the hand (I
> think because the hand is near the bottom of the screen at the time and the
> help resists appearing below the screen,) and you can grab it and drag it.
> After that you have to destroy it with the halo, as it doesn't go away
> otherwise.

Casey, thanks for the fix.

I also sent a fix on this to Juan. I think he is very busy and fixes come out of his sleep time. He replied that he had already incorporated his version of a fix to the next Cuis release.

Having the click grab the balloon is painful to me too.

I guess we should remind Juan to release the update. !PLEASE! ;^)

-KenD

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org

-KenD

Juan Vuletich-4

Re: [BUG][FIX] I can grab balloon text from the Taskbar

Apologies Folks,

I'll really try to push it this weekend.

Cheers,
Juan Vuletich

On 12/13/2013 2:11 PM, Ken Dickey wrote:

> On Thu, 12 Dec 2013 19:03:16 -0800
> Casey Ransberger<[hidden email]> wrote:
>
>> The new Taskbar seems to expose a bug with tooltips. The tooltip doesn't
>> behave like in other parts of the system: it appears under the hand (I
>> think because the hand is near the bottom of the screen at the time and the
>> help resists appearing below the screen,) and you can grab it and drag it.
>> After that you have to destroy it with the halo, as it doesn't go away
>> otherwise.
> Casey, thanks for the fix.
>
> I also sent a fix on this to Juan. I think he is very busy and fixes come out of his sleep time. He replied that he had already incorporated his version of a fix to the next Cuis release.
>
> Having the click grab the balloon is painful to me too.
>
> I guess we should remind Juan to release the update. !PLEASE! ;^)
>
> -KenD
>
> _______________________________________________
> Cuis mailing list
> [hidden email]
> http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
>

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org