[BUG][FIX} Review this please...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[BUG][FIX} Review this please...

Edgar J. De Cleene-3
[BUG][FIX} Review this please... Folks;

Just send the cleanup of servers external to Squeak long time non working and the missed menu in
in the build directory Tree pane .

But current code do not shows the name you choose for your external server.

Example

"Please fill in the following info, then select all text and choose DoIt."

    | aa |
    self flag: #ViolateNonReferenceToOtherClasses.
    aa := ServerDirectory new.
    aa server: 'st.cs.uiuc.edu'.    "host"
    aa user: 'anonymous'.
    aa password: '[hidden email]'.
    aa directory: '/Smalltalk/Squeak/Goodies'.
    aa url: ''.    "<- this is optional.  Only used when *writing* update files."
    ServerDirectory addServer: aa named: 'UIUCArchive'.  "<- known by this name in Squeak"

You do not see UIUCArchive in the server list.

I fix, but don’t like , so send here for best solution

The ugly fix:

Copy FileList2 initialDirectoryList code, put in Filelist rootDirectoryList

FileList  directoryNameOf: aDirectory
(aDirectory isKindOf: FileDirectoryWrapper) ifFalse:[
    ^aDirectory localName] ifTrue:[ ^aDirectory asString]


Additional question

Is FileDirectoryWrapper deprecated now ? Do not should be used?

Edgar