[BUG?]SMSimpleInstaller>>fileIntoChangeSetNamed:fromStream:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[BUG?]SMSimpleInstaller>>fileIntoChangeSetNamed:fromStream:

Trygve Reenskaug
SMSimpleInstaller>>fileIntoChangeSetNamed: aString fromStream: stream
    "We let the user confirm filing into an existing ChangeSet
    or specify another ChangeSet name if
    the name derived from the filename already exists."
    | changeSet newName oldChanges global |
    newName := aString.
    changeSet := SMInstaller changeSetNamed: newName.
    changeSet ifNotNil: [
        newName := self silent ifNil: [UIManager default
                                    request: 'ChangeSet already present, just confirm to overwrite or enter a new name:'
                                    initialAnswer: newName]
                        ifNotNil: [newName].
    ++++++


AFAICS, 'self silent' cannot return nil, it always returns a boolan.


Reply | Threaded
Open this post in threaded view
|

Re: [BUG?]SMSimpleInstaller>>fileIntoChangeSetNamed:fromStream:

Tobias Pape
Hi

On 12.01.2015, at 11:09, Trygve Reenskaug <[hidden email]> wrote:

> SMSimpleInstaller>>fileIntoChangeSetNamed: aString fromStream: stream
>     "We let the user confirm filing into an existing ChangeSet
>     or specify another ChangeSet name if
>     the name derived from the filename already exists."
>     | changeSet newName oldChanges global |
>     newName := aString.
>     changeSet := SMInstaller changeSetNamed: newName.
>     changeSet ifNotNil: [
>         newName := self silent ifNil: [UIManager default
>                                     request: 'ChangeSet already present, just confirm to overwrite or enter a new name:'
>                                     initialAnswer: newName]
>                         ifNotNil: [newName].
>     ++++++
>
> AFAICS, 'self silent' cannot return nil, it always returns a boolan.

you're right :)
Care to put a fixed version into the inbox?
        http://source.squeak.org/inbox.html

Best
        -Tobia
Reply | Threaded
Open this post in threaded view
|

Re: [BUG?]SMSimpleInstaller>>fileIntoChangeSetNamed:fromStream:

Trygve Reenskaug
Sorry. My knowledge of Monticello isn't sufficient to post a single method into the inbox. =-O 

    

On 12.01.2015 11:39, Tobias Pape wrote:
Hi

On 12.01.2015, at 11:09, Trygve Reenskaug [hidden email] wrote:

SMSimpleInstaller>>fileIntoChangeSetNamed: aString fromStream: stream
    "We let the user confirm filing into an existing ChangeSet
    or specify another ChangeSet name if
    the name derived from the filename already exists."
    | changeSet newName oldChanges global |
    newName := aString.
    changeSet := SMInstaller changeSetNamed: newName.
    changeSet ifNotNil: [
        newName := self silent ifNil: [UIManager default
                                    request: 'ChangeSet already present, just confirm to overwrite or enter a new name:' 
                                    initialAnswer: newName]
                        ifNotNil: [newName].
    ++++++

AFAICS, 'self silent' cannot return nil, it always returns a boolan.
you're right :)
Care to put a fixed version into the inbox?
	http://source.squeak.org/inbox.html

Best
	-Tobia


Sorry.  I can't find a way to post input (a method source) directly  into the inbox and my knowledge of Monticello etc.  isn't sufficient to let me post a single method into the repository and  my knowledge of SMSimpleInstaller isn't sufficient for me to write a meaningful test.