[BUG] WAUrl>>scheme:

> -----Original Message-----
> From: [hidden email] [mailto:seaside-
> [hidden email]] On Behalf Of Boris Popov
> Sent: Thursday, October 18, 2007 10:20 AM
> To: Seaside - general discussion
> Subject: [Seaside] [BUG] WAUrl>>scheme:
>
> Using symbols in #serverProtocol preference breaks suppression of port
> numbers in URL encoding for 80 and 443, the following test would fail,
>
> testSymbolScheme
>  url hostname: 'seaside.st'.
>  url port: 80; scheme: 'http'.
>  self assert: url displayString = 'http://seaside.st'.
>  url port: 443; scheme: 'https'.
>  self assert: url displayString = 'https://seaside.st'.
>  url port: 80; scheme: #http.
>  self assert: url displayString = 'http://seaside.st'.
>  url port: 443; scheme: #https.
>  self assert: url displayString = 'https://seaside.st'.
>
> Interestingly enough even the setter suggests using symbols,
>
> scheme: aSymbol
>  scheme := aSymbol
>
> While it would certainly be nice to have one kind of object there, for
> backwards compatibility I suggest we allow for both,
>
> scheme: aSymbol
>  scheme := aSymbol asString
>
> Thoughts?
>
> -Boris
>
> --
> +1.604.689.0322
> DeepCove Labs Ltd.
> 4th floor 595 Howe Street
> Vancouver, Canada V6C 2T5
> http://tinyurl.com/r7uw4
>
> [hidden email]
>
> CONFIDENTIALITY NOTICE
>
> This email is intended only for the persons named in the message
> header. Unless otherwise indicated, it contains information that is
> private and confidential. If you have received it in error, please
> notify the sender and delete the entire message including any
> attachments.
>
> Thank you.
>
> _______________________________________________
> seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

> -----Original Message-----
> From: [hidden email]
> [mailto:[hidden email]] On Behalf
> Of Boris Popov
> Sent: jeudi, 18. octobre 2007 19:20
> To: Seaside - general discussion
> Subject: [Seaside] [BUG] WAUrl>>scheme:
>
> Using symbols in #serverProtocol preference breaks
> suppression of port numbers in URL encoding for 80 and 443,
> the following test would fail,
>
> testSymbolScheme
>  url hostname: 'seaside.st'.
>  url port: 80; scheme: 'http'.
>  self assert: url displayString = 'http://seaside.st'.
>  url port: 443; scheme: 'https'.
>  self assert: url displayString = 'https://seaside.st'.
>  url port: 80; scheme: #http.
>  self assert: url displayString = 'http://seaside.st'.
>  url port: 443; scheme: #https.
>  self assert: url displayString = 'https://seaside.st'.
>
> Interestingly enough even the setter suggests using symbols,
>
> scheme: aSymbol
>  scheme := aSymbol
>
> While it would certainly be nice to have one kind of object
> there, for backwards compatibility I suggest we allow for both,
>
> scheme: aSymbol
>  scheme := aSymbol asString
>
> Thoughts?
>
> -Boris
>
> --
> +1.604.689.0322
> DeepCove Labs Ltd.
> 4th floor 595 Howe Street
> Vancouver, Canada V6C 2T5
> http://tinyurl.com/r7uw4
>
> [hidden email]
>
> CONFIDENTIALITY NOTICE
>
> This email is intended only for the persons named in the
> message header. Unless otherwise indicated, it contains
> information that is private and confidential. If you have
> received it in error, please notify the sender and delete the
> entire message including any attachments.
>
> Thank you.
>
> _______________________________________________
> seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>

> -----Original Message-----
> From: [hidden email] [mailto:seaside-
> [hidden email]] On Behalf Of Bany, Michel
> Sent: Thursday, October 18, 2007 11:05 AM
> To: Seaside - general discussion
> Subject: RE: [Seaside] [BUG] WAUrl>>scheme:
>
> Hi Boris,
> Your tests pass just fine in Squeak. They fail in VW because
> #displayString produces different answers in Squeak and VW when sent

> a symbol (in Squeak #foo displayString -> 'foo').
> So I integrated your fix (and your tests) in Squeak
> Seaside2.8a1-mb.510
> Cheers,
> Michel.
>
>
>
> > -----Original Message-----
> > From: [hidden email]
> > [mailto:[hidden email]] On Behalf
> > Of Boris Popov
> > Sent: jeudi, 18. octobre 2007 19:20
> > To: Seaside - general discussion
> > Subject: [Seaside] [BUG] WAUrl>>scheme:
> >
> > Using symbols in #serverProtocol preference breaks
> > suppression of port numbers in URL encoding for 80 and 443,
> > the following test would fail,
> >
> > testSymbolScheme
> >  url hostname: 'seaside.st'.
> >  url port: 80; scheme: 'http'.
> >  self assert: url displayString = 'http://seaside.st'.
> >  url port: 443; scheme: 'https'.
> >  self assert: url displayString = 'https://seaside.st'.
> >  url port: 80; scheme: #http.
> >  self assert: url displayString = 'http://seaside.st'.
> >  url port: 443; scheme: #https.
> >  self assert: url displayString = 'https://seaside.st'.
> >
> > Interestingly enough even the setter suggests using symbols,
> >
> > scheme: aSymbol
> >  scheme := aSymbol
> >
> > While it would certainly be nice to have one kind of object
> > there, for backwards compatibility I suggest we allow for both,
> >
> > scheme: aSymbol
> >  scheme := aSymbol asString
> >
> > Thoughts?
> >
> > -Boris
> >
> > --
> > +1.604.689.0322
> > DeepCove Labs Ltd.
> > 4th floor 595 Howe Street
> > Vancouver, Canada V6C 2T5
> > http://tinyurl.com/r7uw4
> >
> > [hidden email]
> >
> > CONFIDENTIALITY NOTICE
> >
> > This email is intended only for the persons named in the
> > message header. Unless otherwise indicated, it contains
> > information that is private and confidential. If you have
> > received it in error, please notify the sender and delete the
> > entire message including any attachments.
> >
> > Thank you.
> >
> > _______________________________________________
> > seaside mailing list
> > [hidden email]
> > http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
> >
> _______________________________________________
> seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

> Or even better switch exclusively to symbol and speed up suppression
> comparisons in encodeServerOn:
>
> scheme: aSymbol
>   scheme := aSymbol asSymbol
>
> ...
>
> scheme == #http , scheme == #https
>
> Cheers!
>
> -Boris
>
> --
> +1.604.689.0322
> DeepCove Labs Ltd.
> 4th floor 595 Howe Street
> Vancouver, Canada V6C 2T5
> http://tinyurl.com/r7uw4
>
> [hidden email]
>
> CONFIDENTIALITY NOTICE
>
> This email is intended only for the persons named in the message
> header. Unless otherwise indicated, it contains information that is
> private and confidential. If you have received it in error, please
> notify the sender and delete the entire message including any
> attachments.
>
> Thank you.
>
> > -----Original Message-----
> > From: [hidden email] [mailto:seaside-
> > [hidden email]] On Behalf Of Boris Popov
> > Sent: Thursday, October 18, 2007 10:20 AM
> > To: Seaside - general discussion
> > Subject: [Seaside] [BUG] WAUrl>>scheme:
> >
> > Using symbols in #serverProtocol preference breaks suppression of port
> > numbers in URL encoding for 80 and 443, the following test would fail,
> >
> > testSymbolScheme
> >  url hostname: 'seaside.st'.
> >  url port: 80; scheme: 'http'.
> >  self assert: url displayString = 'http://seaside.st'.
> >  url port: 443; scheme: 'https'.
> >  self assert: url displayString = 'https://seaside.st'.
> >  url port: 80; scheme: #http.
> >  self assert: url displayString = 'http://seaside.st'.
> >  url port: 443; scheme: #https.
> >  self assert: url displayString = 'https://seaside.st'.
> >
> > Interestingly enough even the setter suggests using symbols,
> >
> > scheme: aSymbol
> >  scheme := aSymbol
> >
> > While it would certainly be nice to have one kind of object there, for
> > backwards compatibility I suggest we allow for both,
> >
> > scheme: aSymbol
> >  scheme := aSymbol asString
> >
> > Thoughts?
> >
> > -Boris
> >
> > --
> > +1.604.689.0322
> > DeepCove Labs Ltd.
> > 4th floor 595 Howe Street
> > Vancouver, Canada V6C 2T5
> > http://tinyurl.com/r7uw4
> >
> > [hidden email]
> >
> > CONFIDENTIALITY NOTICE
> >
> > This email is intended only for the persons named in the message
> > header. Unless otherwise indicated, it contains information that is
> > private and confidential. If you have received it in error, please
> > notify the sender and delete the entire message including any
> > attachments.
> >
> > Thank you.
> >
> > _______________________________________________
> > seaside mailing list
> > [hidden email]
> > http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
> _______________________________________________
> seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>

> -----Original Message-----
> From: [hidden email] [mailto:seaside-
> [hidden email]] On Behalf Of Michel Bany
> Sent: Thursday, October 18, 2007 11:15 AM
> To: Seaside - general discussion
> Subject: Re: [Seaside] [BUG] WAUrl>>scheme:
>
>
> On Oct 18, 2007, at 8:07 PM, Boris Popov wrote:
>
> > Michel,
> >
> > I'm not quite clear how they pass in Squeak, because encodeServerOn:
> > does a simple comparison (scheme = 'http') which should fail when
> > scheme
> > is #http?
> >
>
> Oh, I forgot to mention that #foo = 'foo' answers true inSqueak.
>
>
>
> _______________________________________________
> seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

> -----Original Message-----
> From: [hidden email] [mailto:seaside-
> [hidden email]] On Behalf Of Michel Bany
> Sent: Thursday, October 18, 2007 11:30 AM
> To: Seaside - general discussion
> Subject: Re: [Seaside] [BUG] WAUrl>>scheme:
>
> BTW, Boris,
>
> Which port and which version are you using?
> Are you already using Cincom Seaside?
> I know that Cincom Seaside is unfinished business at this time,
> so do I need to continue moving forward with my port,
> or should I stop.
>
> Thanks for your advice,
> Michel.
>
> _______________________________________________
> seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside