[BUG] fileOut option in store item view

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[BUG] fileOut option in store item view

Nicolas Cellier
It seems to me that the 'File Out ...' item in the 'store published items'
window (upper right pane which contains the list of versions) incorrectly file
out class methods as instance methods in VW7.8 nc

Nicolas

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] fileOut option in store item view

Niall Ross
Dear Nicolas,

>It seems to me that the 'File Out ...' item in the 'store published items'
>window (upper right pane which contains the list of versions) incorrectly file
>out class methods as instance methods in VW7.8 nc
>  
>
You are quite right:  this went wrong in 7.8 and is still wrong in
7.8.1.  However it it is fixed in 7.9.

In 7.8.1 and 7.8, load and file out from the image.  Do not attempt
direct file out from the database.

                   Yours faithfully
                         Niall Ross

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] fileOut option in store item view

jarober
Is there a patch?  I know we are going to upgrade to 7.8 or 7.8.1, and sometimes, a package can't be loaded cleanly from Store....


On Jan 27, 2012, at 12:38 PM, Niall Ross wrote:

> Dear Nicolas,
>
>> It seems to me that the 'File Out ...' item in the 'store published items'
>> window (upper right pane which contains the list of versions) incorrectly file
>> out class methods as instance methods in VW7.8 nc
>>
>>
> You are quite right:  this went wrong in 7.8 and is still wrong in
> 7.8.1.  However it it is fixed in 7.9.
>
> In 7.8.1 and 7.8, load and file out from the image.  Do not attempt
> direct file out from the database.
>
>                   Yours faithfully
>                         Niall Ross
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

James Robertson
http://www.jarober.com
[hidden email]




_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] fileOut option in store item view

Samuel S. Shuster-2
James, et al:

The patch is in StorePackage>>fileOutMethodsOn: (Note this is not appropriate for pre 7.8 images)

fileOutMethodsOn: aSourceFileManager
"First group methods by class and protocol 
and the ask aFileManager to do the job class by class"

| toFileOut classes protocols |
toFileOut := Dictionary new.
self methodDefinitions do:
[:each | 
classes := toFileOut
at: each longNameWithMetaFromSmalltalk
ifAbsent: [Dictionary new].
protocols := classes
at: each protocol asString
ifAbsent: [Set new].
protocols add: each.
classes
at: each protocol asString
put: protocols.
toFileOut
at: each longNameWithMetaFromSmalltalk
put: classes.
(each name = 'initialize' and: [each absoluteClassName namesMetaClass])
ifTrue: [aSourceFileManager initializeThisClass: (ClassDescriptor fullName: each longNameFromSmalltalk asClassNameOnly meta: false)]].
toFileOut keysAndValuesDo:
[:key :value | 
aSourceFileManager fileOutTTMessages: value for: key logging: false.
aSourceFileManager cr].

Is there a patch?  I know we are going to upgrade to 7.8 or 7.8.1, and sometimes, a package can't be loaded cleanly from Store....


On Jan 27, 2012, at 12:38 PM, Niall Ross wrote:

Dear Nicolas,

It seems to me that the 'File Out ...' item in the 'store published items'
window (upper right pane which contains the list of versions) incorrectly file
out class methods as instance methods in VW7.8 nc


You are quite right:  this went wrong in 7.8 and is still wrong in 
7.8.1.  However it it is fixed in 7.9.

In 7.8.1 and 7.8, load and file out from the image.  Do not attempt 
direct file out from the database.

                 Yours faithfully
                       Niall Ross

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc


                                And So It Goes
                                     Sames
______________________________________________________________________

Samuel S. Shuster [|]
VisualWorks Engineering, Store Project
Smalltalk Enables Success -- What Are YOU Using?





_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] fileOut option in store item view

jarober
Thanks!

On Jan 27, 2012, at 2:57 PM, Samuel S. Shuster wrote:

James, et al:

The patch is in StorePackage>>fileOutMethodsOn: (Note this is not appropriate for pre 7.8 images)

fileOutMethodsOn: aSourceFileManager
"First group methods by class and protocol 
and the ask aFileManager to do the job class by class"

| toFileOut classes protocols |
toFileOut := Dictionary new.
self methodDefinitions do:
[:each | 
classes := toFileOut
at: each longNameWithMetaFromSmalltalk
ifAbsent: [Dictionary new].
protocols := classes
at: each protocol asString
ifAbsent: [Set new].
protocols add: each.
classes
at: each protocol asString
put: protocols.
toFileOut
at: each longNameWithMetaFromSmalltalk
put: classes.
(each name = 'initialize' and: [each absoluteClassName namesMetaClass])
ifTrue: [aSourceFileManager initializeThisClass: (ClassDescriptor fullName: each longNameFromSmalltalk asClassNameOnly meta: false)]].
toFileOut keysAndValuesDo:
[:key :value | 
aSourceFileManager fileOutTTMessages: value for: key logging: false.
aSourceFileManager cr].

Is there a patch?  I know we are going to upgrade to 7.8 or 7.8.1, and sometimes, a package can't be loaded cleanly from Store....


On Jan 27, 2012, at 12:38 PM, Niall Ross wrote:

Dear Nicolas,

It seems to me that the 'File Out ...' item in the 'store published items'
window (upper right pane which contains the list of versions) incorrectly file
out class methods as instance methods in VW7.8 nc


You are quite right:  this went wrong in 7.8 and is still wrong in 
7.8.1.  However it it is fixed in 7.9.

In 7.8.1 and 7.8, load and file out from the image.  Do not attempt 
direct file out from the database.

                 Yours faithfully
                       Niall Ross

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc


                                And So It Goes
                                     Sames
______________________________________________________________________

Samuel S. Shuster [|]
VisualWorks Engineering, Store Project
Smalltalk Enables Success -- What Are YOU Using?







_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] fileOut option in store item view

Holger Guhl
In reply to this post by Samuel S. Shuster-2
And you need to add this one:

Store.ClassDescriptor>>fileOutObjectType
    "Answer a symbol that represents the type of the receiver."

    ^#class

Regards
Holger Guhl
-- 
Senior Consultant * Certified Scrum Master * [hidden email]
Tel: +49 231 9 75 99 21 * Fax: +49 231 9 75 99 20
Georg Heeg eK Dortmund
Handelsregister: Amtsgericht Dortmund  A 12812

Am 27.01.2012 20:57, schrieb Samuel S. Shuster:
James, et al:

The patch is in StorePackage>>fileOutMethodsOn: (Note this is not appropriate for pre 7.8 images)

fileOutMethodsOn: aSourceFileManager
"First group methods by class and protocol 
and the ask aFileManager to do the job class by class"

| toFileOut classes protocols |
toFileOut := Dictionary new.
self methodDefinitions do:
[:each | 
classes := toFileOut
at: each longNameWithMetaFromSmalltalk
ifAbsent: [Dictionary new].
protocols := classes
at: each protocol asString
ifAbsent: [Set new].
protocols add: each.
classes
at: each protocol asString
put: protocols.
toFileOut
at: each longNameWithMetaFromSmalltalk
put: classes.
(each name = 'initialize' and: [each absoluteClassName namesMetaClass])
ifTrue: [aSourceFileManager initializeThisClass: (ClassDescriptor fullName: each longNameFromSmalltalk asClassNameOnly meta: false)]].
toFileOut keysAndValuesDo:
[:key :value | 
aSourceFileManager fileOutTTMessages: value for: key logging: false.
aSourceFileManager cr].

Is there a patch?  I know we are going to upgrade to 7.8 or 7.8.1, and sometimes, a package can't be loaded cleanly from Store....


On Jan 27, 2012, at 12:38 PM, Niall Ross wrote:

Dear Nicolas,

It seems to me that the 'File Out ...' item in the 'store published items'
window (upper right pane which contains the list of versions) incorrectly file
out class methods as instance methods in VW7.8 nc


You are quite right:  this went wrong in 7.8 and is still wrong in 
7.8.1.  However it it is fixed in 7.9.

In 7.8.1 and 7.8, load and file out from the image.  Do not attempt 
direct file out from the database.

                 Yours faithfully
                       Niall Ross

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc


                                And So It Goes
                                     Sames
______________________________________________________________________

Samuel S. Shuster [|]
VisualWorks Engineering, Store Project
Smalltalk Enables Success -- What Are YOU Using?



_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc