Smalltalk › Amber Smalltalk

Beginners questions .... method protocols...

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Marten Feldtmann-2

Beginners questions .... method protocols...

I tried to organize my methods into different method protocols, but whenever I try to create a new method protocol I get the error message, that the class does not understand #organizer.

Any ideas ?

Nicolas Petton

Re: Beginners questions .... method protocols...

My guess is that you use the master version of Amber? ClassOrganizer
was introduced recently, and may very well include bugs. I think you
just found one :)

Can you report an issue entry in Github?

Nico

Marten Feldtmann <[hidden email]> writes:

> I tried to organize my methods into different method protocols, but
> whenever I try to create a new method protocol I get the error message,
> that the class does not understand #organizer.
>
> Any ideas ?

--
Nicolas Petton
http://nicolas-petton.fr

Marten Feldtmann-2

Re: Beginners questions .... method protocols...

In reply to this post by Marten Feldtmann-2

In "Kernel-Package" and Class "CompiledMethod" one might change the method to allow reorganization of methods again.

category: aString
   | oldCategory |
    oldCategory := self category.
   self basicAt: 'category' put: aString.

    self methodClass ifNotNil: [
       self methodClass organization addElement: aString.

       (self methodClass methods
           select: [ :each | each category = oldCategory ])
           ifEmpty: [ self methodClass organization removeElement: oldCategory ] ]

Nicolas Petton

Re: Beginners questions .... method protocols...

Marten,

Could you add that as a proposed fix on github?

Thanks,
Nico

Marten Feldtmann <[hidden email]> writes:

> In "Kernel-Package" and Class "CompiledMethod" one might change the method
> to allow reorganization of methods again.
>
>
> category: aString
> | oldCategory |
> oldCategory := self category.
> self basicAt: 'category' put: aString.
>
> self methodClass ifNotNil: [
> self methodClass organization addElement: aString.
>
> (self methodClass methods
> select: [ :each | each category = oldCategory ])
> ifEmpty: [ self methodClass organization removeElement:
> oldCategory ] ]

--
Nicolas Petton
http://nicolas-petton.fr