Block Equality?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Block Equality?

keith1y
I remember reading somewhere about a fix for testing block equality, but
cant remember where and I vaguely remember thinking it was
mentioned on this list.

can anyone enlighten me?

Keith

_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Block Equality?

Mathieu SUEN
Yeap
http://bugs.squeak.org/view.php?id=6599

On Dec 23, 2007, at 11:56 PM, Keith Hodges wrote:

> I remember reading somewhere about a fix for testing block equality,  
> but
> cant remember where and I vaguely remember thinking it was
> mentioned on this list.
>
> can anyone enlighten me?
>
> Keith
>
> _______________________________________________
> SmallWiki, Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki

        Mth




_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Block Equality?

keith1y
Mathieu Suen wrote:

> Yeap
> http://bugs.squeak.org/view.php?id=6599
>
> On Dec 23, 2007, at 11:56 PM, Keith Hodges wrote:
>
>  
>> I remember reading somewhere about a fix for testing block equality,  
>> but
>> cant remember where and I vaguely remember thinking it was
>> mentioned on this list.
>>
>> can anyone enlighten me?
>>
>> Keith
>>
>> _______________________________________________
>> SmallWiki, Magritte, Pier and Related Tools ...
>> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>    
Ahh,

I thought so, but... BlockContext doesnt have these

Keith

_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Block Equality?

Mathieu SUEN
Yes. It seems that equality is identity for BlockContext.
Should it be different?

On Dec 24, 2007, at 12:20 AM, Keith Hodges wrote:

> Mathieu Suen wrote:
>> Yeap
>> http://bugs.squeak.org/view.php?id=6599
>>
>> On Dec 23, 2007, at 11:56 PM, Keith Hodges wrote:
>>
>>
>>> I remember reading somewhere about a fix for testing block equality,
>>> but
>>> cant remember where and I vaguely remember thinking it was
>>> mentioned on this list.
>>>
>>> can anyone enlighten me?
>>>
>>> Keith
>>>
>>> _______________________________________________
>>> SmallWiki, Magritte, Pier and Related Tools ...
>>> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>>
> Ahh,
>
> I thought so, but... BlockContext doesnt have these
>
> Keith
>
> _______________________________________________
> SmallWiki, Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki

        Mth




_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Block Equality?

keith1y
In reply to this post by keith1y
Keith Hodges wrote:

> Mathieu Suen wrote:
>  
>> Yeap
>> http://bugs.squeak.org/view.php?id=6599
>>
>> On Dec 23, 2007, at 11:56 PM, Keith Hodges wrote:
>>
>>  
>>    
>>> I remember reading somewhere about a fix for testing block equality,  
>>> but
>>> cant remember where and I vaguely remember thinking it was
>>> mentioned on this list.
>>>
>>> can anyone enlighten me?
>>>
>>> Keith
>>>
>>> _______________________________________________
>>> SmallWiki, Magritte, Pier and Related Tools ...
>>> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>>    
>>>      
> Ahh,
>
> I thought so, but... BlockContext doesnt have these
>
> Keith
>  
Mathieu,

will this do the trick?

BlockContext<<#= other

    self class == other class ifFalse: [^ false].
    self home == other home ifFalse: [^ false].
    ^ self startpc == other startpc

Keith


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Block Equality?

keith1y
Ok spoke too soon..

BlockContext>>#= other

    self class == other class ifFalse: [^ false].
    self home receiver == other home receiver ifFalse: [^ false].
    self home selector == other home selector ifFalse: [^ false].
    ^ self startpc == other startpc

If I am handed two block contexts that are defined in the same place and
have the same contents etc then identiy comparison returns false. the
above works.

Are you saying that defining #= on BlockContext like this is wrong or
will break something?

thanks in advance

Keith

p.s. it would help to know because I am finding it rather useful


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Block Equality?

Mathieu SUEN
I think that defining #= on blockContext is ok.
AFAIK No one in the image use it.



On Dec 24, 2007, at 12:41 AM, Keith Hodges wrote:

> Ok spoke too soon..
>
> BlockContext>>#= other
>
>    self class == other class ifFalse: [^ false].
>    self home receiver == other home receiver ifFalse: [^ false].
>    self home selector == other home selector ifFalse: [^ false].
>    ^ self startpc == other startpc
>
> If I am handed two block contexts that are defined in the same place  
> and
> have the same contents etc then identiy comparison returns false. the
> above works.
>
> Are you saying that defining #= on BlockContext like this is wrong or
> will break something?
>
> thanks in advance
>
> Keith
>
> p.s. it would help to know because I am finding it rather useful
>
>
> _______________________________________________
> SmallWiki, Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki

        Mth




_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki