BlockContextTest
Locked
 
|
Hi,
I'm looking the failing tests... some tests defined in BlockContextTest relies on behavior not implemented in BlockClosure (but implemented in the old BlockContext)... If the only senders of this methods are in this test cases can I remove them? If I don't miss anything BlockContext should not be used anymore... Waiting for your comments... Gabriel _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Hi Gabriel
Could you post a list of these methods? Probably it makes sense to copy some of them over to BlockClosure to preserve compatibility for external clients (we had this before, e.g., #argumentCount, IIRC which is used by GLORP or Seaside). Else these tests can be removed. Adrian On Jun 17, 2009, at 02:28 , Gabriel Cotelli wrote: > Hi, > > I'm looking the failing tests... some tests defined in > BlockContextTest > relies on behavior not implemented in BlockClosure (but implemented > in the > old BlockContext)... > > If the only senders of this methods are in this test cases can I > remove > them? > > If I don't miss anything BlockContext should not be used anymore... > > Waiting for your comments... > Gabriel > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Tonight I prepare the list and post it...
On Wed, Jun 17, 2009 at 4:28 AM, Adrian Lienhard <[hidden email]> wrote: Hi Gabriel _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
They are on the wiki in the baseline test page.
Mike On Wednesday, June 17, 2009, Gabriel Cotelli <[hidden email]> wrote: > Tonight I prepare the list and post it... > > On Wed, Jun 17, 2009 at 4:28 AM, Adrian Lienhard <[hidden email]> wrote: > > Hi Gabriel > > Could you post a list of these methods? Probably it makes sense to > copy some of them over to BlockClosure to preserve compatibility for > external clients (we had this before, e.g., #argumentCount, IIRC which > is used by GLORP or Seaside). > > Else these tests can be removed. > > Adrian > > On Jun 17, 2009, at 02:28 , Gabriel Cotelli wrote: > >> Hi, >> >> I'm looking the failing tests... some tests defined in >> BlockContextTest >> relies on behavior not implemented in BlockClosure (but implemented >> in the >> old BlockContext)... >> >> If the only senders of this methods are in this test cases can I >> remove >> them? >> >> If I don't miss anything BlockContext should not be used anymore... >> >> Waiting for your comments... >> Gabriel >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Adrian Lienhard
This is the list of methods missing in BlockClosure but covered by the BlockContextTest:
On Wed, Jun 17, 2009 at 4:28 AM, Adrian Lienhard <[hidden email]> wrote: Hi Gabriel _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
On 17.06.2009, at 21:02, Gabriel Cotelli wrote: > This is the list of methods missing in BlockClosure but covered by > the BlockContextTest: > • copyStack > • bottomContext > • findContextSuchThat: > • tempNamed: > • tempNamed:put: > I don't known if has sense to implement that... > No, I don't think so. These are all related to the stack (thisContext), which used to be the same as the Block: before closures, this was true: (block := [thisContext]) value == block this means, the block object was identical to the context of the block. This is not the case anymore. The expression is false, and the context of the block [thisContext] value class is now a methodcontext, not a blockcontext, nor a bockclosure. The object representing blocks is not a context anymore, but a container that holds the values of the state that is local to the block. Marcus -- Marcus Denker - http://marcusdenker.de PLEIAD Lab - Computer Science Department (DCC) - University of Chile _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by gcotelli
2009/6/17 Gabriel Cotelli <[hidden email]> This is the list of methods missing in BlockClosure but covered by the BlockContextTest: I have no idea, but in my image (Pharo 10342) I see several senders: * copyStack Process>>copyStack * bottomContext ContextPart>>insertSender: Process>>terminate * findContextSuchThat: BlockContext>>activeHome ContextPart>>buttomContext ContextPart>>findSimilarSender ContextPart>>hasContext: ContextPart>>secondFromButtom Exception>>signalerContext MethodContext>>activeHome MethodContext>>activeOuterContext Process>>calleeOf: * tempNamed: * tempNamed:put: Mariano
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |