Blog - clicking on heading of posts to show post+comments

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Blog - clicking on heading of posts to show post+comments

cedreek
I couldn't find a built-in option... except by clicking on comment(s)
which is not obvious to me, so I did that...

PBHtmlView>>renderPost: aPost on: html
        html div
                class: 'post';
                with: [
                        html anchor name: aPost uuid.
                        html anchor
                                goto: (self context structure: aPost);
                                with: [ html heading
                                        level: 1;
                                        with: aPost title].
                        self render: aPost on: html.
                        self renderMeta: aPost on: html ]

Does it worth commiting ? (not sur this is a good practise to
encapsulate an heading in an anchor)

Cédrick


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Blog - clicking on heading of posts to show post+comments

Lukas Renggli-2
> Does it worth commiting ? (not sur this is a good practise to
> encapsulate an heading in an anchor)

Yes, please commit this change. I want that feature as well.

> PBHtmlView>>renderPost: aPost on: html
> html div
> class: 'post';
> with: [
> html anchor name: aPost uuid.
> html anchor
> goto: (self context structure: aPost);
> with: [ html heading
> level: 1;
> with: aPost title].
> self render: aPost on: html.
> self renderMeta: aPost on: html ]

Better put the anchor inside the heading, otherwise the XHTML is  
invalid (heading is a block element, anchor is an inline element).

Cheers,
Lukas

On Jul 23, 2008, at 10:23 , cdrick wrote:

> I couldn't find a built-in option... except by clicking on comment(s)
> which is not obvious to me, so I did that...
>
>
>
> Cédrick
>
>
> _______________________________________________
> SmallWiki, Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki

--
Lukas Renggli
http://www.lukas-renggli.ch



_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Blog - clicking on heading of posts to show post+comments

Damien Pollet
Thanks Cédrick, I wanted that too :)

On Wed, Jul 23, 2008 at 11:12 AM, Lukas Renggli <[hidden email]> wrote:

>> Does it worth commiting ? (not sur this is a good practise to
>> encapsulate an heading in an anchor)
>
> Yes, please commit this change. I want that feature as well.
>
>> PBHtmlView>>renderPost: aPost on: html
>>       html div
>>               class: 'post';
>>               with: [
>>                       html anchor name: aPost uuid.
>>                       html anchor
>>                               goto: (self context structure: aPost);
>>                               with: [ html heading
>>                                       level: 1;
>>                                       with: aPost title].
>>                       self render: aPost on: html.
>>                       self renderMeta: aPost on: html ]
>
> Better put the anchor inside the heading, otherwise the XHTML is
> invalid (heading is a block element, anchor is an inline element).
>
> Cheers,
> Lukas
>
> On Jul 23, 2008, at 10:23 , cdrick wrote:
>
>> I couldn't find a built-in option... except by clicking on comment(s)
>> which is not obvious to me, so I did that...
>>
>>
>>
>> Cédrick
>>
>>
>> _______________________________________________
>> SmallWiki, Magritte, Pier and Related Tools ...
>> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>
>
>
> _______________________________________________
> SmallWiki, Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>



--
Damien Pollet
type less, do more [ | ] http://people.untyped.org/damien.pollet


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Blog - clicking on heading of posts to show post+comments

cedreek
In reply to this post by Lukas Renggli-2
> Better put the anchor inside the heading, otherwise the XHTML is
> invalid (heading is a block element, anchor is an inline element).
>

ok, I knew there was something like that.(Small) problem now is that
the anchor is displayed (underlined) but I guess this is a CSS matter.

Name: Pier-Blog-cb.74
Author: cb
Time: 23 July 2008, 12:14:32 pm
UUID: 5da7f7c1-da4a-1e49-87b8-9c9243cc677f
Ancestors: Pier-Blog-lr.73

-clicking on heading of posts global view bring the post+commment view
-a css should be used to hide the anchor decoration

_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki