Smalltalk › Frameworks & Tools › Magritte, Pier and Related Tools

BookDistribution update & a few minor Book issues report

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

Reza Razavi

BookDistribution update & a few minor Book issues report

Hi Lukas,

I also uploaded *Pier-Setup-razavi_acm_org.80* that fixes a minor
issue with PRBookDistribution. For more info, please see that package
and its comments.

Additionally, I'd like your attention to:
- The fact that * Pier-Book-lr.138* calls in several places
#trimBlanks, specifically in BOLatexWriter and BONote, while my Pharo
image does not contain this method and consequently the execution fails.
- The two other minor issues exposed in an email sent a few days ago,
and reproduced below.

Regards,
Reza

>Date: Tue, 16 Feb 2010 17:47:56 +0100
>To: "Magritte, Pier and Related Tools ..." <[hidden email]>
>From: Reza RAZAVI <[hidden email]>
>Subject: Book navigation rendering issue report
>
>Hi,
>
>After having upgraded to the latest Seaside 3 and Pier 2 packages, I
>encounter a minor issue that could be regenerated as follows:
>1) Evaluate in a workspace "PRBookDistribution new register"
>2) Point to http://localhost:8080/pier/book/table-of-contents
>
>The navigation arrows are not rendered anymore. Instead, appear
>their textual encoding (&rarr and &larr). It is the same for
>non-breaking space that appears as &nbsp (See for example
>http://localhost:8080/pier/book), as well as other codifications like &sect.
>
>Otherwise, I was wondering if in:
> BOLatexWriter >> convertHtmlEntities:
>
>the following:
> copyReplaceAll: '→' with: '<-'
>
>shouldn't be rather:
> copyReplaceAll: '→' with: '->'
>
>Cheers,
>Reza

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Lukas Renggli

Re: BookDistribution update & a few minor Book issues report

> Additionally, I'd like your attention to:
> - The fact that * Pier-Book-lr.138* calls in several places #trimBlanks,
> specifically in BOLatexWriter and BONote, while my Pharo image does not
> contain this method and consequently the execution fails.

Thank you, I've replaced those.

> - The two other minor issues exposed in an email sent a few days ago, and
> reproduced below.

Sorry, I've must have missed that. I've fixed that as well.

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Reza Razavi

Re: BookDistribution update & a few minor Book issues report

At 09:42 21/02/2010, Lukas Renggli wrote:
>I've replaced those.

I integrated them; thank you so much!
Reza

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Reza Razavi

Another minor rendering issue

In reply to this post by Lukas Renggli

At 09:42 21/02/2010, you wrote:
>I've fixed that as well.

Hi Lukas,

Please note that there are other minor rendering
issues since you added PRVerbatim. Here are two examples:
1) I had a blog post with html markups inside as
follows: some text. Before verbatim, I was
getting *some text* in bold as expected. Now, I get some text.

2) In my experimental distribution, I instantiate
a book with the following title in French:

book title: 'Maintien et développement de la qualité de l''enseignement';

Now, if I try to remove the book node, here is what happens:

2.a) *PRRemoveCommand >> confirmation* generates the following wiki string:

'!Do you really want to remove ''Maintien et
développement de la qualité de l''''enseignement''?
There are 8 child structures:
# */book/table-of-contents*
# */book/table-of-figures*
# */book/index*
# */book/introduction*
There is 1 incoming reference:
# */system/menu*
'

2.b) The above wiki text is parsed by
PRDocumentParser, but rendered verbatim, exactly
as above, and is not interpreted (specifically,
the internal links do not appear).

However, the issue disappears when I remove
*l''enseignement* from the title. It is then
certainly related to the double ' in that French word.

Regards,
Reza

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Lukas Renggli

Re: Another minor rendering issue

> Please note that there are other minor rendering issues since you added
> PRVerbatim. Here are two examples:

Could you add tests?

Lukas

> 1) I had a blog post with html markups inside as follows: some text.
> Before verbatim, I was getting *some text* in bold as expected. Now, I get
> some text.
>
> 2) In my experimental distribution, I instantiate a book with the following
> title in French:
>
> book title: 'Maintien et développement de la qualité de l''enseignement';
>
> Now, if I try to remove the book node, here is what happens:
>
> 2.a) *PRRemoveCommand >> confirmation* generates the following wiki string:
>
> '!Do you really want to remove ''Maintien et développement de la qualité de
> l''''enseignement''?
> There are 8 child structures:
> # */book/table-of-contents*
> # */book/table-of-figures*
> # */book/index*
> # */book/introduction*
> There is 1 incoming reference:
> # */system/menu*
> '
>
> 2.b) The above wiki text is parsed by PRDocumentParser, but rendered
> verbatim, exactly as above, and is not interpreted (specifically, the
> internal links do not appear).
>
> However, the issue disappears when I remove *l''enseignement* from the
> title. It is then certainly related to the double ' in that French word.
>
> Regards,
> Reza
>
>
> _______________________________________________
> Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Lukas Renggli

Re: Another minor rendering issue

In reply to this post by Reza Razavi

> Please note that there are other minor rendering issues since you added
> PRVerbatim. Here are two examples:

Sorry, I thought you were referring to some bugs in the parser, I
should properly read the mail first before answering.

> 1) I had a blog post with html markups inside as follows: some text.
> Before verbatim, I was getting *some text* in bold as expected. Now, I get
> some text.

That's the expected behavior. If you want HTML tags in your code you
need to put it inside a verbatim part. Mixing HTML with wiki is
problematic, because it destroys the independence of the output
format. This is especially problematic for Pier-Book, for example.

To get bold text you should use the markup ""some text"", not the HTML tags.

> 2) In my experimental distribution, I instantiate a book with the following
> title in French:
>
> book title: 'Maintien et développement de la qualité de l''enseignement';
>
> Now, if I try to remove the book node, here is what happens:
>
> 2.a) *PRRemoveCommand >> confirmation* generates the following wiki string:
>
> '!Do you really want to remove ''Maintien et développement de la qualité de
> l''''enseignement''?
> There are 8 child structures:
> # */book/table-of-contents*
> # */book/table-of-figures*
> # */book/index*
> # */book/introduction*
> There is 1 incoming reference:
> # */system/menu*
> '
>
> 2.b) The above wiki text is parsed by PRDocumentParser, but rendered
> verbatim, exactly as above, and is not interpreted (specifically, the
> internal links do not appear).
>
> However, the issue disappears when I remove *l''enseignement* from the
> title. It is then certainly related to the double ' in that French word.

Ok, that was a stupid hack. I'll fix that.

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Reza Razavi

Re: Another minor rendering issue

At 11:44 21/02/2010, Lukas Renggli wrote:
>Mixing HTML with wiki is
>problematic, because it destroys the independence of the output
>format.
[...]
>To get bold text you should use the markup ""some text"", not the HTML tags.

Sure, but in that case I wouldn't have encountered that issue, and
consequently learnt the above interesting point -:)

>I'll fix that.

Already integrated, and tested; many thanks again!

BTW, may I ask you considering the integration of the following minor
change into your code base:

PRListWidget >> renderContentOn: html
| items |
items := self items.
items isEmpty
ifFalse: [ self renderItems: "self" items on: html ]

It just avoids computing twice the items list, and would allow me
removing this from my patch list.

Regards,
Reza

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Lukas Renggli

Re: Another minor rendering issue

> BTW, may I ask you considering the integration of the following minor change
> into your code base:
>
> PRListWidget >> renderContentOn: html
> | items |
> items := self items.
> items isEmpty
> ifFalse: [ self renderItems: "self" items on: html ]
>
> It just avoids computing twice the items list, and would allow me removing
> this from my patch list.

Ahh, thanks for spotting that.

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki