BrowserEnvironment>>forPackages: aCollection

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

BrowserEnvironment>>forPackages: aCollection

Fernando olivero
Lukas, i've noticed that PackageEnvironment instance variable packages is an ordered collection.

Could we make it a Set, so when iterating we reduce iterating the same packages twice,

Of course just in case a duplicated package was passed as an argument ( which was my case!!!!)
Which leads to iterate possibly multiple times through the classes of packages, which significantly increases time to run when using the whole system.

Fernando
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: BrowserEnvironment>>forPackages: aCollection

Lukas Renggli
Sure, that seems to be a good idea:

Name: Refactoring-Core-lr.123
Author: lr
Time: 12 April 2010, 3:28:11 pm
UUID: e30a9d78-bd6e-4da0-9d85-ba99270925a4
Ancestors: Refactoring-Core-lr.122

- made packages a set

On 12 April 2010 15:15, Fernando olivero <[hidden email]> wrote:

> Lukas, i've noticed that PackageEnvironment instance variable packages is an ordered collection.
>
> Could we make it a Set, so when iterating we reduce iterating the same packages twice,
>
> Of course just in case a duplicated package was passed as an argument ( which was my case!!!!)
> Which leads to iterate possibly multiple times through the classes of packages, which significantly increases time to run when using the whole system.
>
> Fernando
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project