Smalltalk › Cincom › VisualWorks

[Bug] DataSet omitting lines (with patch)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Christian Haider

[Bug] DataSet omitting lines (with patch)

Hi all, hi Cincom UI guys,

When you have a DataSet, colorize the background of cells and want to get rid of horizontal or vertical lines or both, the result is rather disappointing (left column of the attached PDF). The attached DatasetCellMarginsDemo parcel has the code for that.

The problem is easy to fix (patch in attached .st file) as can be seen in the right column of the PDF.

The real problem and question is if Cincom will fix this before the end of time… (since the Grid is not getting anywhere, maybe Cincom will consider giving the DataSet a little bit of TLC).

(long rant about Widgetry, the Grid and UI in general deleted…)

Hope dies last…

Christian

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

DatasetLinePatch.pdf (106K) Download Attachment

DatasetCellMarginsDemo.zip (6K) Download Attachment

DataSetPatch.st (3K) Download Attachment

Niall Ross

Re: [Bug] DataSet omitting lines (with patch)

Dear Christian,
unfortunately, AR 63129 (DataSetView cheats with child view, results
in things drawing with isEnabled == false) replaced the RowVisual class
with RowVisualComposite which contains all its row cells as components
rather than creating the visuals and throwing them away (so now the
DataSetView is a parent container of RowVisualComposite).
RowLabelVisual is similarly replaced with RowLabelVisualComposite. Thus
the patch no longer works as is.

If you can port it to a recent 7.9 dev (anything later than mid-July
when this change went in - today's build is the most recent and will
likely be up by the time you read this), that would be fine, as your
demo package shows the problem still exists in 7.9.

Yours faithfully
Niall Ross

>Hi all, hi Cincom UI guys,
>
>
>
>When you have a DataSet, colorize the background of cells and want to
>get rid of horizontal or vertical lines or both, the result is rather
>disappointing (left column of the attached PDF). The attached
>DatasetCellMarginsDemo parcel has the code for that.
>
>
>
>The problem is easy to fix (patch in attached .st file) as can be seen
>in the right column of the PDF.
>
>
>
>The real problem and question is if Cincom will fix this before the end
>of time... (since the Grid is not getting anywhere, maybe Cincom will
>consider giving the DataSet a little bit of TLC).
>
>
>
>(long rant about Widgetry, the Grid and UI in general deleted...)
>
>
>
>Hope dies last...
>
> Christian
>
>
>
>
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>vwnc mailing list
>[hidden email]
>http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
>
>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Maarten Mostert

Re: [Bug] DataSet omitting lines (with patch)

"Niall Ross" <[hidden email]> said:

> Dear Christian,

> likely be up by the time you read this), that would be fine,

You're allowed to read excellent ....

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Christian Haider

Re: [Bug] DataSet omitting lines (with patch)

In reply to this post by Niall Ross

??? I don’t get it. What do you mean, Maarten?

I downloaded the newest build and checking it out – hang on.

I am also preparing a posting about the UI state of affairs… I think it is time for a bit of discussion about this.

Von: [hidden email] [mailto:[hidden email]]
Gesendet: Samstag, 3. Dezember 2011 10:45
An: Niall Ross
Cc: Christian Haider; [hidden email]
Betreff: Re: [vwnc] [Bug] DataSet omitting lines (with patch)

"Niall Ross" <[hidden email]> said:

> Dear Christian,

> likely be up by the time you read this), that would be fine,

You're allowed to read excellent ....

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Maarten Mostert

Re: [Bug] DataSet omitting lines (with patch)

That it would be excellent that you get this integrated within the latest build !

Maarten Mostert
T:+33673079413

Change does not necessarily assure progress, but progress implacably requires change. -Henry Steele Commager

From: "Christian Haider" <[hidden email]>

Date: Sat, 3 Dec 2011 13:16:38 +0100

To: <[hidden email]>; Niall Ross<[hidden email]>

Cc: <[hidden email]>

Subject: AW: [vwnc] [Bug] DataSet omitting lines (with patch)

??? I don’t get it. What do you mean, Maarten?

I downloaded the newest build and checking it out – hang on.

I am also preparing a posting about the UI state of affairs… I think it is time for a bit of discussion about this.

"Niall Ross" <[hidden email]> said:

> Dear Christian,

> likely be up by the time you read this), that would be fine,

You're allowed to read excellent ....

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Christian Haider

Re: [Bug] DataSet omitting lines (with patch)

In reply to this post by Christian Haider

Dear Niall,

Thanks for taking notice!
I downloaded that build (which came while I was reading your reply :-) ) and looked around.

The patch is actually simpler, because the method I extracted as #elementBoxInsetForLines is now extracted as #cellInset. The patch is just the right implementation for this method (plus subclass redefinition).

It is good to see that at least a bit of work goes into the UI...

Do you mind me asking why it is necessary to copy the graphics context for the display of each cell (see RowVisualComposite>>displayOn:)? Was that not generally agreed to be really bad practice?

I would be glad if this could be integrated.

Thanks,
Christian

> -----Ursprüngliche Nachricht-----
> Von: Niall Ross [mailto:[hidden email]]
> Gesendet: Freitag, 2. Dezember 2011 19:31
> An: Christian Haider
> Cc: [hidden email]
> Betreff: Re: [vwnc] [Bug] DataSet omitting lines (with patch)
>
> Dear Christian,
> unfortunately, AR 63129 (DataSetView cheats with child view, results in
> things drawing with isEnabled == false) replaced the RowVisual class with
> RowVisualComposite which contains all its row cells as components rather
> than creating the visuals and throwing them away (so now the DataSetView
> is a parent container of RowVisualComposite).
> RowLabelVisual is similarly replaced with RowLabelVisualComposite. Thus
> the patch no longer works as is.
>
> If you can port it to a recent 7.9 dev (anything later than mid-July when this
> change went in - today's build is the most recent and will likely be up by the
> time you read this), that would be fine, as your demo package shows the
> problem still exists in 7.9.
>
> Yours faithfully
> Niall Ross
>
> >Hi all, hi Cincom UI guys,
> >
> >
> >
> >When you have a DataSet, colorize the background of cells and want to
> >get rid of horizontal or vertical lines or both, the result is rather
> >disappointing (left column of the attached PDF). The attached
> >DatasetCellMarginsDemo parcel has the code for that.
> >
> >
> >
> >The problem is easy to fix (patch in attached .st file) as can be seen
> >in the right column of the PDF.
> >
> >
> >
> >The real problem and question is if Cincom will fix this before the end
> >of time... (since the Grid is not getting anywhere, maybe Cincom will
> >consider giving the DataSet a little bit of TLC).
> >
> >
> >
> >(long rant about Widgetry, the Grid and UI in general deleted...)
> >
> >
> >
> >Hope dies last...
> >
> > Christian
> >
> >
> >
> >
> >
> >
> >-----------------------------------------------------------------------
> >-
> >
> >_______________________________________________
> >vwnc mailing list
> >[hidden email]
> >http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
> >
> >
>
>
>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

RowVisualComposite-cellInset.st (1K) Download Attachment