[Bug] EncodedStream>>contents

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug] EncodedStream>>contents

Christian Haider
Nachricht
A bug found me during packaging:
 
wst := (ByteArray new withEncoding: #ASCII) writeStream.
wst nextPutAll: 'Hello World!'.
wst contents
 
yields an empty ByteString in the vanilla image.
 
But, if you load [Wave-Server-Base], you get an override of the method which fixes the bug...
I think the fix should be in the base.
 
My runtime does not include Wave, thats how it hit me - Just an example how overrides can lead to tricky bugs :-(
Reply | Threaded
Open this post in threaded view
|

RE: [Bug] EncodedStream>>contents

Boris Popov, DeepCove Labs (SNN)
Heh, I found the same problem last fall when I changed how we build images
from scratch and forgot to include Wave, which we used to have only in our
dev images, but not runtimes :) I recall it wasn't easy to find either... I
say the fix should be in base, it's a radically different behavior and
should be consolidated at some point.

Cheers!

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message
header. Unless otherwise indicated, it contains information that is
private and confidential. If you have received it in error, please
notify the sender and delete the entire message including any
attachments.

Thank you.

-----Original Message-----
From: Christian Haider [mailto:[hidden email]]
Sent: Sunday, March 05, 2006 7:24 AM
To: 'VWNC List'
Subject: [Bug] EncodedStream>>contents

A bug found me during packaging:
 
wst := (ByteArray new withEncoding: #ASCII) writeStream.
wst nextPutAll: 'Hello World!'.
wst contents
 
yields an empty ByteString in the vanilla image.
 
But, if you load [Wave-Server-Base], you get an override of the method which
fixes the bug...
I think the fix should be in the base.
 
My runtime does not include Wave, thats how it hit me - Just an example how
overrides can lead to tricky bugs :-(

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: [Bug] EncodedStream>>contents

Alan Knight-2
Yes, that seems reasonable, although that fix isn't very general.

At 02:24 PM 3/5/2006, Boris Popov wrote:

>Heh, I found the same problem last fall when I changed how we build images
>from scratch and forgot to include Wave, which we used to have only in our
>dev images, but not runtimes :) I recall it wasn't easy to find either... I
>say the fix should be in base, it's a radically different behavior and
>should be consolidated at some point.
>
>Cheers!
>
>-Boris
>
>--
>+1.604.689.0322
>DeepCove Labs Ltd.
>4th floor 595 Howe Street
>Vancouver, Canada V6C 2T5
>
>[hidden email]
>
>CONFIDENTIALITY NOTICE
>
>This email is intended only for the persons named in the message
>header. Unless otherwise indicated, it contains information that is
>private and confidential. If you have received it in error, please
>notify the sender and delete the entire message including any
>attachments.
>
>Thank you.
>
>-----Original Message-----
>From: Christian Haider [mailto:[hidden email]]
>Sent: Sunday, March 05, 2006 7:24 AM
>To: 'VWNC List'
>Subject: [Bug] EncodedStream>>contents
>
>A bug found me during packaging:
>
>wst := (ByteArray new withEncoding: #ASCII) writeStream.
>wst nextPutAll: 'Hello World!'.
>wst contents
>
>yields an empty ByteString in the vanilla image.
>
>But, if you load [Wave-Server-Base], you get an override of the method which
>fixes the bug...
>I think the fix should be in the base.
>
>My runtime does not include Wave, thats how it hit me - Just an example how
>overrides can lead to tricky bugs :-(

--
Alan Knight [|], Cincom Smalltalk Development
[hidden email]
[hidden email]
http://www.cincom.com/smalltalk

"The Static Typing Philosophy: Make it fast. Make it right. Make it run." - Niall Ross