Bug and fix?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug and fix?

Sebastián Sastre
Hi all,
 
    I'm making a little online application and as base I'm using the seaside image that one can download from here:
 
    Working with that image I found this method:
 
WAHtmlRenderer>>labelledRowForList: aCollection on: aSymbol of: anObject
 self tableRowWithLabel: (anObject labelForSelector: aSymbol of: anObject) column:
  [self
   selectFromList: aCollection
   selected: (anObject perform: aSymbol)
   callback: (self callbackForSelector: aSymbol of: anObject)]
 
    wich fails with a DNU of #labelForSelector:of: sent to anObject.
 
    So I've changed it to
 
WAHtmlRenderer>>labelledRowForList: aCollection on: aSymbol of: anObject
 self tableRowWithLabel: (anObject labelForSelector: aSymbol) column:
  [self
   selectFromList: aCollection
   selected: (anObject perform: aSymbol)
   callback: (self callbackForSelector: aSymbol of: anObject)]
 
    and it works.
 
    Regards,
 
Sebastian

_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: Bug and fix?

Michel Bany-3

>  
>     So I've changed it to
>  
> WAHtmlRenderer>>labelledRowForList: aCollection on: aSymbol of: anObject
>  self tableRowWithLabel: (anObject labelForSelector: aSymbol) column:
>   [self
>    selectFromList: aCollection
>    selected: (anObject perform: aSymbol)
>    callback: (self callbackForSelector: aSymbol of: anObject)]

Yes, but I think the author's intention was more something like this :

 self tableRowWithLabel: (self labelForSelector: aSymbol) column:
  [self
   selectFromList: aCollection
   selected: (anObject perform: aSymbol)
   callback: (self callbackForSelector: aSymbol of: anObject)]

Michel.


_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside