Bug fix to review for Summer Release

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug fix to review for Summer Release

Sean P. DeNigris
Administrator
Please someone take <<5 min to review this fix so we can avoid ugly DNUs in our release...

Issue 6303: [BUG]: Completion DNU in Inspector/Object Explorer for 1.4
http://code.google.com/p/pharo/issues/detail?id=6303
Status: FixReviewNeeded

To reproduce:
1. DoIt: "Morph new explore"
2. In the bottom pane of the explorer, type "bounds s"

You will get a DNU #guessTypeForName:

Fix in inbox: Name: SLICE-Issue-6303-BUG-Completion-DNU-in-InspectorObject-Explorer-for-14-SeanDeNigris.1

Implement very basic #guessTypeForName: in ObjectExplorer and Inspector to avoid DNUs during code completion
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Bug fix to review for Summer Release

Sean P. DeNigris
Administrator
Sean P. DeNigris wrote
Please someone take <<5 min to review this fix
Here's another easy one:
Issue 6305: StartupPreferences "run once" broken
Status: FixReviewNeeded
Type-Bug
Milestone-1.4

Pharo1.4
Latest update: #14451

Fix in inbox: SLICE-Issue-6305-StartupPreferences-run-once-broken-SeanDeNigris.1

Port StartupAction>>execute from Pharo 2.0, which seems to be working.

Manually tested in 1.4 with:
        | item1 item2 |
        item1 := StartupAction name: 'Open Help' code: 'Workspace openContents: ''Here is just an example of how to use the StartupLoader.
I should only be displayed once.
       
 You can also see StartupLoader class>>#example'' label: ''Help''' runOnce: true.
        item2 := StartupAction name: 'Open Workspace' code:  [ Workspace openContents: 'I should be displayed each time' ].
" StartupLoader default addAtStartup: {item1. item2}."
        FileLocator imageDirectory ensureDirectory / StartupLoader default startupScriptName fileStreamDo: [ :str |
                str nextPutAll: (StartupLoader default buildStreamFor: {item1. item2}) ].
       
        StartupLoader default loadStartupScript.
        StartupLoader default loadStartupScript.
Cheers,
Sean