Smalltalk › Instantiations

Bug in AbtGenericPropertiesView>>defaults:clientData:callData:

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

Gabriel Cotelli

Bug in AbtGenericPropertiesView>>defaults:clientData:callData:

Hi,

I found the following bug:

AbtGenericPropertiesView>>defaults: aWidget clientData: clientData callData: callData
"Process the Defaults button."

self propertiesTablePart cancelEdit
self updateOperation notNil
ifTrue:
[self updateOperation cancel.
self startNewUpdateOperation].

should be:

AbtGenericPropertiesView>>defaults: aWidget clientData: clientData callData: callData
"Process the Defaults button."

self propertiesTablePart cancelEdit.
self updateOperation notNil
ifTrue:
[self updateOperation cancel.
self startNewUpdateOperation].

(Just a missing dot after cancelEdit send). I detected this running a code analysis test so I have no idea how to reproduce the error.

Regards,

Gabriel

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/OcgRq6Japq8J.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.

Thomas Koschate-2

Re: Bug in AbtGenericPropertiesView>>defaults:clientData:callData:

Looking a little more closely, the view is never a receiver of this message, so reproducing it will be just about impossible. The method needs to be removed from the class. Of course, since the bug has been there since 1996, it's hardly a critical issue.

Tom

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/aW0SmlIRqlsJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.