Bug in MailA

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
bpi
Reply | Threaded
Open this post in threaded view
|

Bug in MailA

bpi
Hi,

The following code goes into an endless loop:
MailAddressParser addressesIn: 'romeo&[hidden email]

It’s because of the ampersand. The fix is trivial, because the bug just was a typo.

Fix and test are in the Pharo50Inbox:
Network-Mail-BernhardPieber.46.mcz
Network-Tests-BernhardPieber.14.mcz

Cheers,
Bernhard



Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

Ben Coman
On Sun, Jul 3, 2016 at 3:16 AM, Bernhard Pieber <[hidden email]> wrote:

> Hi,
>
> The following code goes into an endless loop:
> MailAddressParser addressesIn: 'romeo&[hidden email]
>
> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>
> Fix and test are in the Pharo50Inbox:
> Network-Mail-BernhardPieber.46.mcz
> Network-Tests-BernhardPieber.14.mcz
>
> Cheers,
> Bernhard
>
>
>

Thanks Bernhard.
Can you log an issue for it on
and submit this in Slice format.
Instructions at http://pharo.org/contribute-propose-fix
This makes it easier to review and the integration system only works
with Slices & Configurations.

cheers -ben

Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

stepharo
In reply to this post by bpi
Thanks Bernhard

- can you open a bug entry?

- publish a slice? (press slice + bug number)

Our integration tool and process work this way

Stef

Le 2/7/16 à 21:16, Bernhard Pieber a écrit :

> Hi,
>
> The following code goes into an endless loop:
> MailAddressParser addressesIn: 'romeo&[hidden email]
>
> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>
> Fix and test are in the Pharo50Inbox:
> Network-Mail-BernhardPieber.46.mcz
> Network-Tests-BernhardPieber.14.mcz
>
> Cheers,
> Bernhard
>
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

Ben Coman
In reply to this post by Ben Coman
On Sun, Jul 3, 2016 at 6:08 AM, Ben Coman <[hidden email]> wrote:

> On Sun, Jul 3, 2016 at 3:16 AM, Bernhard Pieber <[hidden email]> wrote:
>> Hi,
>>
>> The following code goes into an endless loop:
>> MailAddressParser addressesIn: 'romeo&[hidden email]
>>
>> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>>
>> Fix and test are in the Pharo50Inbox:
>> Network-Mail-BernhardPieber.46.mcz
>> Network-Tests-BernhardPieber.14.mcz
>>
>> Cheers,
>> Bernhard
>>
>>
>>
>
> Thanks Bernhard.
> Can you log an issue for it on
> and submit this in Slice format.
> Instructions at http://pharo.org/contribute-propose-fix
> This makes it easier to review and the integration system only works
> with Slices & Configurations.
>
> cheers -ben

P.S. Once your Slice is integrated, see instructions at the bottom of
[1] to get yourself added to the contributors page.
[1] http://pharo.org/about

cheers -ben

bpi
Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

bpi
In reply to this post by Ben Coman
Done!

Cheers,
Bernhard

> Am 03.07.2016 um 00:08 schrieb Ben Coman <[hidden email]>:
>
> On Sun, Jul 3, 2016 at 3:16 AM, Bernhard Pieber <[hidden email]> wrote:
>> Hi,
>>
>> The following code goes into an endless loop:
>> MailAddressParser addressesIn: 'romeo&[hidden email]
>>
>> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>>
>> Fix and test are in the Pharo50Inbox:
>> Network-Mail-BernhardPieber.46.mcz
>> Network-Tests-BernhardPieber.14.mcz
>>
>> Cheers,
>> Bernhard
>
> Thanks Bernhard.
> Can you log an issue for it on
> and submit this in Slice format.
> Instructions at http://pharo.org/contribute-propose-fix
> This makes it easier to review and the integration system only works
> with Slices & Configurations.
>
> cheers -ben


bpi
Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

bpi
In reply to this post by stepharo
I wonder about the process for fixes for Pharo 4.0? Is it the same? If I’d put the equivalent fix into the Pharo40Inbox, would it be integrated?

Cheers,
Bernhard

> Am 03.07.2016 um 08:46 schrieb stepharo <[hidden email]>:
>
> Thanks Bernhard
>
> - can you open a bug entry?
>
> - publish a slice? (press slice + bug number)
>
> Our integration tool and process work this way
>
> Stef
>
> Le 2/7/16 à 21:16, Bernhard Pieber a écrit :
>> Hi,
>>
>> The following code goes into an endless loop:
>> MailAddressParser addressesIn: 'romeo&[hidden email]
>>
>> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>>
>> Fix and test are in the Pharo50Inbox:
>> Network-Mail-BernhardPieber.46.mcz
>> Network-Tests-BernhardPieber.14.mcz


Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

Sven Van Caekenberghe-2
In reply to this post by bpi
Thank you.

> On 03 Jul 2016, at 13:25, Bernhard Pieber <[hidden email]> wrote:
>
> Done!
>
> Cheers,
> Bernhard
>
>> Am 03.07.2016 um 00:08 schrieb Ben Coman <[hidden email]>:
>>
>> On Sun, Jul 3, 2016 at 3:16 AM, Bernhard Pieber <[hidden email]> wrote:
>>> Hi,
>>>
>>> The following code goes into an endless loop:
>>> MailAddressParser addressesIn: 'romeo&[hidden email]
>>>
>>> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>>>
>>> Fix and test are in the Pharo50Inbox:
>>> Network-Mail-BernhardPieber.46.mcz
>>> Network-Tests-BernhardPieber.14.mcz
>>>
>>> Cheers,
>>> Bernhard
>>
>> Thanks Bernhard.
>> Can you log an issue for it on
>> and submit this in Slice format.
>> Instructions at http://pharo.org/contribute-propose-fix
>> This makes it easier to review and the integration system only works
>> with Slices & Configurations.
>>
>> cheers -ben
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

Ben Coman
In reply to this post by bpi
On Sun, Jul 3, 2016 at 7:25 PM, Bernhard Pieber <[hidden email]> wrote:
> Done!

Thanks Bernhard, but I can't find the issue in the tracker. Can you
paste a link?


On Sun, Jul 3, 2016 at 7:41 PM, Bernhard Pieber <[hidden email]> wrote:
> I wonder about the process for fixes for Pharo 4.0? Is it the same? If I’d put the equivalent fix into the Pharo40Inbox, would it be integrated?

I am not familiar with the release process, but apparently there is a
fair amount of manual work to do each release.  Typically it seems
each major release is followed by one minor point release about 6
months later.  So 4.0 is probably too far back for another release.

It would be good however if there was some community process to manage
fixes for very old releases.  Perhaps there could be a tag like
"Pharo4-hotfix" in Fogbugz, so users of their own accord could search
for community fixes contributed long after the main development focus
has moved on - to be used at own risk.  This might provide better
sustainability for older releases without drawing resources from the
latest version.  That is, Pharo 4.0 users would need to rely on review
by other Pharo 4.0 user to review and promote their fixes to "hotfix"
- but at least the Fogbugz facilitates the collaboration.  This might
also work for 5.0 fixes as a state between Work Needed and Closed Fix
Integrated while they are waiting to be rolled up into the point
release.

cheers -ben

>
> Cheers,
> Bernhard
>
>> Am 03.07.2016 um 08:46 schrieb stepharo <[hidden email]>:
>>
>> Thanks Bernhard
>>
>> - can you open a bug entry?
>>
>> - publish a slice? (press slice + bug number)
>>
>> Our integration tool and process work this way
>>
>> Stef
>>
>> Le 2/7/16 à 21:16, Bernhard Pieber a écrit :
>>> Hi,
>>>
>>> The following code goes into an endless loop:
>>> MailAddressParser addressesIn: 'romeo&[hidden email]
>>>
>>> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>>>
>>> Fix and test are in the Pharo50Inbox:
>>> Network-Mail-BernhardPieber.46.mcz
>>> Network-Tests-BernhardPieber.14.mcz
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

Marcus Denker-4
In reply to this post by bpi

On 03 Jul 2016, at 13:41, Bernhard Pieber <[hidden email]> wrote:

I wonder about the process for fixes for Pharo 4.0? Is it the same? If I’d put the equivalent fix into the Pharo40Inbox, would it be integrated?


I have added a forward port issue for Pharo6:


For Pharo4: we decided in the past that we maintain the current stable and actively push the “development” version.
(This is Pharo5 and Pharo6). 

For maintaining older versions I definitely can’t do that… not that I don’t want, but I just can’t. (Time and energy is not
sufficient).

Marcus
Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

EstebanLM
In reply to this post by Ben Coman
Hi,

On 03 Jul 2016, at 15:59, Ben Coman <[hidden email]> wrote:

On Sun, Jul 3, 2016 at 7:25 PM, Bernhard Pieber <[hidden email]> wrote:
Done!

Thanks Bernhard, but I can't find the issue in the tracker. Can you
paste a link?


On Sun, Jul 3, 2016 at 7:41 PM, Bernhard Pieber <[hidden email]> wrote:
I wonder about the process for fixes for Pharo 4.0? Is it the same? If I’d put the equivalent fix into the Pharo40Inbox, would it be integrated?

I am not familiar with the release process, but apparently there is a
fair amount of manual work to do each release.  Typically it seems
each major release is followed by one minor point release about 6
months later.  So 4.0 is probably too far back for another release.

yes, this is like that… too far away and our process is: we maintain current stable and we develop in alpha.
Of course, we know some people will take some time to migrate until new stables (if they migrate at all), but we considered this kind of work is far from our capabilities. However, we create PharoPro precisely to assist in this kind of issues: http://consortium.pharo.org/web/pharopro
but yes, this is not free because we need to spend time on it (also, is a way we have to continue sustaining pharo progress :P)

cheers, 
Esteban


It would be good however if there was some community process to manage
fixes for very old releases.  Perhaps there could be a tag like
"Pharo4-hotfix" in Fogbugz, so users of their own accord could search
for community fixes contributed long after the main development focus
has moved on - to be used at own risk.  This might provide better
sustainability for older releases without drawing resources from the
latest version.  That is, Pharo 4.0 users would need to rely on review
by other Pharo 4.0 user to review and promote their fixes to "hotfix"
- but at least the Fogbugz facilitates the collaboration.  This might
also work for 5.0 fixes as a state between Work Needed and Closed Fix
Integrated while they are waiting to be rolled up into the point
release.

cheers -ben


Cheers,
Bernhard

Am 03.07.2016 um 08:46 schrieb stepharo <[hidden email]>:

Thanks Bernhard

- can you open a bug entry?

- publish a slice? (press slice + bug number)

Our integration tool and process work this way

Stef

Le 2/7/16 à 21:16, Bernhard Pieber a écrit :
Hi,

The following code goes into an endless loop:
MailAddressParser addressesIn: '[hidden email]

It’s because of the ampersand. The fix is trivial, because the bug just was a typo.

Fix and test are in the Pharo50Inbox:
Network-Mail-BernhardPieber.46.mcz
Network-Tests-BernhardPieber.14.mcz




Reply | Threaded
Open this post in threaded view
|

Re: Bug in MailA

stepharo
In reply to this post by bpi
tx Bernhard!
Le 3/7/16 à 13:25, Bernhard Pieber a écrit :

> Done!
>
> Cheers,
> Bernhard
>
>> Am 03.07.2016 um 00:08 schrieb Ben Coman <[hidden email]>:
>>
>> On Sun, Jul 3, 2016 at 3:16 AM, Bernhard Pieber <[hidden email]> wrote:
>>> Hi,
>>>
>>> The following code goes into an endless loop:
>>> MailAddressParser addressesIn: 'romeo&[hidden email]
>>>
>>> It’s because of the ampersand. The fix is trivial, because the bug just was a typo.
>>>
>>> Fix and test are in the Pharo50Inbox:
>>> Network-Mail-BernhardPieber.46.mcz
>>> Network-Tests-BernhardPieber.14.mcz
>>>
>>> Cheers,
>>> Bernhard
>> Thanks Bernhard.
>> Can you log an issue for it on
>> and submit this in Slice format.
>> Instructions at http://pharo.org/contribute-propose-fix
>> This makes it easier to review and the integration system only works
>> with Slices & Configurations.
>>
>> cheers -ben
>
>