Bug in OSProcess>>unregisterChildProcess?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug in OSProcess>>unregisterChildProcess?

Herbert König
Hi,

shouldn't UnixProcess>>unregisterChildProcess:
removeKey: anOSProcess pid
instead of:
removeKey: self pid?

There are no senders of this message but at least with this change I can
get rid of the instances of ExternalUnixOSProcess my problem from my
other post.

Which still leaves the question if reusing one ExternalUnixOSProcess
would be more appropriate.

Cheers,

Herbert

Reply | Threaded
Open this post in threaded view
|

Re: Bug in OSProcess>>unregisterChildProcess?

David T. Lewis
Hi Herbert,

Yes for sure, that is a bug. Thanks for finding it. I'll fix it as soon as
I get home tonight.

Dave

> Hi,
>
> shouldn't UnixProcess>>unregisterChildProcess:
> removeKey: anOSProcess pid
> instead of:
> removeKey: self pid?
>
> There are no senders of this message but at least with this change I can
> get rid of the instances of ExternalUnixOSProcess my problem from my
> other post.
>
> Which still leaves the question if reusing one ExternalUnixOSProcess
> would be more appropriate.
>
> Cheers,
>
> Herbert
>



Reply | Threaded
Open this post in threaded view
|

Re: Bug in OSProcess>>unregisterChildProcess?

David T. Lewis
In reply to this post by Herbert König
On Tue, Feb 03, 2015 at 06:12:02PM +0100, Herbert K??nig wrote:
> Hi,
>
> shouldn't UnixProcess>>unregisterChildProcess:
> removeKey: anOSProcess pid
> instead of:
> removeKey: self pid?

Thanks Herbert,

I just added your fix to the OSProcess repository.

Dave