Bug in Open Workspace from File-Browser?
Locked
 
|
The File Browser has a Context Menu "Workspace with Contents". It opens
an Edit Window (String Morph), but not a Workspace ... Is the Menu-Title wrong or the implementation? BW, Volkert |
|
|
Or do we now want such to open in Playground?
btw, these are the relevant methods. FileList>>FileList>>viewContentsInWorkspace FileList>>viewContentsInWorkspace cheers -ben On Wed, Jun 3, 2015 at 6:57 PM, volkert <[hidden email]> wrote: > The File Browser has a Context Menu "Workspace with Contents". It opens an > Edit Window (String Morph), but not a Workspace ... > > Is the Menu-Title wrong or the implementation? > > BW, > Volkert > |
|
|
Is this change resonable. I have no idea, what the Design-Idea
behind the UIManager what services is should provide. May be it make
sense to have the extra services on UIManager, but think the bug is
in FileList>>viewContentsInWorkspace and not in UIManager.
---- I propose for Workspace to change the current code: FileList>>viewContentsInWorkspace "View the contents of my selected file in a new workspace" | aString | self reference streamWritable: false do: [ :stream| aString := stream setConverterForCode contentsOfEntireFile ]. UIManager default edit: aString label: 'Workspace from ', self reference basename <----- WRONG to : FileList>>viewContentsInWorkspace "View the contents of my selected file in a new workspace" | aString | self reference streamWritable: false do: [ :stream| aString := stream setConverterForCode contentsOfEntireFile ]. Workspace openContents: aString label: 'Workspace from ', self reference basename And i also proposse the add a Playground case. New Method: FileList>>viewContentsInPlayground "View the contents of my selected file in a new playground" | aString | self reference streamWritable: false do: [ :stream| aString := stream setConverterForCode contentsOfEntireFile ]. GTPlayground openContents: aString label: 'Playground from ', self reference basename. and also FileList>>serviceViewContentsInPlayground and the case in ListList>>itemsForAnyFile. If ok, i can fix Workspace and add Playground menu to FileList, after i have figured out how to send an fix ;-) BW, Volkert Am 03.06.2015 um 16:40 schrieb Ben
Coman:
Or do we now want such to open in Playground? btw, these are the relevant methods. FileList>>FileList>>viewContentsInWorkspace FileList>>viewContentsInWorkspace cheers -ben On Wed, Jun 3, 2015 at 6:57 PM, volkert [hidden email] wrote:The File Browser has a Context Menu "Workspace with Contents". It opens an Edit Window (String Morph), but not a Workspace ... Is the Menu-Title wrong or the implementation? BW, Volkert |
|
|
I have opened a new case: https://pharo.fogbugz.com/f/cases/15711/
Am 06.06.2015 um 16:37 schrieb volkert:
Is this change resonable. I have no idea, what the Design-Idea behind the UIManager what services is should provide. May be it make sense to have the extra services on UIManager, but think the bug is in FileList>>viewContentsInWorkspace and not in UIManager. |
|
|
In reply to this post by volkert-2
On Sat, Jun 6, 2015 at 10:37 PM, volkert
<[hidden email]> wrote: > Is this change resonable. I have no idea, what the Design-Idea behind the > UIManager what services is should provide. Sorry I can't comment. I'm not familiar with the design intent. cheers -ben > May be it make sense to have the > extra services on UIManager, but think the bug is in > FileList>>viewContentsInWorkspace and not in UIManager. > > ---- > I propose for Workspace to change the current code: > > FileList>>viewContentsInWorkspace > "View the contents of my selected file in a new workspace" > | aString | > self reference streamWritable: false do: [ :stream| > aString := stream setConverterForCode contentsOfEntireFile ]. > UIManager default edit: aString label: 'Workspace from ', self reference > basename <----- WRONG > > to : > > FileList>>viewContentsInWorkspace > "View the contents of my selected file in a new workspace" > | aString | > self reference streamWritable: false do: [ :stream| > aString := stream setConverterForCode contentsOfEntireFile ]. > Workspace openContents: aString label: 'Workspace from ', self reference > basename > > And i also proposse the add a Playground case. > > New Method: > > FileList>>viewContentsInPlayground > "View the contents of my selected file in a new playground" > | aString | > self reference streamWritable: false do: [ :stream| > aString := stream setConverterForCode contentsOfEntireFile ]. > GTPlayground openContents: aString label: 'Playground from ', self > reference basename. > > and also FileList>>serviceViewContentsInPlayground and the case in > ListList>>itemsForAnyFile. > > If ok, i can fix Workspace and add Playground menu to FileList, after i have > figured out how to send an fix ;-) > > BW, > Volkert > > > Am 03.06.2015 um 16:40 schrieb Ben Coman: > > Or do we now want such to open in Playground? > > btw, these are the relevant methods. > FileList>>FileList>>viewContentsInWorkspace > FileList>>viewContentsInWorkspace > > cheers -ben > > On Wed, Jun 3, 2015 at 6:57 PM, volkert <[hidden email]> > wrote: > > The File Browser has a Context Menu "Workspace with Contents". It opens an > Edit Window (String Morph), but not a Workspace ... > > Is the Menu-Title wrong or the implementation? > > BW, > Volkert > > |
|
|
In reply to this post by volkert-2
UIManager was an attempt to support a way to theme widgets.
And also to be able to run Pharo headless but providing a DummyManager. What is the original problem you faced? Stef Le 6/6/15 16:37, volkert a écrit :
Is this change resonable. I have no idea, what the Design-Idea behind the UIManager what services is should provide. May be it make sense to have the extra services on UIManager, but think the bug is in FileList>>viewContentsInWorkspace and not in UIManager. |
|
|
I have found a bug and opened new case for it: https://pharo.fogbugz.com/f/cases/15711/
I also what to send a fix. But i am not sure, if the fix is as simple as i described it (see tail of this mail). My Question: Is the bug in the UIManager or only on the sender FileList>>viewContentsInWorkspace. I think, in the sender. So i can simply replace "UIManager default edit: aString label: 'Workspace from ', self reference basename " with " Workspace openContents: aString label: 'Workspace from ', self reference basename". Am 07.06.2015 um 17:20 schrieb
stepharo:
UIManager was an attempt to support a way to theme widgets. |
Re: Bug in Open Workspace from File-Browser?
|
|
Maybe use Smalltalk tools workspace instead of the direct reference… In the long run, for GT, people will use the the FileList less and less and instead just use Spotter to explore the filesystem and then GT to look at files… We should try to replace the FileList by Spotter for Pharo5… less code to maintain. Marcus
|
Re: Bug in Open Workspace from File-Browser?
|
|
In reply to this post by volkert-2
If you want to open a workspace or a playground we should use:
viewContentsInWorkspace "View the contents of my selected file in a new workspace" | aString | self reference streamWritable: false do: [ :stream | aString := stream setConverterForCode contentsOfEntireFile ]. Smalltalk tools workspace openContents: aString label: 'Workspace from ' , self reference basename BUT! If we open a file which is not a Smalltalk code the syntax coloring is really a bad idea. Someone know if we can desable the syntax coloring for an instance of the playground or workspace ? If we can't we should change the name on the menu and not the action of the menu. Thank. On 6 June 2015 at 16:37, volkert <[hidden email]> wrote: > Is this change resonable. I have no idea, what the Design-Idea behind the > UIManager what services is should provide. May be it make sense to have the > extra services on UIManager, but think the bug is in > FileList>>viewContentsInWorkspace and not in UIManager. > > ---- > I propose for Workspace to change the current code: > > FileList>>viewContentsInWorkspace > "View the contents of my selected file in a new workspace" > | aString | > self reference streamWritable: false do: [ :stream| > aString := stream setConverterForCode contentsOfEntireFile ]. > UIManager default edit: aString label: 'Workspace from ', self reference > basename <----- WRONG > > to : > > FileList>>viewContentsInWorkspace > "View the contents of my selected file in a new workspace" > | aString | > self reference streamWritable: false do: [ :stream| > aString := stream setConverterForCode contentsOfEntireFile ]. > Workspace openContents: aString label: 'Workspace from ', self reference > basename > > And i also proposse the add a Playground case. > > New Method: > > FileList>>viewContentsInPlayground > "View the contents of my selected file in a new playground" > | aString | > self reference streamWritable: false do: [ :stream| > aString := stream setConverterForCode contentsOfEntireFile ]. > GTPlayground openContents: aString label: 'Playground from ', self > reference basename. > > and also FileList>>serviceViewContentsInPlayground and the case in > ListList>>itemsForAnyFile. > > If ok, i can fix Workspace and add Playground menu to FileList, after i have > figured out how to send an fix ;-) > > BW, > Volkert > > > Am 03.06.2015 um 16:40 schrieb Ben Coman: > > Or do we now want such to open in Playground? > > btw, these are the relevant methods. > FileList>>FileList>>viewContentsInWorkspace > FileList>>viewContentsInWorkspace > > cheers -ben > > On Wed, Jun 3, 2015 at 6:57 PM, volkert <[hidden email]> > wrote: > > The File Browser has a Context Menu "Workspace with Contents". It opens an > Edit Window (String Morph), but not a Workspace ... > > Is the Menu-Title wrong or the implementation? > > BW, > Volkert > > -- Cheers Cyril Ferlicot |
Re: Bug in Open Workspace from File-Browser?
|
|
Thank you volkert for the correction!
On 12 June 2015 at 11:05, Cyril Ferlicot <[hidden email]> wrote: > If you want to open a workspace or a playground we should use: > > viewContentsInWorkspace > "View the contents of my selected file in a new workspace" > > | aString | > self reference streamWritable: false do: [ :stream | aString := > stream setConverterForCode contentsOfEntireFile ]. > Smalltalk tools workspace openContents: aString label: 'Workspace > from ' , self reference basename > > BUT! > If we open a file which is not a Smalltalk code the syntax coloring is > really a bad idea. > Someone know if we can desable the syntax coloring for an instance of > the playground or workspace ? > > If we can't we should change the name on the menu and not the action > of the menu. > Thank. > > On 6 June 2015 at 16:37, volkert <[hidden email]> wrote: >> Is this change resonable. I have no idea, what the Design-Idea behind the >> UIManager what services is should provide. May be it make sense to have the >> extra services on UIManager, but think the bug is in >> FileList>>viewContentsInWorkspace and not in UIManager. >> >> ---- >> I propose for Workspace to change the current code: >> >> FileList>>viewContentsInWorkspace >> "View the contents of my selected file in a new workspace" >> | aString | >> self reference streamWritable: false do: [ :stream| >> aString := stream setConverterForCode contentsOfEntireFile ]. >> UIManager default edit: aString label: 'Workspace from ', self reference >> basename <----- WRONG >> >> to : >> >> FileList>>viewContentsInWorkspace >> "View the contents of my selected file in a new workspace" >> | aString | >> self reference streamWritable: false do: [ :stream| >> aString := stream setConverterForCode contentsOfEntireFile ]. >> Workspace openContents: aString label: 'Workspace from ', self reference >> basename >> >> And i also proposse the add a Playground case. >> >> New Method: >> >> FileList>>viewContentsInPlayground >> "View the contents of my selected file in a new playground" >> | aString | >> self reference streamWritable: false do: [ :stream| >> aString := stream setConverterForCode contentsOfEntireFile ]. >> GTPlayground openContents: aString label: 'Playground from ', self >> reference basename. >> >> and also FileList>>serviceViewContentsInPlayground and the case in >> ListList>>itemsForAnyFile. >> >> If ok, i can fix Workspace and add Playground menu to FileList, after i have >> figured out how to send an fix ;-) >> >> BW, >> Volkert >> >> >> Am 03.06.2015 um 16:40 schrieb Ben Coman: >> >> Or do we now want such to open in Playground? >> >> btw, these are the relevant methods. >> FileList>>FileList>>viewContentsInWorkspace >> FileList>>viewContentsInWorkspace >> >> cheers -ben >> >> On Wed, Jun 3, 2015 at 6:57 PM, volkert <[hidden email]> >> wrote: >> >> The File Browser has a Context Menu "Workspace with Contents". It opens an >> Edit Window (String Morph), but not a Workspace ... >> >> Is the Menu-Title wrong or the implementation? >> >> BW, >> Volkert >> >> > > > > -- > Cheers > Cyril Ferlicot -- Cheers Cyril Ferlicot |
|
|
In reply to this post by Marcus Denker-4
Marcus for certain application having a fileList is important.
You cannot ask your clients to use spotter to browse a file. Please do not confuse the usage. Stef Le 8/6/15 16:32, Marcus Denker a
écrit :
|
Re: Bug in Open Workspace from File-Browser?
|
|
> On 15 Jun 2015, at 09:02, stepharo <[hidden email]> wrote: > > Marcus for certain application having a fileList is important. > You cannot ask your clients to use spotter to browse a file. > Please do not confuse the usage. > The idea is to re-use the inspector panes in the FileList. If you don’t know that this is implemented like that you would never guess. Marcus |
«
Return to Pharo Smalltalk Users
|
1 view|%1 views
| Free forum by Nabble | Edit this page |