Bug in ProfStef

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug in ProfStef

Darius Clarke
Found a bug in ProfStef that is running online at amber-lang.net :

Reflection (22/24)

"Let's create a new method to go to the next lesson:"

|newMethod|
newMethod := Compiler new load: 'goToNextLesson ProfStef next.' forClass: ProfStef.
ProfStef class addCompiledMethod: newMethod

#load:forClass doesn't exist anymore. 

Needs to be changed to:

#install:forClass:category:

for example:

|newMethod|
newMethod := Compiler new install: 'goToNextLesson ProfStef next.' forClass: ProfStef category: 'fixed'.
ProfStef class addCompiledMethod: newMethod

- Darius


--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Darius Clarke
To jump to the offending page in Prof Stef, use DoIt on:

ProfStef default tutorialPlayer tutorialPosition: 22.
ProfStef default showCurrentLesson.

- Darius




On Sat, May 10, 2014 at 10:01 AM, Darius Clarke <[hidden email]> wrote:
Found a bug in ProfStef that is running online at amber-lang.net :

Reflection (22/24)

"Let's create a new method to go to the next lesson:"

|newMethod|
newMethod := Compiler new load: 'goToNextLesson ProfStef next.' forClass: ProfStef.
ProfStef class addCompiledMethod: newMethod

#load:forClass doesn't exist anymore. 

Needs to be changed to:

#install:forClass:category:

for example:

|newMethod|
newMethod := Compiler new install: 'goToNextLesson ProfStef next.' forClass: ProfStef category: 'fixed'.
ProfStef class addCompiledMethod: newMethod

- Darius



--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Darius Clarke
Located in the code at:

TrySmalltalk SmalltalkSyntaxTutorial>>reflection


On Sat, May 10, 2014 at 10:17 AM, Darius Clarke <[hidden email]> wrote:
To jump to the offending page in Prof Stef, use DoIt on:

ProfStef default tutorialPlayer tutorialPosition: 22.
ProfStef default showCurrentLesson.

- Darius




On Sat, May 10, 2014 at 10:01 AM, Darius Clarke <[hidden email]> wrote:
Found a bug in ProfStef that is running online at amber-lang.net :

Reflection (22/24)

"Let's create a new method to go to the next lesson:"

|newMethod|
newMethod := Compiler new load: 'goToNextLesson ProfStef next.' forClass: ProfStef.
ProfStef class addCompiledMethod: newMethod

#load:forClass doesn't exist anymore. 

Needs to be changed to:

#install:forClass:category:

for example:

|newMethod|
newMethod := Compiler new install: 'goToNextLesson ProfStef next.' forClass: ProfStef category: 'fixed'.
ProfStef class addCompiledMethod: newMethod

- Darius




--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Darius Clarke
Should I make the change and submit a pull request?

- Darius

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Manfred Kröhnert
Hi Darius,

On Sat, May 10, 2014 at 9:33 PM, Darius Clarke <[hidden email]> wrote:
Should I make the change and submit a pull request?

- Darius

first of all thanks for reporting this bug and providing a solution.
But providing a pull request would be even better ;-)

Best,
Manfred
 

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Darius Clarke
I've made the change, but not sure of simplest way to test. ​

- Darius

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Darius Clarke
Tested. Created pull request. I've not generated .js from .st yet. Is that required for the pull request?

- Darius

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Herby Vojčík
Yes it is.  BTW how you tested without .js?

Darius Clarke wrote:

> Tested. Created pull request. I've not generated .js from .st yet. Is
> that required for the pull request?
>
> - Darius
>
> --
> You received this message because you are subscribed to the Google
> Groups "amber-lang" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to [hidden email]
> <mailto:[hidden email]>.
> For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Bug in ProfStef

Darius Clarke
I tested it by the IDE in the browser.

I've just submitted a pull request with the fix amber-examples  TrySmalltalk.st and TrySmalltalk.js 

Just pinging you to let you know this is still an issue in the amber-lang.net website. 

Users cannot complete the ProfStef lesson/slide 22 by following the directions. 

Please update amber-lang.net

Cheers,
Darius



On Sun, May 11, 2014 at 2:39 AM, Herby Vojčík <[hidden email]> wrote:
Yes it is.  BTW how you tested without .js?

Darius Clarke wrote:
Tested. Created pull request. I've not generated .js from .st yet. Is that required for the pull request?

- Darius

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email] <mailto:[hidden email]>.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.