Bug in WebSecurityManagerApp

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug in WebSecurityManagerApp

Nicolas Petton
Hi,

I found a bug in WebSecurityManagerApp: when I try to add a new user,
after I click on the save button, I've got the error message : this is
not a WebUserGroup. I only tested it in Squeak and VisualWorks.

I think I found the problem, it's in #addUser method. I simply replaced
it with:

actionAddUser
        self group ~= '' ifTrue: [self observee addUser: self usr].
        self newView: #users.

and it works now.

Cheers,

Nicolas
--
Nicolas Petton
http://nico.bioskop.fr
             ___
           ooooooo
          OOOOOOOOO
         |Smalltalk|
          OOOOOOOOO
           ooooooo
            \   /
             [|]
--------------------------------
Ma cl? GPG est disponible ici :
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE788C34D

-------------- section suivante --------------
Une pi?ce jointe non texte a ?t? nettoy?e...
Nom: non disponible
Type: application/pgp-signature
Taille: 189 octets
Desc: Ceci est une partie de message
        =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url: http://lists.aidaweb.si/pipermail/aida/attachments/20071023/33c308f2/attachment.sig 

Reply | Threaded
Open this post in threaded view
|

Bug in WebSecurityManagerApp

Janko Mivšek
Thanks Nicolas for the patch. I just don't know how this bug happened in
first place but it can be that VW source control system Store and its
overriding mechanism can be blamed. We need more tests to cover Aida and
be run before build to check for such silly bugs.

Janko

nicolas petton wrote:

> Hi,
>
> I found a bug in WebSecurityManagerApp: when I try to add a new user,
> after I click on the save button, I've got the error message : this is
> not a WebUserGroup. I only tested it in Squeak and VisualWorks.
>
> I think I found the problem, it's in #addUser method. I simply replaced
> it with:
>
> actionAddUser
> self group ~= '' ifTrue: [self observee addUser: self usr].
> self newView: #users.
>
> and it works now.
>
> Cheers,
>
> Nicolas
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Aida mailing list
> Aida na aidaweb.si
> http://lists.aidaweb.si/mailman/listinfo/aida

--
Janko Miv?ek
AIDA/Web
Smalltalk Web Application Server
http://www.aidaweb.si