Bug in v3.2 version of mkdtemp.c

Paolo,

Just an FYI.. There's a typo in the code for mkdtemp.c in the
lib-src directory of the GST 3.2 package.. The typo is a
missing "T" in the first "attempts" line at the end..

#if defined TMP_MAX
  unsigned int attempts = ATTEMPTS_MIN < TMP_MAX ? TMP_MAX : ATTEMPS_MIN;
#else
  unsigned int attempts = ATTEMPTS_MIN;
#endif

-- Rick

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

On Wed, 19 May 2010 17:47:08 -0700, Rick Flower <[hidden email]>
wrote:
> Paolo,
>
> Just an FYI.. There's a typo in the code for mkdtemp.c in the
> lib-src directory of the GST 3.2 package.. The typo is a
> missing "T" in the first "attempts" line at the end..
>
> #if defined TMP_MAX
>   unsigned int attempts = ATTEMPTS_MIN < TMP_MAX ? TMP_MAX :
ATTEMPS_MIN;
> #else
>   unsigned int attempts = ATTEMPTS_MIN;
> #endif

One more in packages/digest/sha1.h :

Solaris does not have an include file called
stdint.h so I changed it to this which works
OK for Solaris -- not sure what the best fix might
be :

#ifndef SHA1_H
# define SHA1_H 1

# include <stdio.h>
#include <sys/types.h>            <--- Added for Solaris
//# include <stdint.h>            <--- Commented out

/* Structure to save state of computation between the single steps.  */
struct sha1_ctx
{
...

Those were the only issues I ran into for a Solaris 2.8
build (sans any X windows stuff)

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Adding sys/types.h is okay.  You can wrap the stdint.h inclusion with

#ifdef HAVE_STDINT_H
#endif

Thanks for the report, I'll apply the changes to stable-3.2.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

On 05/20/2010 03:09 AM, Rick Flower wrote:
> Those were the only issues I ran into for a Solaris 2.8
> build (sans any X windows stuff)

I pushed fixes for both of them.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Thx!

On May 20, 2010, at 5:01 AM, Paolo Bonzini <[hidden email]> wrote:

> On 05/20/2010 03:09 AM, Rick Flower wrote:
>> Those were the only issues I ran into for a Solaris 2.8
>> build (sans any X windows stuff)
>
> I pushed fixes for both of them.
>
> Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk