Hi
Downloading the latest OB today with: Gofer new squeaksource: 'rb'; package: 'AST-Core'; package: 'Refactoring-Core'; package: 'Refactoring-Changes'; package: 'Refactoring-Critics'; package: 'Refactoring-Environment'; load. Gofer new renggli: 'omnibrowser'; package: 'OmniBrowser'; package: 'OB-Standard'; package: 'OB-Morphic'; package: 'OB-Refactory'; load. Then I change the superclass of the template of an existing class, then accept: Object subclass: #FileContentsBrowser instanceVariableNames: 'packages infoString' classVariableNames: '' poolDictionaries: '' category: 'Tools-File Contents Browser' The superclass is not changed, instead OB changes its focus to the superclass. Can anyone confirm this bug? -- Simon _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
hi Simon,
I cannot reproduce. It works as expected for me. Alexandre On 14 Oct 2010, at 12:43, Simon Denier wrote: > Hi > > Downloading the latest OB today with: > > Gofer new > squeaksource: 'rb'; > package: 'AST-Core'; > package: 'Refactoring-Core'; > package: 'Refactoring-Changes'; > package: 'Refactoring-Critics'; > package: 'Refactoring-Environment'; > load. > > Gofer new > renggli: 'omnibrowser'; > package: 'OmniBrowser'; > package: 'OB-Standard'; > package: 'OB-Morphic'; > package: 'OB-Refactory'; > load. > > > Then I change the superclass of the template of an existing class, then accept: > > Object subclass: #FileContentsBrowser > instanceVariableNames: 'packages infoString' > classVariableNames: '' > poolDictionaries: '' > category: 'Tools-File Contents Browser' > > > The superclass is not changed, instead OB changes its focus to the superclass. > > Can anyone confirm this bug? > > > -- > Simon > > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Hi Simon,
It works for me too, the change can even be undone and redone. Also this should be tested as part of the unit tests. Maybe try to load the code again and recompile all packages: Gofer new squeaksource: 'rb'; package: 'AST-Core'; package: 'Refactoring-Core'; package: 'Refactoring-Changes'; package: 'Refactoring-Critics'; package: 'Refactoring-Environment'; load; recompile. Gofer new renggli: 'omnibrowser'; package: 'OmniBrowser'; package: 'OB-Standard'; package: 'OB-Morphic'; package: 'OB-Refactory'; load; recompile On 14 October 2010 19:23, Alexandre Bergel <[hidden email]> wrote: > hi Simon, > > I cannot reproduce. It works as expected for me. > > Alexandre > > > On 14 Oct 2010, at 12:43, Simon Denier wrote: > >> Hi >> >> Downloading the latest OB today with: >> >> Gofer new >> squeaksource: 'rb'; >> package: 'AST-Core'; >> package: 'Refactoring-Core'; >> package: 'Refactoring-Changes'; >> package: 'Refactoring-Critics'; >> package: 'Refactoring-Environment'; >> load. >> >> Gofer new >> renggli: 'omnibrowser'; >> package: 'OmniBrowser'; >> package: 'OB-Standard'; >> package: 'OB-Morphic'; >> package: 'OB-Refactory'; >> load. >> >> >> Then I change the superclass of the template of an existing class, then accept: >> >> Object subclass: #FileContentsBrowser >> instanceVariableNames: 'packages infoString' >> classVariableNames: '' >> poolDictionaries: '' >> category: 'Tools-File Contents Browser' >> >> >> The superclass is not changed, instead OB changes its focus to the superclass. >> >> Can anyone confirm this bug? >> >> >> -- >> Simon >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Alexandre Bergel
On 14 oct. 2010, at 19:37, Lukas Renggli wrote: > Hi Simon, > > It works for me too, the change can even be undone and redone. Also > this should be tested as part of the unit tests. > > Maybe try to load the code again and recompile all packages: > > Gofer new > squeaksource: 'rb'; > package: 'AST-Core'; > package: 'Refactoring-Core'; > package: 'Refactoring-Changes'; > package: 'Refactoring-Critics'; > package: 'Refactoring-Environment'; > load; > recompile. > > Gofer new > renggli: 'omnibrowser'; > package: 'OmniBrowser'; > package: 'OB-Standard'; > package: 'OB-Morphic'; > package: 'OB-Refactory'; > load; > recompile Indeed it works as expected when I reload+recompile. Thanks Lukas. > > > On 14 October 2010 19:23, Alexandre Bergel <[hidden email]> wrote: >> hi Simon, >> >> I cannot reproduce. It works as expected for me. >> >> Alexandre >> >> >> On 14 Oct 2010, at 12:43, Simon Denier wrote: >> >>> Hi >>> >>> Downloading the latest OB today with: >>> >>> Gofer new >>> squeaksource: 'rb'; >>> package: 'AST-Core'; >>> package: 'Refactoring-Core'; >>> package: 'Refactoring-Changes'; >>> package: 'Refactoring-Critics'; >>> package: 'Refactoring-Environment'; >>> load. >>> >>> Gofer new >>> renggli: 'omnibrowser'; >>> package: 'OmniBrowser'; >>> package: 'OB-Standard'; >>> package: 'OB-Morphic'; >>> package: 'OB-Refactory'; >>> load. >>> >>> >>> Then I change the superclass of the template of an existing class, then accept: >>> >>> Object subclass: #FileContentsBrowser >>> instanceVariableNames: 'packages infoString' >>> classVariableNames: '' >>> poolDictionaries: '' >>> category: 'Tools-File Contents Browser' >>> >>> >>> The superclass is not changed, instead OB changes its focus to the superclass. >>> >>> Can anyone confirm this bug? >>> >>> >>> -- >>> Simon >>> >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- Simon _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Free forum by Nabble | Edit this page |