Smalltalk › Squeak › Squeak VM

Build failed: opensmalltalk-vm 1.0.1504

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

AppVeyor

Build failed: opensmalltalk-vm 1.0.1504

Build opensmalltalk-vm 1.0.1504 failed

Commit 5f8620febe by [hidden email] on 12/6/2018 4:28 PM:
Fix compile for Windows serial

Configure your notification preferences

Ben Coman

Re: Build failed: opensmalltalk-vm 1.0.1504

On Fri, 7 Dec 2018 at 00:46, AppVeyor <[hidden email]> wrote:

Build opensmalltalk-vm 1.0.1504 failed

Commit 5f8620febe by [hidden email] on 12/6/2018 4:28 PM:
Fix compile for Windows serial

This failed with....

../../platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c:76:14: error: redeclaration of 'serialPortClose' cannot add 'dllexport' attribute

EXPORT (int) serialPortClose(int portNum) {

Here are all the other definition...

https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=serialPortClose&unscoped_q=serialPortClose

I'm not sure which way to jump...

* remove the EXPORT from (which might also need it removed from sqMacSerialPort.c.

* push EXPORT out further into the other files

Can someone advise?

cheers -ben

Eliot Miranda-2

Re: Build failed: opensmalltalk-vm 1.0.1504

HI Ben,

On Thu, Dec 6, 2018 at 10:37 AM Ben Coman <[hidden email]> wrote:

On Fri, 7 Dec 2018 at 00:46, AppVeyor <[hidden email]> wrote:

Build opensmalltalk-vm 1.0.1504 failed

Commit 5f8620febe by [hidden email] on 12/6/2018 4:28 PM:
Fix compile for Windows serial

This failed with....
../../platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c:76:14: error: redeclaration of 'serialPortClose' cannot add 'dllexport' attribute
EXPORT (int) serialPortClose(int portNum) {

Here are all the other definition...
https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=serialPortClose&unscoped_q=serialPortClose

I'm not sure which way to jump...
* remove the EXPORT from (which might also need it removed from sqMacSerialPort.c.
* push EXPORT out further into the other files

Can someone advise?

I don't understand why the build is trying to compile platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c at all. i.e.

On Mac OS X platforms/iOS/plugins/SerialPlugin/Makefile contains "LIBSRC:=SerialPlugin.c sqUnixSerial.c", which causes only those two to be compiled.

On Unix platforms/unix/plugins/SerialPlugin/Makefile.inc contains "OBJS=SerialPlugin$o sqUnixSerial$o" which does the same.

On Windows... damn, I forgot to write that. OK, give me a few...

cheers -ben

_,,,^..^,,,_

best, Eliot