Smalltalk › Pharo › Pharo Smalltalk Developers

CI Issue on PR

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

darth-cheney

CI Issue on PR

Hello all,

I'm having a strange issue with CI on my recent pull request. See https://github.com/pharo-project/pharo/pull/1666#issuecomment-409431721

The short if it is that tests are failing because it seems some of the new classes I created are not being loaded into whatever CI is doing. Those classes are clearly in the commits however. Not sure how to handle this. It's entirely possible I messed up a part of this process.

Any suggestions?

Eric

Guillermo Polito

Re: CI Issue on PR

Just FYI, Pablo has answered in the PR.

In short, adding new packages means adding them also in the baselines, otherwise metacello does not load them.

On Wed, Aug 1, 2018 at 6:48 AM Eric Gade <[hidden email]> wrote:

Hello all,

I'm having a strange issue with CI on my recent pull request. See https://github.com/pharo-project/pharo/pull/1666#issuecomment-409431721

The short if it is that tests are failing because it seems some of the new classes I created are not being loaded into whatever CI is doing. Those classes are clearly in the commits however. Not sure how to handle this. It's entirely possible I messed up a part of this process.

Any suggestions?

--
Eric

Guille Polito

Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille

CRIStAL - UMR 9189

French National Center for Scientific Research - http://www.cnrs.fr

Web: http://guillep.github.io

Phone: +33 06 52 70 66 13