Calypso zero class refs for TComparable

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Calypso zero class refs for TComparable

Ben Coman
I expected TComparable to be used somewhere in the Image?

So I was surprised that with Calypso,
right-clicking on  TComparable and choosing "Class refs"
brought up zero results.

Is this expected behaviour? (in 70793)

cheers -ben
Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

CyrilFerlicot

On dim. 22 avr. 2018 at 03:54, Ben Coman <[hidden email]> wrote:
I expected TComparable to be used somewhere in the Image?

So I was surprised that with Calypso,
right-clicking on  TComparable and choosing "Class refs"
brought up zero results.

Hi,

In Nautilus the Traits are not "referenced", they are used. So you have "Find usage" instead of "Find reference".

Maybe this option is missing on Calypso? (I suppose since I still use Pharo 6.1 because all my projects are around Seaside which does not load in P7)


Is this expected behaviour? (in 70793)

cheers -ben
--
Cyril Ferlicot
https://ferlicot.fr
Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

Denis Kudriashov
Hi.

When you select trait new hierarchy mode appears: trait users.

2018-04-22 11:59 GMT+02:00 Cyril Ferlicot <[hidden email]>:

On dim. 22 avr. 2018 at 03:54, Ben Coman <[hidden email]> wrote:
I expected TComparable to be used somewhere in the Image?

So I was surprised that with Calypso,
right-clicking on  TComparable and choosing "Class refs"
brought up zero results.

Hi,

In Nautilus the Traits are not "referenced", they are used. So you have "Find usage" instead of "Find reference".

Maybe this option is missing on Calypso? (I suppose since I still use Pharo 6.1 because all my projects are around Seaside which does not load in P7)


Is this expected behaviour? (in 70793)

cheers -ben
--
Cyril Ferlicot
https://ferlicot.fr

Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

Ben Coman

Hi,

In Nautilus the Traits are not "referenced", they are used. So you have "Find usage" instead of "Find reference".

Maybe this option is missing on Calypso? (I suppose since I still use Pharo 6.1 because all my projects are around Seaside which does not load in P7)


Is this expected behaviour? (in 70793)

cheers -ben
 
2018-04-22 11:59 GMT+02:00 Cyril Ferlicot <[hidden email]>:

On dim. 22 avr. 2018 at 03:54, Ben Coman <[hidden email]> wrote:
I expected TComparable to be used somewhere in the Image?

So I was surprised that with Calypso,
right-clicking on  TComparable and choosing "Class refs"
brought up zero results.



On 22 April 2018 at 18:45, Denis Kudriashov <[hidden email]> wrote:
Hi.

When you select trait new hierarchy mode appears: trait users.

I see it now, but clicking it for  TComparable does't show anything. Is that right?
Can you advise a Trait that shows some results as an example?

cheers -ben 
Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

Denis Kudriashov

2018-04-22 16:01 GMT+02:00 Ben Coman <[hidden email]>:
On 22 April 2018 at 18:45, Denis Kudriashov <[hidden email]> wrote:
Hi.

When you select trait new hierarchy mode appears: trait users.

I see it now, but clicking it for  TComparable does't show anything. Is that right?

Yes.

TComparable users ==> #() 

Can you advise a Trait that shows some results as an example?

ClyTraitChild1 browse


cheers -ben 

Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

Ben Coman


On 22 April 2018 at 22:16, Denis Kudriashov <[hidden email]> wrote:

2018-04-22 16:01 GMT+02:00 Ben Coman <[hidden email]>:
On 22 April 2018 at 18:45, Denis Kudriashov <[hidden email]> wrote:
Hi.

When you select trait new hierarchy mode appears: trait users.

I see it now, but clicking it for  TComparable does't show anything. Is that right?

Yes.

TComparable users ==> #() 

Can you advise a Trait that shows some results as an example?

ClyTraitChild1 browse


Thanks.  And now it makes sense.  Traits aren't referenced directly in code.
cheers -ben
Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

HilaireFernandes
In reply to this post by CyrilFerlicot
Le 22/04/2018 à 11:59, Cyril Ferlicot a écrit :
>
> In Nautilus the Traits are not "referenced", they are used. So you
> have "Find usage" instead of "Find reference".
>
This distinction is confusing, and it will confuse people as it confused
Ben and me as well.

Hilaire

--
Dr. Geo
http://drgeo.eu



Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

HilaireFernandes
In reply to this post by Denis Kudriashov
Denis,

Here is my experience on that:

1. I did not expect the trait user radio button, so I did not look at it.

2. However I request the contextual menu over the trait and expect
something to see its users, and I get the menu entry "Class ref.", and
went there.

Other user opinion may be needed, but from my POV 1. is uneeded, 2.
"Class ref." should be replaced by "Users".

It will make your UI more consistent and predictable to the end user.

Hilaire


Le 22/04/2018 à 12:45, Denis Kudriashov a écrit :
> Hi.
>
> When you select trait new hierarchy mode appears: trait users.
>

--
Dr. Geo
http://drgeo.eu



Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

Stephane Ducasse-3
In reply to this post by HilaireFernandes
Yes I'm afraid that you are right.

What I did in the past was
    implementor on class -> class def
    sender on class -> class ref
    may be we could do the same for traits

Stef

On Sun, Apr 22, 2018 at 5:13 PM, Hilaire <[hidden email]> wrote:

> Le 22/04/2018 à 11:59, Cyril Ferlicot a écrit :
>>
>>
>> In Nautilus the Traits are not "referenced", they are used. So you have
>> "Find usage" instead of "Find reference".
>>
> This distinction is confusing, and it will confuse people as it confused Ben
> and me as well.
>
> Hilaire
>
> --
> Dr. Geo
> http://drgeo.eu
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Calypso zero class refs for TComparable

Denis Kudriashov
In reply to this post by HilaireFernandes
Hi

2018-04-22 17:19 GMT+02:00 Hilaire <[hidden email]>:
Denis,

Here is my experience on that:

1. I did not expect the trait user radio button, so I did not look at it.

2. However I request the contextual menu over the trait and expect something to see its users, and I get the menu entry "Class ref.", and went there.

Other user opinion may be needed, but from my POV 1. is uneeded, 2. "Class ref." should be replaced by "Users".

Traits are normal classes. They can be used directly in code. It is not common practice but I saw such code.

But I am wondering that extra radio button is not intuitive solution for you. It is placed nearly Flat/Hier options because it is another kind of class relationship.
To me it is consistent to access it in same way like "class->superclass" relationship. And there is another option "Traits" for classes which uses traits.

And notice that we do not show subclasses of class in the result of "Class refs" query.
 

It will make your UI more consistent and predictable to the end user.

Hilaire



Le 22/04/2018 à 12:45, Denis Kudriashov a écrit :
Hi.

When you select trait new hierarchy mode appears: trait users.


--
Dr. Geo
http://drgeo.eu