Can Sound depend on Jobs?

I wanted to add as an extension method to the Sound package:
Job>>#beepAtEnd
        "Sound must first be enabled via `SoundSystem soundEnabled: true.`"
       
        self announcer when: JobEnd do: [ SoundSystem current beep ]

I figured I'd get some feedback first since I know we're trying to reduce dependencies...

Do you mean that job depends on sound?

I think it should not.

Can't that be an extension of yours? (in a method extension, in a
separate package)?

Guille

-------- Original Message --------

The questions we should ask ourselves always:
- Would it make sense to use Sound without Jobs?
- Would it make sense to use Jobs without Sound?

First, I just want to say I do not have the answer to that question because I do not know those packages very well.
Butttt.... it's smelly to me. My reflex is to put that as a third package.

Second and more meta, I think we should ask ourselves those questions more often (just like Sean did, thanks Sean! :D).

2016-09-05 9:55 GMT+02:00 Guille Polito <[hidden email]>:

Do you mean that job depends on sound?

I guess Sean wants put #beepAtEnd to Sound package as Job extension. Is such dependency valid?  

Guille Polito wrote

The questions we should ask ourselves always:

Yes to both, so it seems a third package (with only one method in it!) is in order. Thanks for helping me think this through!

Sean P. DeNigris wrote

it seems a third package (with only one method in it!) is in order.

Any ideas on where to commit the JobsSound package?

close to the sound package.


Le 5/9/16 à 19:18, Sean P. DeNigris a écrit :