Cascading TagBrush

Hi guys,
The latest version of at:put: doesn't allow cascading TagBrush messages.

aHTMLCanvas div id: 'test'; class: 'modal hide fade'; at: 'aria-hidden' put: true.
returns true instead of aTagBrush.

The implementation changed from:
at: aString put: aValue
    <self['@element'].setAttribute(aString, aValue)>

to:
at: aString put: aValue
        <self['@element'].setAttribute(aString, aValue); return aValue>

Is there any reason for that?
Thanks

laci wrote:
> Hi guys,
> The latest version of at:put: doesn't allow cascading TagBrush messages.
>
> aHTMLCanvas div id: 'test'; class: 'modal hide fade'; at: 'aria-hidden' put:
> true.
> returns true instead of aTagBrush.

Well, what you just did _is_ cascading. So cascading works perfectly fine - cascade returns the return value of last message.

If you want to return the receiver from the cascade, add 'yourself' message at the end of cascade.

BTW, Amber coding conventions on the wiki say you always should include 'yourself'.

> The implementation changed from:
> at: aString put: aValue
>      <self['@element'].setAttribute(aString, aValue)>
>
> to:
> at: aString put: aValue
> <self['@element'].setAttribute(aString, aValue); return aValue>
>
> Is there any reason for that?

Yes. All decent and nice at:put: methods return the object that is being put. TagBrush >> at:put: was incorrect and was fixed.

> Thanks

Herby

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.

---

From: Herby Vojčík [via Smalltalk]
Sent: 30/12/2013 18:00
To: laci
Subject: Re: Cascading TagBrush



laci wrote:
> Hi guys,
> The latest version of at:put: doesn't allow cascading TagBrush messages.
>
> aHTMLCanvas div id: 'test'; class: 'modal hide fade'; at: 'aria-hidden' put:
> true.
> returns true instead of aTagBrush.

Well, what you just did _is_ cascading. So cascading works perfectly fine - cascade returns the return value of last message.

If you want to return the receiver from the cascade, add 'yourself' message at the end of cascade.

BTW, Amber coding conventions on the wiki say you always should include 'yourself'.

> The implementation changed from:
> at: aString put: aValue
>      <self['@element'].setAttribute(aString, aValue)>
>
> to:
> at: aString put: aValue
> <self['@element'].setAttribute(aString, aValue); return aValue>
>
> Is there any reason for that?

Yes. All decent and nice at:put: methods return the object that is being put. TagBrush >> at:put: was incorrect and was fixed.

> Thanks

Herby

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.

---